Received-SPF: pass (google.com: domain of 9front-bounces@ewsd.inri.net designates 107.191.116.128 as permitted sender) client-ip=107.191.116.128;
Message-ID: <986B00BF344BEA5138FCE87D1E515963@sirjofri.de>
To: 9front@9front.org
Date: Fri, 04 Dec 2020 09:28:34 +0100
From: sirjofri+ml-9front@sirjofri.de
In-Reply-To: <609D21C8EF9760D5791F1710BBF1CA12@sirjofri.de>
MIME-Version: 1.0
Content-Type: multipart/mixed;
	boundary="upas-ddndvuuvikhujjnyzbhwqzliqo"
Subject: Re: [9front] patch: faces -c remove faces on click
Reply-To: 9front@9front.org
Precedence: bulk

This is a multi-part message in MIME format.
--upas-ddndvuuvikhujjnyzbhwqzliqo
Content-Disposition: inline
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

hello again,

I guess this is the final patch version, this time with an updated
'usage' message.

So in total we have:

- The change itself.
- Notes in the man page.
- Updated 'usage' message.

sirjofri
.


--upas-ddndvuuvikhujjnyzbhwqzliqo
Content-Disposition: inline
Content-Type: text/plain; charset="US-ASCII"
Content-Transfer-Encoding: 7bit

diff -r 73caf2698436 sys/man/1/faces
--- a/sys/man/1/faces	Tue Dec 01 09:23:16 2020 +0100
+++ b/sys/man/1/faces	Fri Dec 04 09:24:34 2020 +0100
@@ -4,7 +4,7 @@
 .SH SYNOPSIS
 .B faces
 [
-.B -ih
+.B -ihc
 ] [
 .B -m
 .I maildir
@@ -86,6 +86,12 @@
 .B -m
 flags may be used to watch multiple mailboxes.
 .PP
+Starting
+.I faces
+with the
+.B -c
+flag allows the user to remove faces with a click with button 1.
+.PP
 The
 .B -h
 flag causes a different, venerable behavior in which
diff -r 73caf2698436 sys/src/cmd/faces/main.c
--- a/sys/src/cmd/faces/main.c	Tue Dec 01 09:23:16 2020 +0100
+++ b/sys/src/cmd/faces/main.c	Fri Dec 04 09:24:34 2020 +0100
@@ -9,6 +9,7 @@
 
 int	history = 0;	/* use old interface, showing history of mailbox rather than current state */
 int	initload = 0;	/* initialize program with contents of mail box */
+int	clickrm = 0;	/* allows removing mail faces by left clicking */
 
 enum
 {
@@ -600,7 +601,7 @@
 		}else{
 			for(i=first; i<last; i++)	/* clear vwhois faces */
 				if(ptinrect(p, facerect(i-first)) 
-				&& strstr(faces[i]->str[Sshow], "/XXXvwhois")){
+				&& (clickrm || strstr(faces[i]->str[Sshow], "/XXXvwhois"))){
 					delface(i);
 					flushimage(display, 1);
 				}
@@ -675,7 +676,7 @@
 void
 usage(void)
 {
-	fprint(2, "usage: faces [-hi] [-m maildir]\n");
+	fprint(2, "usage: faces [-chi] [-m maildir]\n");
 	exits("usage");
 }
 
@@ -695,6 +696,9 @@
 		addmaildir(EARGF(usage()));
 		maildir = nil;
 		break;
+	case 'c':
+		clickrm++;
+		break;
 	default:
 		usage();
 	}ARGEND
--upas-ddndvuuvikhujjnyzbhwqzliqo--