From mboxrd@z Thu Jan  1 00:00:00 1970
X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org
X-Spam-Level: 
X-Spam-Status: No, score=0.0 required=5.0 tests=none autolearn=ham
	autolearn_force=no version=3.4.4
Received: (qmail 6608 invoked from network); 16 Nov 2022 03:10:28 -0000
Received: from 9front.inri.net (168.235.81.73)
  by inbox.vuxu.org with ESMTPUTF8; 16 Nov 2022 03:10:28 -0000
Received: from mimir.eigenstate.org ([206.124.132.107]) by 9front; Tue Nov 15 22:09:10 -0500 2022
Received: from abbatoir (pool-108-27-53-161.nycmny.fios.verizon.net [108.27.53.161])
	by mimir.eigenstate.org (OpenSMTPD) with ESMTPSA id a4a63396 (TLSv1.2:ECDHE-RSA-AES256-SHA:256:NO)
	for <9front@9front.org>;
	Tue, 15 Nov 2022 19:09:08 -0800 (PST)
Message-ID: <F52BAA9C1E8DBEEEA758286456EF2D5F@eigenstate.org>
To: 9front@9front.org
Date: Tue, 15 Nov 2022 22:09:06 -0500
From: ori@eigenstate.org
In-Reply-To: <3M903J9M0U8R4.2WW93NM7C4G44@mforney.org>
MIME-Version: 1.0
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
List-ID: <9front.9front.org>
List-Help: <http://lists.9front.org>
X-Glyph: ➈
X-Bullshit: reduce/map hardware-aware SQL CSS polling control 
Subject: Re: [9front] [PATCH] tee: remove unused variable in
Reply-To: 9front@9front.org
Precedence: bulk

Quoth Michael Forney <mforney@mforney.org>:
> Sigrid Solveig Haflínudóttir <sigrid@ftrv.se> wrote:
> > Your original patch looks wrong - git/import could
> > not apply it. Git/export is supposed to produce the
> > right thing.
> 
> Although the patch isn't what you'd get with git/commit and git/export,
> I don't think anything is wrong with it apart from being a bit
> unconventional. We should be able to deal with it with our tools.
> 
> There are two issues here:
> 1. The patch relies on standard filename detection behavior that
>    our new patch implementation doesn't follow. There are plenty
>    of patches in the wild like this, and I mentioned it in the
>    `patch(1) filename detection thread` a while back. I have a local
>    patch patch in my queue that fixes this.
> 2. git/import has no way to forward -p arguments to patch. git am
>    has this, and it seems both useful and easy to add to git/import.
> 
> With both of those fixed, git/import -p0 would do the trick.

seems sane to me.