From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.0 required=5.0 tests=T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 5348 invoked from network); 10 Jul 2022 18:31:59 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 10 Jul 2022 18:31:59 -0000 Received: from duke.felloff.net ([216.126.196.34]) by 9front; Sun Jul 10 14:29:55 -0400 2022 Message-ID: Date: Sun, 10 Jul 2022 20:29:44 +0200 From: cinap_lenrek@felloff.net To: 9front@9front.org In-Reply-To: <80149CA0DE680A311CCA7F4AE4F4167B@eigenstate.org> MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: virtual lossless injection CMS database Subject: Re: [9front] sysproc: raise limit on shebang lines, handle quoting. Reply-To: 9front@9front.org Precedence: bulk > - s += 2; > - n -= 2; /* skip #! */ i'd keep these lines, avoiding the multiple s+2 expressions down the road. my main concern is making sure we'r not blowing the stack with this change on archs with small 4k stacks like 32bit arm. just need to checks... also: > + ehdr = (void*)buf; not sure if that will yield properly aligned ehdr pointer as buf is just char[]. i think that was the reason it was a union before. otherwise looks ok. -- cinap