Re: [9front] auth_getkey: Fix a memory leak

[Josiah Frentsos <jfrent@tilde.team>]

On Mon, Nov 14, 2022 at 10:45:48PM +0100, Alex Musolino wrote:
> > diff 0e9c5f30eabbf213023658efb863dbaf6a608a51 uncommitted
> > --- a/sys/src/libauth/auth_getkey.c
> > +++ b/sys/src/libauth/auth_getkey.c
> > @@ -25,6 +25,7 @@
> >        werrstr("auth_getkey: /factotum may be bad: didn't get key %s", params);
> >        return -1;
> >    }
> > +    free(d);
> >    switch(pid = fork()){
> >    case -1:
> >        werrstr("can't fork for %s: %r", name);
> 
> Good find, but we need to free the Dir in the ???/factotum may be bad??? case too. Just latch the type and free the Dir unconditionally before checking the type.

if(0)	if(d->type != '/'){
^^^^^
		werrstr("auth_getkey: /factotum may be bad: didn't get key %s", params);
		return -1;
	}

Should that part be removed?