From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: X-Spam-Status: No, score=-0.1 required=5.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,UNPARSEABLE_RELAY autolearn=ham autolearn_force=no version=3.4.4 Received: (qmail 26373 invoked from network); 15 Nov 2022 22:34:45 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 15 Nov 2022 22:34:45 -0000 Received: from tilde.team ([198.50.210.248]) by 9front; Tue Nov 15 17:33:22 -0500 2022 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=tilde.team; s=mail; t=1668551600; bh=IA4jEtINUgQFTSr45SlAjaO1jVz0qb8Lyc8+Y9/Y8Zk=; h=Date:From:To:Subject:References:In-Reply-To:From; b=BNUPsAqSnZ34twFn3MePKbeqClj4W3Rk3/wg+7bg9wdvGLchqEo4M3f2q2xweSr4H JRYoqj5W9J4sVTjgy4Jv4taY9JU7LKlkbGsoslapxwZGOORAbm10KG3xMvaho6j0VO VIdv0ZaN2PULBiM4mWCC4BtU1X8qfwokE/Ju/tf0= Received: from quark.home.arpa (unknown [IPv6:2607:fb91:131a:476b:cd9c:c929:94c8:143a]) by tilde.team (Postfix) with ESMTPSA id 7B8824C029D for <9front@9front.org>; Tue, 15 Nov 2022 22:33:20 +0000 (UTC) Received: from localhost (quark.home.arpa [local]) by quark.home.arpa (OpenSMTPD) with ESMTPA id 619c0dc2 for <9front@9front.org>; Tue, 15 Nov 2022 17:33:18 -0500 (EST) Date: Tue, 15 Nov 2022 17:33:18 -0500 From: Josiah Frentsos To: 9front@9front.org Message-ID: Mail-Followup-To: 9front@9front.org References: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: DOM-aware framework CSS interface Subject: Re: [9front] auth_getkey: Fix a memory leak Reply-To: 9front@9front.org Precedence: bulk On Tue, Nov 15, 2022 at 10:44:07AM +0100, Alex Musolino wrote: > > if(0) if(d->type != '/'){ > > ^^^^^ > > werrstr("auth_getkey: /factotum may be bad: didn't get key %s", params); > > return -1; > > } > > > > Should that part be removed? > > Oh, I didn???t even notice the if(0) way over there. Perhaps we can just remove the dead code? Can we?