9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Anthony Martin <ality@pbrane.org>
To: 9front@9front.org
Subject: [9front] Re: boot/efi: support framebuffer with 64-bit base address
Date: Thu, 18 Feb 2021 12:23:59 -0800	[thread overview]
Message-ID: <YC7M31aMMMSBFkEW@alice> (raw)
In-Reply-To: <C0D9A13E6FF1D15A9EAEE323C406407A@arrow.hsd1.ca.comcast.net>

Michael Forney <mforney@mforney.org> once said:
>  char*
>  hexfmt(char *s, int i, uvlong a)
>  {
> -	if(i > 8){
> -		s = numfmt(s, 16, i-8, a>>32);
> +	if(i > 8 || i == 0 && (a>>32) != 0){
> +		s = numfmt(s, 16, i ? i-8 : 0, a>>32);
>  		i = 8;
>  	}
>  	return numfmt(s, 16, i, a);

I'd change numfmt to take a uvlong instead
of adding another special case to hexfmt.

  Anthony

  reply	other threads:[~2021-02-18 20:32 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-02-18  8:58 [9front] " Michael Forney
2021-02-18 20:23 ` Anthony Martin [this message]
2021-02-18 21:54   ` [9front] " Michael Forney
2021-02-20 11:48   ` cinap_lenrek
2021-02-20 11:56 ` [9front] " cinap_lenrek

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YC7M31aMMMSBFkEW@alice \
    --to=ality@pbrane.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).