9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Anthony Martin <ality@pbrane.org>
To: 9front@9front.org
Subject: Re: [9front] fix race condition on writes to #v/vgactl
Date: Tue, 16 Aug 2022 16:02:08 -0700	[thread overview]
Message-ID: <Yvwh8PE+laVJ4v0s@alice> (raw)
In-Reply-To: <E9ABB2B557B7868E845353FD9049ECAC@wopr.sciops.net>

qwx@sciops.net once said:
> Here's the final patch, mostly the same.  I'll commit this later
> unless there are any objections.

There's only two callers of resetscreenimage, two callers of
vgascreenwin, and four callers of deletescreenimage.

I would adjust the call sites to include them within the locked
sections, remove the locking inside them and get rid of the
repetitive underscore functions.

As an aside, all the wet floors involving locks in the vga code
could use some mopping up. Best keep the mold away.


  parent reply	other threads:[~2022-08-16 23:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-08-16  6:12 qwx
2022-08-16 20:44 ` qwx
2022-08-16 20:51   ` Jacob Moody
2022-08-16 23:02   ` Anthony Martin [this message]
2022-08-17 12:10     ` qwx
2022-08-17 12:17       ` ori
2022-08-17 20:21         ` qwx
2022-08-18  2:23           ` ori
2022-08-18  5:36             ` qwx

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=Yvwh8PE+laVJ4v0s@alice \
    --to=ality@pbrane.org \
    --cc=9front@9front.org \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).