From mboxrd@z Thu Jan 1 00:00:00 1970 X-Spam-Checker-Version: SpamAssassin 3.4.4 (2020-01-24) on inbox.vuxu.org X-Spam-Level: * X-Spam-Status: No, score=1.2 required=5.0 tests=RCVD_IN_BL_SPAMCOP_NET, T_SCC_BODY_TEXT_LINE autolearn=no autolearn_force=no version=3.4.4 Received: (qmail 21031 invoked from network); 16 Aug 2022 23:03:59 -0000 Received: from 9front.inri.net (168.235.81.73) by inbox.vuxu.org with ESMTPUTF8; 16 Aug 2022 23:03:59 -0000 Received: from MTA-07-4.privateemail.com ([68.65.122.27]) by 9front; Tue Aug 16 19:02:28 -0400 2022 Received: from mta-07.privateemail.com (localhost [127.0.0.1]) by mta-07.privateemail.com (Postfix) with ESMTP id F111C18000B1 for <9front@9front.org>; Tue, 16 Aug 2022 19:02:19 -0400 (EDT) Received: from localhost (tor-exit-34.for-privacy.net [185.220.101.34]) by mta-07.privateemail.com (Postfix) with ESMTPA id 42B6518000A3 for <9front@9front.org>; Tue, 16 Aug 2022 19:02:19 -0400 (EDT) Date: Tue, 16 Aug 2022 16:02:08 -0700 From: Anthony Martin To: 9front@9front.org Message-ID: References: <559C4D36E88CDC22C329548E7BBFDF3F@wopr.sciops.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Virus-Scanned: ClamAV using ClamSMTP List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: structured hypervisor blockchain service Subject: Re: [9front] fix race condition on writes to #v/vgactl Reply-To: 9front@9front.org Precedence: bulk qwx@sciops.net once said: > Here's the final patch, mostly the same. I'll commit this later > unless there are any objections. There's only two callers of resetscreenimage, two callers of vgascreenwin, and four callers of deletescreenimage. I would adjust the call sites to include them within the locked sections, remove the locking inside them and get rid of the repetitive underscore functions. As an aside, all the wet floors involving locks in the vga code could use some mopping up. Best keep the mold away. Cheers, Anthony