9front - general discussion about 9front
 help / color / mirror / Atom feed
From: jamos@oboj.net
To: 9front@9front.org
Subject: Suggested patch to libjpeg in ports (jconfig.h)
Date: Mon, 10 Feb 2020 21:57:32 +0200	[thread overview]
Message-ID: <aa8fce2dea32eb9fe1f4a2b42b889b22@oboj.net> (raw)

[-- Attachment #1: Type: text/plain, Size: 710 bytes --]

Dear list,

Netsurf is able to view JPEG if linked
against libjpeg in /sys/ports. However,
it includes the file <jconfig.h> that
is present in the ports 'files' directory,
but which for some reason is not installed
by default by ape-libs/libjpeg/files/mkfile.
Copying the file manually to /sys/include/ape
makes netsurf happy, and being able to show
jpeg images.

Am I right by copying the file? It seem that
maybe it would be a too obvious thing to leave
out, unless using jconfig.h is a special case
(I have not dug very deeply in libjpeg to be
honest).

I've attached a patch (generated with "hg diff")
in case this would be the right thing to do.
If not, it would be interesting to know more.

Best,
Jonas

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libjpeg.diff --]
[-- Type: text/x-diff; name=libjpeg.diff, Size: 407 bytes --]

diff -r 5b0a83ca7639 ape-libs/libjpeg/files/mkfile
--- a/ape-libs/libjpeg/files/mkfile	Sun Dec 08 12:26:27 2019 -0800
+++ b/ape-libs/libjpeg/files/mkfile	Mon Feb 10 18:39:43 2020 +0100
@@ -106,6 +106,7 @@
 	cp jerror.h /sys/include/ape/
 	cp jmorecfg.h /sys/include/ape/
 	cp jpeglib.h /sys/include/ape/
+	cp jconfig.h /sys/include/ape/
 	mk -f mkfile.djpeg install
 	mk clean
 #	mk -f mkfile.cjpeg install

             reply	other threads:[~2020-02-10 19:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-02-10 19:57 jamos [this message]
2020-02-10 20:03 ` [9front] " ori

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aa8fce2dea32eb9fe1f4a2b42b889b22@oboj.net \
    --to=jamos@oboj.net \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).