* Suggested patch to libjpeg in ports (jconfig.h)
@ 2020-02-10 19:57 jamos
2020-02-10 20:03 ` [9front] " ori
0 siblings, 1 reply; 2+ messages in thread
From: jamos @ 2020-02-10 19:57 UTC (permalink / raw)
To: 9front
[-- Attachment #1: Type: text/plain, Size: 710 bytes --]
Dear list,
Netsurf is able to view JPEG if linked
against libjpeg in /sys/ports. However,
it includes the file <jconfig.h> that
is present in the ports 'files' directory,
but which for some reason is not installed
by default by ape-libs/libjpeg/files/mkfile.
Copying the file manually to /sys/include/ape
makes netsurf happy, and being able to show
jpeg images.
Am I right by copying the file? It seem that
maybe it would be a too obvious thing to leave
out, unless using jconfig.h is a special case
(I have not dug very deeply in libjpeg to be
honest).
I've attached a patch (generated with "hg diff")
in case this would be the right thing to do.
If not, it would be interesting to know more.
Best,
Jonas
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: libjpeg.diff --]
[-- Type: text/x-diff; name=libjpeg.diff, Size: 407 bytes --]
diff -r 5b0a83ca7639 ape-libs/libjpeg/files/mkfile
--- a/ape-libs/libjpeg/files/mkfile Sun Dec 08 12:26:27 2019 -0800
+++ b/ape-libs/libjpeg/files/mkfile Mon Feb 10 18:39:43 2020 +0100
@@ -106,6 +106,7 @@
cp jerror.h /sys/include/ape/
cp jmorecfg.h /sys/include/ape/
cp jpeglib.h /sys/include/ape/
+ cp jconfig.h /sys/include/ape/
mk -f mkfile.djpeg install
mk clean
# mk -f mkfile.cjpeg install
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [9front] Suggested patch to libjpeg in ports (jconfig.h)
2020-02-10 19:57 Suggested patch to libjpeg in ports (jconfig.h) jamos
@ 2020-02-10 20:03 ` ori
0 siblings, 0 replies; 2+ messages in thread
From: ori @ 2020-02-10 20:03 UTC (permalink / raw)
To: jamos, 9front
> Dear list,
>
> Netsurf is able to view JPEG if linked
> against libjpeg in /sys/ports. However,
> it includes the file <jconfig.h> that
> is present in the ports 'files' directory,
> but which for some reason is not installed
> by default by ape-libs/libjpeg/files/mkfile.
> Copying the file manually to /sys/include/ape
> makes netsurf happy, and being able to show
> jpeg images.
>
> Am I right by copying the file? It seem that
> maybe it would be a too obvious thing to leave
> out, unless using jconfig.h is a special case
> (I have not dug very deeply in libjpeg to be
> honest).
>
> I've attached a patch (generated with "hg diff")
> in case this would be the right thing to do.
> If not, it would be interesting to know more.
>
> Best,
> Jonas
Looks sane to me; committing.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-02-10 20:03 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-10 19:57 Suggested patch to libjpeg in ports (jconfig.h) jamos
2020-02-10 20:03 ` [9front] " ori
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).