Re: [9front] [PATCH] Fix shift release events in X11 drawterm with shift:both_capslock xmodmap option

[Jacob Moody <moody@posixcafe.org>]

On 6/29/24 06:16, Timothy Robert Bednarzyk wrote:
>> Seems reasonable to me. Thanks for debugging this.
>> My only suggestion would be to axe the "Not having this causes the mouse ...".
>> What it causes is the shift key to be held down, which then causes the mouse button swapping.
>> Drawterm itself isn't doing that bit, it's rio.
> 
> While it is true that it technically isn't drawterm itself causing that
> to happen, it also isn't _just_ rio---holding the shift key after
> starting acme directly (instead of starting rio and then running acme
> inside a rio window) still swaps the mouse buttons. Given that I wasn't
> also experiencing a problem where everything I typed was capitalized as
> if it thought that I was just constantly holding down the shift key, I
> was only trying to provide context to what can actually be observed
> without specially handling "caps lock" key releases. That being said,
> I'm perfectly fine with either rephrasing or entirely axing that.
> 

Sure rio is a standin for whatever "main" graphical application you're running.
I just want to avoid oversharing in the comment to raise more questions then
it answers. I thought that the later portions of the comment can be safely
extrapolated from the cause of the bug as is described, so I feel it's filler.

This is your work though not mine so I won't die no this hill over some comment
bikeshedding. Let me know what you would like.


Thanks,
moody