9front - general discussion about 9front
 help / color / mirror / Atom feed
From: Jacob Moody <moody@mail.posixcafe.org>
To: 9front@9front.org
Subject: Re: [9front] vnc: fix farsi key symbols
Date: Tue, 16 May 2023 20:08:59 -0600	[thread overview]
Message-ID: <c3fdd98a-64ac-d16b-f7a3-b8cddea0bdf4@posixcafe.org> (raw)
In-Reply-To: <C3A0EBC8A1043CC66E7E63F426B89FD3@smtp.pobox.com>

On 5/16/23 18:43, unobe@cpan.org wrote:
> Could someone explain the commit today for fixing farsi key symbols a
> bit more?  Is this for vncs or vncv?  I assume vncv is more useful
> nowadays due to drawterm, but perhaps not.
> 
>  From https://cgit.freedesktop.org/xorg/proto/x11proto/tree/keysymdef.h
> , lines 60-81 describe the state of affairs (presumably from the last
> copyright year at the top of the file, 1998).  If we want to remain
> compatible with connecting to older server implementations, then would
> it be better to do similar to what is done around line 91 from
> https://github.com/AdoptOpenJDK/openjdk-jdk11/blob/master/src/java.desktop/unix/classes/sun/awt/X11/XKeysym.java
> ? That is, revert the changes to /sys/src/cmd/vnc/utf2ksym.h and
> handle the discrepancy more generally in /sys/src/cmd/vnc/kbdv.c ? Or
> do we just not care?
> 
> 

I was told these were pulled from the openbsd keysymdef.h.
I dont currently have an openbsd around but I believe this is the file, and these lines specifically:

https://github.com/openbsd/xenocara/blob/d1a8d3ab034044bab40925e51534100a444dd3d6/proto/xorgproto/include/X11/keysymdef.h#L1011-L1100

It seems that they have elected to make the "new" unicode mapping the default, alongside the existing older keysyms in a similar way this
patch does. Likewise the X11/keysym.h on my local loonix system has the same mapping. I agree that on paper the use of the new mappings
for these codepoints specifically is a bit weird, but it seems to be consistently weird with "upstream".

thanks,
moody


  reply	other threads:[~2023-05-17  2:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-17  0:43 unobe
2023-05-17  2:08 ` Jacob Moody [this message]
2023-05-17  2:38   ` unobe
2023-05-17  4:31     ` Jacob Moody
2023-05-17 19:37       ` unobe
2023-05-17 14:35     ` ori
2023-05-17 19:38       ` unobe
2023-05-17 20:15         ` ori
2023-05-17 20:40           ` unobe
2023-05-18 10:27             ` ori
2023-05-19  3:32               ` unobe
2023-05-24 13:34 ` mkf9

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c3fdd98a-64ac-d16b-f7a3-b8cddea0bdf4@posixcafe.org \
    --to=moody@mail.posixcafe.org \
    --cc=9front@9front.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).