Re: [9front] Bug or inconsistency in cursor behaviour?

["Scott Flowers" <flowerss@cranky.ca>]

Please ignore the first set of patches, I arsed up the one for rio.

Scott Flowers
flowerss@cranky.ca

On Mon, 28 Oct 2024, at 16:49, Scott Flowers wrote:
> If interested, patch for acme, patch for rio below. Apologies for my non-c-programmerness.
> 
> diff 6894c4e13a24e9983e2daf4ee2566f8396d29f4e uncommitted
> --- a/sys/src/cmd/acme/text.c
> +++ b/sys/src/cmd/acme/text.c
> @@ -680,13 +680,24 @@
> switch(r){
> case Kleft:
> typecommit(t);
> - if(t->q0 > 0)
> - textshow(t, t->q0-1, t->q0-1, TRUE);
> + if(t->q0 > 0) {
> + if(t->q0 != t->q1) {
> + textshow(t, t->q0, t->q0, TRUE);
> + }
> + else {
> + textshow(t, t->q0-1, t->q0-1, TRUE);
> + }
> + }
> return;
> case Kright:
> typecommit(t);
> if(t->q1 < t->file->nc)
> - textshow(t, t->q1+1, t->q1+1, TRUE);
> + if(t->q0 != t->q1) {
> + textshow(t, t->q1, t->q1, TRUE);
> + }
> + else {
> + textshow(t, t->q1+1, t->q1+1, TRUE);
> + }
> return;
> case Kdown:
> n = t->maxlines/3;
> 
> diff 6894c4e13a24e9983e2daf4ee2566f8396d29f4e uncommitted
> --- a/sys/src/cmd/rio/wind.c
> +++ b/sys/src/cmd/rio/wind.c
> @@ -892,16 +892,30 @@
> return;
> case Kleft:
> if(w->q0 > 0){
> - q0 = w->q0-1;
> - wsetselect(w, q0, q0);
> - wshow(w, q0);
> + if(w->q1 != w->q0) {
> + q0 = w->q0;
> + wsetselect(w, q0, q0);
> + wshow(w, q0);
> + }
> + else {
> + q0 = w->q0-1;
> + wsetselect(w, q0, q0);
> + wshow(w, q0);
> + }
> }
> return;
> case Kright:
> if(w->q1 < w->nr){
> - q1 = w->q1+1;
> - wsetselect(w, q1, q1);
> - wshow(w, q1);
> + if(w->q1 != w->q0) {
> + q1 = w->q1;
> + wsetselect(w, q1, q1);
> + wshow(w, q1);
> + } 
> + else {
> + q1 = w->q1+1;
> + wsetselect(w, q1, q1);
> + wshow(w, q1);
> + }
> }
> return;
> case Khome:
> 
> 
> 
> Scott
> 
> On Mon, 28 Oct 2024, at 14:19, flowerss@cranky.ca wrote:
> > I have noticed an odd behaviour when using the arrow keys when text is selected in 9front, and I'm wondering if it's a bug, multiple bugs, or just the way things work.
> > 
> > If I have a string of text in a shell or acme, and I select one or more characters with the mouse, and then use the right arrow key, the text gets deselected, and the cursor moves one character past the right end of the selected text. If I use the left arrow key, the cursor moves to one character to the left of the previously selected text. It feels like the resultin position of the cursor has gone one character too far left or right.
> > 
> > In sam, this behaviour is different. If I select text in sam, and then hit the left arrow key, the cursor moves one character to the left of the initially selected text, and if I hit the right arrow key, the cursor moves to the right of the first character of the previously selected text. This also seems odd.
> > 
> > In Windows, MacOS and all the Linux graphical text manipulation apps I have tried, if you select text and then hit the left arrow, the cursor moves to the beginning of the selection, and the right arrow moves to the end of the selection. This feels like the more appropriate behaviour to me. Am I out to lunch?
> > 
> > Thanks,
> > 
> > Scott
> > 
>