Re: [9front] Bug or inconsistency in cursor behaviour?

["Scott Flowers" <flowerss@cranky.ca>]

Actually, ignore that recommendation to ignore that patch. I panicked. I chalk it up to first-patch-submission jitters. Below will make acme and rio left and right arrow keys move the cursor to the beginning and end of selected text respectively, instead of one extra character left or right.

diff 6894c4e13a24e9983e2daf4ee2566f8396d29f4e uncommitted
--- a/sys/src/cmd/rio/wind.c
+++ b/sys/src/cmd/rio/wind.c
@@ -892,16 +892,30 @@
 			return;
 		case Kleft:
 			if(w->q0 > 0){
-				q0 = w->q0-1;
-				wsetselect(w, q0, q0);
-				wshow(w, q0);
+				if(w->q1 != w->q0) {
+					q0 = w->q0;
+					wsetselect(w, q0, q0);
+					wshow(w, q0);
+				}
+				else {
+					q0 = w->q0-1;
+					wsetselect(w, q0, q0);
+					wshow(w, q0);
+				}
 			}
 			return;
 		case Kright:
 			if(w->q1 < w->nr){
-				q1 = w->q1+1;
-				wsetselect(w, q1, q1);
-				wshow(w, q1);
+				if(w->q1 != w->q0) {
+					q1 = w->q1;
+					wsetselect(w, q1, q1);
+					wshow(w, q1);
+				} 
+				else {
+					q1 = w->q1+1;
+					wsetselect(w, q1, q1);
+					wshow(w, q1);
+				}
 			}
 			return;
 		case Khome:

diff 6894c4e13a24e9983e2daf4ee2566f8396d29f4e uncommitted
--- a/sys/src/cmd/acme/text.c
+++ b/sys/src/cmd/acme/text.c
@@ -680,13 +680,24 @@
 	switch(r){
 	case Kleft:
 		typecommit(t);
-		if(t->q0 > 0)
-			textshow(t, t->q0-1, t->q0-1, TRUE);
+		if(t->q0 > 0) {
+			if(t->q0 != t->q1) {
+				textshow(t, t->q0, t->q0, TRUE);
+			}
+			else {
+				textshow(t, t->q0-1, t->q0-1, TRUE);
+			}
+		}
 		return;
 	case Kright:
 		typecommit(t);
 		if(t->q1 < t->file->nc)
-			textshow(t, t->q1+1, t->q1+1, TRUE);
+			if(t->q0 != t->q1) {
+				textshow(t, t->q1, t->q1, TRUE);
+			}
+			else {
+				textshow(t, t->q1+1, t->q1+1, TRUE);
+			}
 		return;
 	case Kdown:
 		n = t->maxlines/3;

Thanks,

Scott