* [9front] [patch] ethervgbe.c adjust blocksize for etheriq
@ 2022-11-05 17:57 Arne Meyer
2022-11-05 20:18 ` Jacob Moody
0 siblings, 1 reply; 2+ messages in thread
From: Arne Meyer @ 2022-11-05 17:57 UTC (permalink / raw)
To: 9front
[-- Attachment #1: Type: text/plain, Size: 231 bytes --]
Hello,
ethervgbe appends the ethernet CRC to the block that is send up the stack. This not a problem for ip packets
but breaks aoe sanity checks. We don't use it anyway and FreeBSD and OpenBSD don't use it either.
Greetings,
Arne
[-- Attachment #2: ethervgbe.c.patch --]
[-- Type: application/octet-stream, Size: 356 bytes --]
diff e938acc8ff64a3cbbd6ef7ba88f83e3f03ede681 uncommitted
--- a/sys/src/9/pc/ethervgbe.c
+++ b/sys/src/9/pc/ethervgbe.c
@@ -592,7 +592,7 @@
/* plant new block, might fail if out of memory */
if(vgbenewrx(ctlr, i) == 0){
- block->wp = block->rp + length;
+ block->wp = block->rp + length - 4;
etheriq(edev, block);
continue;
}
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [9front] [patch] ethervgbe.c adjust blocksize for etheriq
2022-11-05 17:57 [9front] [patch] ethervgbe.c adjust blocksize for etheriq Arne Meyer
@ 2022-11-05 20:18 ` Jacob Moody
0 siblings, 0 replies; 2+ messages in thread
From: Jacob Moody @ 2022-11-05 20:18 UTC (permalink / raw)
To: 9front
On 11/5/22 11:57, Arne Meyer wrote:
> Hello,
>
> ethervgbe appends the ethernet CRC to the block that is send up the stack. This not a problem for ip packets
> but breaks aoe sanity checks. We don't use it anyway and FreeBSD and OpenBSD don't use it either.
>
> Greetings,
> Arne
Thanks! I realize now I also forgot to reply to your ipv6 patch mail, so thank you for that as well!
Cheers,
moody
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-05 20:21 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-05 17:57 [9front] [patch] ethervgbe.c adjust blocksize for etheriq Arne Meyer
2022-11-05 20:18 ` Jacob Moody
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).