From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from duke.felloff.net ([216.126.196.34]) by ur; Tue Feb 16 02:29:10 EST 2016 Message-ID: Date: Tue, 16 Feb 2016 08:29:02 +0100 From: cinap_lenrek@felloff.net To: 9front@9front.org Subject: Re: [9front] usbuhci.c bug? In-Reply-To: MIME-Version: 1.0 Content-Type: text/plain; charset="US-ASCII" Content-Transfer-Encoding: 7bit List-ID: <9front.9front.org> List-Help: X-Glyph: ➈ X-Bullshit: full-stack markup hardware browser API no, the old code was wrong. the == operator has higher precedence than &, so it would do if(cmd & (Crun == 0)), which becomes if(cmd & 0), which becomes if(0) which is not what is intended. the intention is to check if the Run bit is clear, and print a warning in that case. does the usb controller work at all? -- cinap