caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: "Jon Harrop" <jon@ffconsultancy.com>
To: "'Andrew'" <newsgroups.fr@gmail.com>, <caml-list@inria.fr>
Subject: RE: [Caml-list] Comparing variant types
Date: Fri, 29 Apr 2011 13:15:38 +0100	[thread overview]
Message-ID: <004d01cc0667$277503c0$765f0b40$@ffconsultancy.com> (raw)
In-Reply-To: <4DBA98D8.5020605@gmail.com>

Andrew wrote:
> Why not write directly
> 	let dir_equal = fun d1 d2 ->
> 	  | Left Left
> 	  | Right Right
> 	  | Up Up
> 	  | Down Down
> 	  | No_op No_op ->  true
> 	  | _ -> false

You want to fill out your _ pattern with explicit type constructors
otherwise it is fragile wrt new constructors being added to the type.

Cheers,
Jon.



  parent reply	other threads:[~2011-04-29 12:16 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-04-28 19:16 Ethan Burns
2011-04-28 21:07 ` Vincent Aravantinos
2011-04-28 22:56   ` Ethan Burns
     [not found]   ` <354087020.772283.1304031467793.JavaMail.root@zmbs4.inria.fr>
2011-04-29  8:46     ` Fabrice Le Fessant
2011-04-29  8:57 ` Dmitry Bely
     [not found] ` <164004794.892685.1304067487325.JavaMail.root@zmbs2.inria.fr>
2011-04-29  9:33   ` luc.maranget
2011-04-29 10:54     ` Andrew
2011-04-29 11:17       ` Dmitry Bely
2011-04-29 12:15       ` Jon Harrop [this message]
2011-04-30 16:38         ` Andrew
2011-04-29 11:32     ` Dmitry Bely
2011-04-30 13:43     ` craff73
2011-04-30 19:26       ` Andrew
2011-04-30 20:19       ` Gabriel Scherer
2011-04-30 20:57         ` Yaron Minsky
     [not found] <fa.FGXk5PCsQgS8TidmFkgljpqbLZo@ifi.uio.no>
2011-04-29 11:54 ` Ethan Burns

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='004d01cc0667$277503c0$765f0b40$@ffconsultancy.com' \
    --to=jon@ffconsultancy.com \
    --cc=caml-list@inria.fr \
    --cc=newsgroups.fr@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).