From: Anil Madhavapeddy <anil@recoil.org>
To: Helmut Brandl <helmut.brandl@gmx.net>
Cc: caml users <caml-list@inria.fr>
Subject: Re: [Caml-list] Policy to merge pull requests in the opam repository
Date: Tue, 16 May 2017 23:57:26 +0800 [thread overview]
Message-ID: <05B4D6E0-D18C-4B78-91AA-D1A92A30257C@recoil.org> (raw)
In-Reply-To: <AF27C6EE-DC8A-422F-85A7-EE70155611DC@gmx.net>
On 16 May 2017, at 23:38, Helmut Brandl <helmut.brandl@gmx.net> wrote:
>
> I have managed to prepare a new version of the Albatross verifier and want to release the new version in the opam repository.
>
> I have done all preparations, i.e. written the needed files opam,descr and url, pinned the version locally, forked the opam repository and created a pull request. My pull request has passed all tests which are triggered by the github workflow automatically.
>
> What is the policy to get my pull request merged. Do I just have to wait for feedback or are some other actions needed by me to trigger the merge. It is my understanding that the merge can only be done by people who have write access to the opam repository. How is the frequency?
Deari Helmut,
Thanks for being so diligent with your testing before submitting a pull request to opam-repository. The PRs are reviewed by the various maintainers to opam-repository, and generally merged within a day or two if there are no problems with the CI tests. The tests include:
- opam lint
- tests to check that constraints do not result in some other packages becoming uninstallable
- build tests against a matrix of various Linux distributions and OCaml compiler versions
If a build fails against a particular OCaml compiler version, we will request that a constraint be added to the `opam` file to reflect the build failure. Such fixes can be done just by pushing additional changes to the same branch, in the usual GitHub workflow.
Sporadic failures do occur on some distributions (like Fedora or OpenSUSE) due issues to issues with the upstream repository servers, so do not be alarmed if you get an 'x' beside your test -- it can still be merged if a few distributions fail.
> I don’t want to urge anything. I just want to understand the policy.
Not at all; we should write this all down in a `CONTRIBUTING.md` file in the opam-repository. I'm currently travelling but can do that when back, unless one of the other maintainers beats me to it.
And thanks for taking the time to contribute your packages to the repository!
regards,
Anil
prev parent reply other threads:[~2017-05-16 15:57 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-16 15:38 Helmut Brandl
2017-05-16 15:52 ` [Caml-list] Fwd: " Helmut Brandl
2017-05-16 15:55 ` Romain Calascibetta
2017-05-16 16:00 ` [Caml-list] " Helmut Brandl
2017-05-16 16:03 ` Anil Madhavapeddy
2017-05-16 16:11 ` Helmut Brandl
2017-05-16 15:57 ` Anil Madhavapeddy [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=05B4D6E0-D18C-4B78-91AA-D1A92A30257C@recoil.org \
--to=anil@recoil.org \
--cc=caml-list@inria.fr \
--cc=helmut.brandl@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).