From: Gerd Stolpmann <info@gerd-stolpmann.de>
To: Tom <tom.primozic@gmail.com>
Cc: Chris King <colanderman@gmail.com>,
caml-list@yquem.inria.fr, Jacques Carette <carette@mcmaster.ca>
Subject: Re: [Caml-list] Equality of functional values
Date: Tue, 30 Jan 2007 21:30:01 +0100 [thread overview]
Message-ID: <1170189001.21265.9.camel@localhost.localdomain> (raw)
In-Reply-To: <c1490a380701301218y1a92ec8ei5b4efbc714664b03@mail.gmail.com>
Am Dienstag, den 30.01.2007, 21:18 +0100 schrieb Tom:
> I guess the "correct" way to do = equality would be to check for tag
> (Obj.tag (Obj.repr x)), and if it isn't float (or float array) then ==
> equality would be performed first. The problem is that this would have
> to be implemented by the OCaml developers, as the naive
> implementation:
>
> let equal x y =
> if Obj.tag (Obj.repr x) = Obj.double_tag then x = y
> else
> if x == y then true else x = y
>
> doesn't work,
But
let equal x y =
Pervasives.compare x y = 0
works!
> as it should be called recursively (comparing two lists of functions
> will fail, because the functions would be compared by =, not by
> equal).
>
> Actually, the implementation could be improved further, as it could
> actually return true on examples such as
>
> # let f x y = x + y;;
> val f : int -> int -> int = <fun>
> # f == f;;
> - : bool = true
> # (f 1) = (f 1);;
> - : bool = true
>
> because the parameters, passed to a closure, could be compared, too...
>
> Anyhow, this can be added to the wishlist :)
I can fully understand that ( = ) fails on functional values. The
additional test for floats would take a lot of time, given that equality
is the most frequent test.
A better improvement would be that the compiler emits a warning when
there is the possibility that the equality test compares functional
values. In my opinion this is a serious programming error, and the
compiler should help to track it down.
Gerd
--
------------------------------------------------------------
Gerd Stolpmann * Viktoriastr. 45 * 64293 Darmstadt * Germany
gerd@gerd-stolpmann.de http://www.gerd-stolpmann.de
Phone: +49-6151-153855 Fax: +49-6151-997714
------------------------------------------------------------
next prev parent reply other threads:[~2007-01-30 20:30 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-29 21:04 Simon Frost
2007-01-29 21:11 ` [Caml-list] " Tom
2007-01-29 21:23 ` Brian Hurt
2007-01-29 21:59 ` Gerd Stolpmann
2007-01-30 8:17 ` Christophe Raffalli
2007-01-30 8:45 ` David MENTRE
2007-01-30 13:24 ` Andrej Bauer
2007-01-30 13:55 ` skaller
2007-01-30 14:21 ` Brian Hurt
2007-01-30 15:21 ` Jeff Polakow
2007-01-30 15:49 ` Jacques Carette
2007-01-30 17:23 ` Chris King
2007-01-30 20:18 ` Tom
2007-01-30 20:30 ` Gerd Stolpmann [this message]
2007-01-30 20:41 ` Fernando Alegre
2007-01-30 21:01 ` Christophe TROESTLER
2007-01-30 21:08 ` Tom
2007-01-30 21:46 ` Christophe TROESTLER
2007-01-30 22:05 ` Fernando Alegre
2007-01-30 23:13 ` skaller
2007-01-30 23:06 ` Andrej Bauer
2007-01-31 0:15 ` Jacques Carette
2007-01-31 7:03 ` Stefan Monnier
2007-01-31 12:54 ` [Caml-list] " Jacques Carette
2007-01-31 0:15 ` [Caml-list] " skaller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1170189001.21265.9.camel@localhost.localdomain \
--to=info@gerd-stolpmann.de \
--cc=caml-list@yquem.inria.fr \
--cc=carette@mcmaster.ca \
--cc=colanderman@gmail.com \
--cc=tom.primozic@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).