From mboxrd@z Thu Jan  1 00:00:00 1970
Received: (from majordomo@localhost) by pauillac.inria.fr (8.7.6/8.7.3) id FAA20970; Thu, 24 Oct 2002 05:33:12 +0200 (MET DST)
X-Authentication-Warning: pauillac.inria.fr: majordomo set sender to owner-caml-list@pauillac.inria.fr using -f
Received: from nez-perce.inria.fr (nez-perce.inria.fr [192.93.2.78]) by pauillac.inria.fr (8.7.6/8.7.3) with ESMTP id FAA20077 for <caml-list@pauillac.inria.fr>; Thu, 24 Oct 2002 05:33:11 +0200 (MET DST)
Received: from kurims.kurims.kyoto-u.ac.jp (kurims.kurims.kyoto-u.ac.jp [130.54.16.1])
	by nez-perce.inria.fr (8.11.1/8.11.1) with ESMTP id g9O3X9D29372
	for <caml-list@inria.fr>; Thu, 24 Oct 2002 05:33:10 +0200 (MET DST)
Received: from localhost (suiren.kurims.kyoto-u.ac.jp [130.54.16.25])
	by kurims.kurims.kyoto-u.ac.jp (8.9.3/3.7W) with ESMTP id MAA23285;
	Thu, 24 Oct 2002 12:33:01 +0900 (JST)
To: hallvard.ystad@helpinhand.com, caml-list@inria.fr
Subject: Re: [Caml-list] building OCaml under MinGW
In-Reply-To: <20021013115502.O13771@pauillac.inria.fr>
References: <3DA6CB56.3070309@univ-savoie.fr>
	<5.1.1.6.2.20021012140050.029c2590@helpinhand.com>
	<20021013115502.O13771@pauillac.inria.fr>
X-Mailer: Mew version 1.94.2 on Emacs 21.2 / Mule 5.0 (SAKAKI)
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Message-Id: <20021024123301Z.garrigue@kurims.kyoto-u.ac.jp>
Date: Thu, 24 Oct 2002 12:33:01 +0900
From: Jacques Garrigue <garrigue@kurims.kyoto-u.ac.jp>
X-Dispatcher: imput version 20000228(IM140)
Sender: owner-caml-list@pauillac.inria.fr
Precedence: bulk

From: Xavier Leroy <xavier.leroy@inria.fr>
> > Interesting. I uninstalled my mingw installation and installed
> > cygwin (containing mingw) instead.  This time, my installation went
> > much further before messing up. But in the end, I still got errors,
> > and the installation failed. Here's where it fails:
> > cltkImg.c: In function `camltk_setimgdata_native':
> > cltkImg.c:102: too few arguments to function `Tk_PhotoPutBlock'
> 
> Are you sure you have the recommended version of Tcl/TK?  (8.3)

Indeed, this error is caused by Tcl/Tk 8.4.

Here is an easy patch (useful also for users of recent Linux
distributions)

Jacques Garrigue

Index: otherlibs/labltk/support/cltkImg.c
===================================================================
RCS file: /net/pauillac/caml/repository/csl/otherlibs/labltk/support/cltkImg.c,v
retrieving revision 1.3
diff -c -r1.3 cltkImg.c
*** cltkImg.c	2002/07/23 14:11:59	1.3
--- cltkImg.c	2002/10/24 03:19:38
***************
*** 99,105 ****
    pib.offset[0] = 0;
    pib.offset[1] = 1;
    pib.offset[2] = 2;
!   Tk_PhotoPutBlock(ph,&pib,Int_val(x),Int_val(y),Int_val(w),Int_val(h)); 
  }
  
  CAMLprim void camltk_setimgdata_bytecode(argv,argn)
--- 99,109 ----
    pib.offset[0] = 0;
    pib.offset[1] = 1;
    pib.offset[2] = 2;
!   Tk_PhotoPutBlock(ph,&pib,Int_val(x),Int_val(y),Int_val(w),Int_val(h)
! #if (TK_MAJOR_VERSION == 8 && TK_MINOR_VERSION >= 4 || TK_MAJOR_VERSION > 8)
!                    , TK_PHOTO_COMPOSITE_SET
! #endif
!     ); 
  }
  
  CAMLprim void camltk_setimgdata_bytecode(argv,argn)
Index: otherlibs/labltk/tkanim/tkAnimGIF.c
===================================================================
RCS file: /net/pauillac/caml/repository/csl/otherlibs/labltk/tkanim/tkAnimGIF.c,v
retrieving revision 1.4
diff -c -r1.4 tkAnimGIF.c
*** tkAnimGIF.c	2002/07/23 14:12:00	1.4
--- tkAnimGIF.c	2002/10/24 03:19:38
***************
*** 335,342 ****
                  goto error;
              }
          }
!         Tk_PhotoPutBlock(photoHandle, &block, 0, 0, 
!                          imageWidth, imageHeight);
  #ifdef TKANIM_DEBUG
      fprintf(stderr, " Retrieving result\n");
  #endif
--- 335,345 ----
                  goto error;
              }
          }
!         Tk_PhotoPutBlock(photoHandle, &block, 0, 0, imageWidth, imageHeight
! #if (TK_MAJOR_VERSION == 8 && TK_MINOR_VERSION >= 4 || TK_MAJOR_VERSION > 8)
!                    , TK_PHOTO_COMPOSITE_SET
! #endif
!           );
  #ifdef TKANIM_DEBUG
      fprintf(stderr, " Retrieving result\n");
  #endif
-------------------
To unsubscribe, mail caml-list-request@inria.fr Archives: http://caml.inria.fr
Bug reports: http://caml.inria.fr/bin/caml-bugs FAQ: http://caml.inria.fr/FAQ/
Beginner's list: http://groups.yahoo.com/group/ocaml_beginners