caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: Oleg Trott <oleg_trott@columbia.edu>
To: "TBraibant" <tbraibant@wanadoo.fr>, <caml-list@inria.fr>
Subject: Re: [Caml-list] Function composition in CAML
Date: Sun, 8 Jun 2003 09:11:18 -0400	[thread overview]
Message-ID: <200306080911.19208.oleg_trott@columbia.edu> (raw)
In-Reply-To: <000a01c32db1$041915c0$0100a8c0@r2d2>

On Sunday 08 June 2003 07:27 am, TBraibant wrote:
> Hello
>
> I have made some experimentations, but I can't find where is a bug in a
> simple piece of code
>
> I represent a polynome by a list of its coefficents
> (I know that there is a more efficient way to do this calculation (P(x) in
> fact), but it is just an expermimentation)
>
> let horner p x =
>   let v= Array.of_list p in
>   let n = Array.length v in
>   let r = ref n in
>   let f = ref (function u ->u  ) in
>     while !r <> 0 do
>       f := (function u -> !f( v.(!r)+ x*u));
>       r := !r -1 ;
>     done;
>     !f(0)
> ;;
>
> In theory, the !f(0) call shall give me P(x)...
> But it seems that the computer crash, and can't handle this line of code...
>
> Someone has an idea?
>
> Thank you

The computer does not crash, you are merely entrering an infinite loop 
because, with function composition, you couldn't keep track of the mutable 
variables in your code. A possible solution is:

let eval p x = 
  let rec aux p prod sum =
    match p with
    | [] -> sum
    | a :: b -> aux b (x*prod) (a*prod + sum)
  in aux p 1 0
;;

"eval" does not implement Horner's rule. The latter sounds like homework :)

-- 
Oleg Trott <oleg_trott@columbia.edu>

-------------------
To unsubscribe, mail caml-list-request@inria.fr Archives: http://caml.inria.fr
Bug reports: http://caml.inria.fr/bin/caml-bugs FAQ: http://caml.inria.fr/FAQ/
Beginner's list: http://groups.yahoo.com/group/ocaml_beginners


  reply	other threads:[~2003-06-08 13:11 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2003-06-08 11:27 TBraibant
2003-06-08 13:11 ` Oleg Trott [this message]
2003-06-10  8:49 ` Frederic van der Plancke

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200306080911.19208.oleg_trott@columbia.edu \
    --to=oleg_trott@columbia.edu \
    --cc=caml-list@inria.fr \
    --cc=tbraibant@wanadoo.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).