From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on yquem.inria.fr X-Spam-Level: * X-Spam-Status: No, score=1.9 required=5.0 tests=AWL,DNS_FROM_RFC_ABUSE, NO_REAL_NAME,SPF_NEUTRAL autolearn=disabled version=3.1.3 X-Original-To: caml-list@yquem.inria.fr Delivered-To: caml-list@yquem.inria.fr Received: from discorde.inria.fr (discorde.inria.fr [192.93.2.38]) by yquem.inria.fr (Postfix) with ESMTP id 920D9BC50 for ; Wed, 4 Oct 2006 11:30:17 +0200 (CEST) Received: from malaquias.no-ip.org ([200.131.216.204]) by discorde.inria.fr (8.13.6/8.13.6) with ESMTP id k949UG3V018527 for ; Wed, 4 Oct 2006 11:30:16 +0200 Received: by malaquias.no-ip.org (Postfix, from userid 500) id D9D32CAFA9; Wed, 4 Oct 2006 06:29:39 -0300 (BRT) Date: Wed, 4 Oct 2006 06:29:39 -0300 From: j.romildo@gmail.com To: Olivier Andrieu Cc: caml-list@inria.fr, lablgtk@math.nagoya-u.ac.jp Subject: Re: [Caml-list] Re: missing gtk_button_set_image in lablgtk Message-ID: <20061004092939.GA26571@malaquias.gwiceb1> Mail-Followup-To: Olivier Andrieu , caml-list@inria.fr, lablgtk@math.nagoya-u.ac.jp References: <20061003133439.GA2593@malaquias.gwiceb1> <20061003173755.GA28749@malaquias.gwiceb1> <17698.45953.753908.389772@karryall.dnsalias.org> <17698.46650.264022.232199@karryall.dnsalias.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <17698.46650.264022.232199@karryall.dnsalias.org> User-Agent: Mutt/1.5.13 (2006-08-11) X-j-chkmail-Score: MSGID : 45237F28.000 on discorde : j-chkmail score : X : 0/20 1 X-Miltered: at discorde with ID 45237F28.000 by Joe's j-chkmail (http://j-chkmail.ensmp.fr)! X-Spam: no; 0.00; romildo:01 gtk:01 lablgtk:01 andrieu:01 andrieu:01 bazar-ocaml:01 lablgtk:01 gobj:01 widget:01 gobj:01 widget:01 gtk:01 xalign:01 yalign:01 gbutton:01 On Tue, Oct 03, 2006 at 09:12:58PM +0200, Olivier Andrieu wrote: Content-Description: message body and .signature > Olivier Andrieu [Tuesday 3 October 2006] : > > Here is a patch, with a bunch of other missing properties of > > GtkButton. > Index: gtkButton.props > =================================================================== > RCS file: /net/yquem/devel/caml/repository/bazar-ocaml/lablgtk/src/gtkButton.props,v > retrieving revision 1.5 > diff -u -r1.5 gtkButton.props > --- gtkButton.props 16 Sep 2006 10:33:02 -0000 1.5 > +++ gtkButton.props 3 Oct 2006 19:11:02 -0000 > @@ -11,10 +11,14 @@ > } > > class Button set wrap wrapsig : Bin { > + "focus-on-click" gboolean : Read / Write / NoSet > + "image" GtkWidget_opt : Read / Write / NoSet It seems that defining image this way, as a property, will force the type of set_image to GObj.widget option -> unit, while one may expect it to be GObj.widget -> unit , from the Gtk API documentation. Maybe the property image-position should be defined too. > "label" gchararray : Read / Write / Construct > "use-stock" gboolean : Read / Write / Construct > "use-underline" gboolean : Read / Write / Construct > "relief" GtkReliefStyle : Read / Write > + "xalign" gfloat : Read / Write / NoSet > + "yalign" gfloat : Read / Write / NoSet > signal activate / NoWrap > signal clicked > signal enter > Index: gButton.mli > =================================================================== > RCS file: /net/yquem/devel/caml/repository/bazar-ocaml/lablgtk/src/gButton.mli,v > retrieving revision 1.34 > diff -u -r1.34 gButton.mli > --- gButton.mli 16 Sep 2006 10:33:02 -0000 1.34 > +++ gButton.mli 3 Oct 2006 19:11:02 -0000 > @@ -25,6 +25,14 @@ > method use_underline : bool > method grab_default : unit -> unit > method event : event_ops > + method set_focus_on_click : bool -> unit > + method focus_on_click : bool > + method image : GObj.widget option (** @since GTK 2.6 *) > + method set_image : GObj.widget option -> unit (** @since GTK 2.6 *) Is this really the type we want for set_image? I am not sure. > + method set_xalign : float -> unit (** @since GTK 2.4 *) > + method xalign : float (** @since GTK 2.4 *) > + method set_yalign : float -> unit (** @since GTK 2.4 *) > + method yalign : float (** @since GTK 2.4 *) > end > > (** @gtkdoc gtk GtkButton *) Comparing with the types for label (string), and set_label (string -> unit), option is not used. But probably because here an empty string may be used for un unset label. Although the API doc. says that "If the label text has not been set the return value will be NULL". So, in C, an unset label would return a NULL pointer, instead of the empty string "". Romildo