enter_blocking_section() and string modifications

enter_blocking_section() and string modifications

[Reed Wilson]

Hi guys!

I'm currently writing a multi-threaded program, and part of the program 
is low-level string manipulation. I found that (with the code I'm using) 
making a tight C loop is quite a bit faster than using OCaml, so I'm 
using an external function for that.

My question is: can I use enter_blocking_section() for character 
replacement on an OCaml string? I know I can't use it for allocating 
anything on the heap due to the possibility of the GC doing funny things 
with it, but would straight replacement of existing string data be OK?

I did a test which runs OK, but "has not crashed" <> "will not crash"...

Thanks,
Reed

Re: [Caml-list] enter_blocking_section() and string modifications

[Jacques Garrigue]

From: Reed Wilson <cedilla@gmail.com>

> I'm currently writing a multi-threaded program, and part of the program 
> is low-level string manipulation. I found that (with the code I'm using) 
> making a tight C loop is quite a bit faster than using OCaml, so I'm 
> using an external function for that.
> 
> My question is: can I use enter_blocking_section() for character 
> replacement on an OCaml string? I know I can't use it for allocating 
> anything on the heap due to the possibility of the GC doing funny things 
> with it, but would straight replacement of existing string data be OK?

In general, you can't. The GC may move strings around.
However, if you disable compaction, and if your string is on the old
heap (i.e. it is not young), and you make sure it cannot be
deallocated (the usual CAMLparam macros should be enough for that),
then it should be ok.
Of course there is no point in going through this pain if you're
not sure that concurrency is going to improve performance.

Here is a snippet from ml_gpointer.c, in lablgtk, which copies an
abstract block to the old heap when it is young. Such a block is then
stable as long as there is no compaction.

CAMLprim value ml_stable_copy (value v)
{
    if (Is_block(v) && (char*)(v) < young_end && (char*)(v) > young_start)
    {
        CAMLparam1(v);
        mlsize_t i, wosize = Wosize_val(v);
        int tag = Tag_val(v);
        value ret;
        if (tag < No_scan_tag) invalid_argument("ml_stable_copy");
        ret = alloc_shr (wosize, tag);
        for (i=0; i < wosize; i++) Field(ret,i) = Field(v,i);
        CAMLreturn(ret);
    }
    return v;
}

Jacques Garrigue

Re: [Caml-list] enter_blocking_section() and string modifications

[Reed Wilson]

Jacques Garrigue wrote:
> From: Reed Wilson <cedilla@gmail.com>
> 
>> I'm currently writing a multi-threaded program, and part of the program 
>> is low-level string manipulation. I found that (with the code I'm using) 
>> making a tight C loop is quite a bit faster than using OCaml, so I'm 
>> using an external function for that.
>>
>> My question is: can I use enter_blocking_section() for character 
>> replacement on an OCaml string? I know I can't use it for allocating 
>> anything on the heap due to the possibility of the GC doing funny things 
>> with it, but would straight replacement of existing string data be OK?
> 
> In general, you can't. The GC may move strings around.
> However, if you disable compaction, and if your string is on the old
> heap (i.e. it is not young), and you make sure it cannot be
> deallocated (the usual CAMLparam macros should be enough for that),
> then it should be ok.
> Of course there is no point in going through this pain if you're
> not sure that concurrency is going to improve performance.
> 
> Here is a snippet from ml_gpointer.c, in lablgtk, which copies an
> abstract block to the old heap when it is young. Such a block is then
> stable as long as there is no compaction.
> 
> CAMLprim value ml_stable_copy (value v)
> {
>     if (Is_block(v) && (char*)(v) < young_end && (char*)(v) > young_start)
>     {
>         CAMLparam1(v);
>         mlsize_t i, wosize = Wosize_val(v);
>         int tag = Tag_val(v);
>         value ret;
>         if (tag < No_scan_tag) invalid_argument("ml_stable_copy");
>         ret = alloc_shr (wosize, tag);
>         for (i=0; i < wosize; i++) Field(ret,i) = Field(v,i);
>         CAMLreturn(ret);
>     }
>     return v;
> }
> 
> Jacques Garrigue

Thanks! That's exactly what I needed to know. All of my strings are 
around 8MB, so they'll all be allocated directly on the old heap. I'll 
test to see how much memory is used up by disabling compaction.

And in this case, the concurrency is definitely worth it. With 2 threads 
and 2 processors, using enter_blocking_section() raises CPU usage from 
~50% (i.e. 100% of 1 processor) to ~75%, with a corresponding increase 
in throughput.

Thanks again!
Reed

Re: [Caml-list] enter_blocking_section() and string modifications

[Romain Beauxis]

Le Wednesday 02 April 2008 05:26:27 Reed Wilson, vous avez écrit :
> > Here is a snippet from ml_gpointer.c, in lablgtk, which copies an
> > abstract block to the old heap when it is young. Such a block is then
> > stable as long as there is no compaction.
> >
> > CAMLprim value ml_stable_copy (value v)
> > {
> >     if (Is_block(v) && (char*)(v) < young_end && (char*)(v) >
> > young_start) {
> >         CAMLparam1(v);
> >         mlsize_t i, wosize = Wosize_val(v);
> >         int tag = Tag_val(v);
> >         value ret;
> >         if (tag < No_scan_tag) invalid_argument("ml_stable_copy");
> >         ret = alloc_shr (wosize, tag);
> >         for (i=0; i < wosize; i++) Field(ret,i) = Field(v,i);
> >         CAMLreturn(ret);
> >     }
> >     return v;
> > }
> >
> > Jacques Garrigue
>
> Thanks! That's exactly what I needed to know. All of my strings are
> around 8MB, so they'll all be allocated directly on the old heap. I'll
> test to see how much memory is used up by disabling compaction.
>
> And in this case, the concurrency is definitely worth it. With 2 threads
> and 2 processors, using enter_blocking_section() raises CPU usage from
> ~50% (i.e. 100% of 1 processor) to ~75%, with a corresponding increase
> in throughput.

Isn't it possible to register a global variable for that purpose ?


Romain
-- 
He say 'im that he's the first one
Who discover Jamaica, I an' I say that:
What about the Awarak indians ?