Re: [Caml-list] Trivial compiler patches

["Richard W.M. Jones" <rich@annexia.org>]

[-- Attachment #1: Type: text/plain, Size: 1190 bytes --]

On Sat, Mar 22, 2014 at 09:46:53AM +0900, Jacques Garrigue wrote:
> On 2014/03/22 07:28, Richard W.M. Jones wrote:
> > 
> > What's a good place to send trivial compiler patches?  I don't want to
> > open a new bug for what is essentially a one-line aarch64 fix.
> 
> You should. It would save you the time spent asking this question :-)
> More seriously, in theory all bug fixes should be tracked, even trivial
> ones, since it lets others know where they were fixed (and where not).

Let me tell you how ordinary open source projects operate.

(1) They use git.  No one uses svn.

(2) There is usually a mailing list where patches are posted,
discussed and refined.  For example:

https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html

(3) There may be another path for trivial fixes to get into the
project, eg. for typos, obvious build fixes, whitespace changes and so
on.  In qemu this is:

http://wiki.qemu.org/Contribute/TrivialPatches
https://lists.nongnu.org/mailman/listinfo/qemu-trivial

This encourages people not to give up on simple fixes because of
excessive process.

(4) They use a decent bug tracking system (ie. not Mantis).

Rich.

-- 
Richard Jones
Red Hat

[-- Attachment #2: 0001-arm64-Trivial-fix-for-missing-parameter.patch --]
[-- Type: text/x-diff, Size: 832 bytes --]

From a2395eadd37ac467c5964d2cbabcbf32e1100110 Mon Sep 17 00:00:00 2001
From: "Richard W.M. Jones" <rjones@redhat.com>
Date: Sat, 22 Mar 2014 02:11:32 -0500
Subject: [PATCH] arm64: Trivial fix for missing parameter.

---
 asmcomp/arm64/emit.mlp | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/asmcomp/arm64/emit.mlp b/asmcomp/arm64/emit.mlp
index 341812f..274e6ff 100644
--- a/asmcomp/arm64/emit.mlp
+++ b/asmcomp/arm64/emit.mlp
@@ -604,7 +604,7 @@ let emit_instr i =
         `	ldr	{emit_reg reg_trap_ptr}, [sp], 16\n`;
         cfi_adjust_cfa_offset (-16);
         stack_offset := !stack_offset - 16
-    | Lraise ->
+    | Lraise k ->
         begin match !Clflags.debug, k with
         | true, (Lambda.Raise_regular | Lambda.Raise_reraise) ->
           `	bl	{emit_symbol "caml_raise_exn"}\n`;
-- 
1.8.3.1