From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id F18207F89E for ; Sat, 22 Mar 2014 08:15:11 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of rich@annexia.org) identity=pra; client-ip=80.68.91.176; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="rich@annexia.org"; x-sender="rich@annexia.org"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of rich@annexia.org designates 80.68.91.176 as permitted sender) identity=mailfrom; client-ip=80.68.91.176; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="rich@annexia.org"; x-sender="rich@annexia.org"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@furbychan.cocan.org) identity=helo; client-ip=80.68.91.176; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="rich@annexia.org"; x-sender="postmaster@furbychan.cocan.org"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgMFAFg3LVNQRFuw/2dsb2JhbABZDoJ4O7wIhzqBFBZ0giUBAQEEAQEBJEcLEAsRAwECAQkTEg8FEwEUEw4Th30BCM5IF4YAhnuBEFMRB4MkgRQEkFOFIIJWgTOQf4JuPz2BLA X-IPAS-Result: AgMFAFg3LVNQRFuw/2dsb2JhbABZDoJ4O7wIhzqBFBZ0giUBAQEEAQEBJEcLEAsRAwECAQkTEg8FEwEUEw4Th30BCM5IF4YAhnuBEFMRB4MkgRQEkFOFIIJWgTOQf4JuPz2BLA X-IronPort-AV: E=Sophos;i="4.97,708,1389740400"; d="scan'208,223";a="64075265" Received: from furbychan.cocan.org ([80.68.91.176]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES128-SHA; 22 Mar 2014 08:15:11 +0100 Received: from rich by furbychan.cocan.org with local (Exim 4.80) (envelope-from ) id 1WRG96-00015w-Qj; Sat, 22 Mar 2014 07:15:08 +0000 Date: Sat, 22 Mar 2014 07:15:08 +0000 From: "Richard W.M. Jones" To: Jacques Garrigue Cc: OCaML List Mailing Message-ID: <20140322071508.GB10374@annexia.org> References: <20140321222842.GA10374@annexia.org> <4C341FFE-FDF2-4EA3-B056-D4F658641E4C@math.nagoya-u.ac.jp> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="yrj/dFKFPuw6o+aM" Content-Disposition: inline In-Reply-To: <4C341FFE-FDF2-4EA3-B056-D4F658641E4C@math.nagoya-u.ac.jp> User-Agent: Mutt/1.5.21 (2010-09-15) Subject: Re: [Caml-list] Trivial compiler patches --yrj/dFKFPuw6o+aM Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Sat, Mar 22, 2014 at 09:46:53AM +0900, Jacques Garrigue wrote: > On 2014/03/22 07:28, Richard W.M. Jones wrote: > > > > What's a good place to send trivial compiler patches? I don't want to > > open a new bug for what is essentially a one-line aarch64 fix. > > You should. It would save you the time spent asking this question :-) > More seriously, in theory all bug fixes should be tracked, even trivial > ones, since it lets others know where they were fixed (and where not). Let me tell you how ordinary open source projects operate. (1) They use git. No one uses svn. (2) There is usually a mailing list where patches are posted, discussed and refined. For example: https://lists.gnu.org/archive/html/qemu-devel/2014-03/threads.html (3) There may be another path for trivial fixes to get into the project, eg. for typos, obvious build fixes, whitespace changes and so on. In qemu this is: http://wiki.qemu.org/Contribute/TrivialPatches https://lists.nongnu.org/mailman/listinfo/qemu-trivial This encourages people not to give up on simple fixes because of excessive process. (4) They use a decent bug tracking system (ie. not Mantis). Rich. -- Richard Jones Red Hat --yrj/dFKFPuw6o+aM Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0001-arm64-Trivial-fix-for-missing-parameter.patch" >From a2395eadd37ac467c5964d2cbabcbf32e1100110 Mon Sep 17 00:00:00 2001 From: "Richard W.M. Jones" Date: Sat, 22 Mar 2014 02:11:32 -0500 Subject: [PATCH] arm64: Trivial fix for missing parameter. --- asmcomp/arm64/emit.mlp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/asmcomp/arm64/emit.mlp b/asmcomp/arm64/emit.mlp index 341812f..274e6ff 100644 --- a/asmcomp/arm64/emit.mlp +++ b/asmcomp/arm64/emit.mlp @@ -604,7 +604,7 @@ let emit_instr i = ` ldr {emit_reg reg_trap_ptr}, [sp], 16\n`; cfi_adjust_cfa_offset (-16); stack_offset := !stack_offset - 16 - | Lraise -> + | Lraise k -> begin match !Clflags.debug, k with | true, (Lambda.Raise_regular | Lambda.Raise_reraise) -> ` bl {emit_symbol "caml_raise_exn"}\n`; -- 1.8.3.1 --yrj/dFKFPuw6o+aM--