From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <Sebastien.Hinderer@inria.fr>
X-Original-To: caml-list@sympa.inria.fr
Delivered-To: caml-list@sympa.inria.fr
Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104])
	by sympa.inria.fr (Postfix) with ESMTPS id DB1887F106
	for <caml-list@sympa.inria.fr>; Mon, 18 Jul 2016 10:14:18 +0200 (CEST)
X-IronPort-AV: E=Sophos;i="5.28,383,1464645600"; 
   d="scan'208";a="185074566"
Received: from pl-59055.paris.inria.fr (HELO pl-59055.rocqadm.inria.fr) ([128.93.64.92])
  by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 18 Jul 2016 10:14:18 +0200
Received: from shindere by pl-59055.rocqadm.inria.fr with local (Exim 4.87)
	(envelope-from <Sebastien.Hinderer@inria.fr>)
	id 1bP3gw-0000b9-CA; Mon, 18 Jul 2016 10:14:18 +0200
Date: Mon, 18 Jul 2016 10:14:18 +0200
From: =?utf-8?Q?S=C3=A9bastien?= Hinderer <Sebastien.Hinderer@inria.fr>
To: Gerd Stolpmann <info@gerd-stolpmann.de>
Cc: caml-list@inria.fr
Message-ID: <20160718081418.GC2109@pl-59055.rocqadm.inria.fr>
Mail-Followup-To: Gerd Stolpmann <info@gerd-stolpmann.de>,
	caml-list@inria.fr
References: <1468359569.25014.103.camel@e130.lan.sumadev.de>
 <20160714192653.GA17159@pema>
 <1468594034.25014.129.camel@e130.lan.sumadev.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <1468594034.25014.129.camel@e130.lan.sumadev.de>
Subject: Re: [Caml-list] ocamlnat

Hi Gerd,

Gerd Stolpmann (2016/07/15 16:47 +0200):
> In deed, the native toplevel seems to run fine. So far I made the
> following adjustments in my repo:
> 
>  - renamed the modules so that the same names as for the bytecode
>    version are used (e.g. Opttoploop becomes just Toploop)
>  - added the missing definitions so that the interfaces are
>    identical to the bytecode version
[...]
>  - there was a bug that -linkall was not set when the cmxs files
>    were on-the-fly generated
>  - I also changed the error paths a little bit so that ocamlnat
>    no longer crashes when a symbol isn't found. The error paths
>    probably require more work.

I find all this awesome, thanks a lot for this work.

> It is interesting that only very little work was needed to get there.
> I'll test that more out in the next days, and I think there will be a PR
> soon.

I'd say, do not hesitate to split your work in several (smaller) PRs if
that makes sense. The smaller the PR, the easier the review process.

Sébastien.