From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 1D4537EF1E for ; Thu, 21 Jul 2016 14:09:24 +0200 (CEST) IronPort-PHdr: 9a23:ypR/rB2x8DPteJ5xsmDT+DRfVm0co7zxezQtwd8ZsegRIvad9pjvdHbS+e9qxAeQG96Ks7QZ1qGK6ujJYi8p2d65qncMcZhBBVcuqP49uEgeOvODElDxN/XwbiY3T4xoXV5h+GynYwAOQJ6tL2PbrnD61zMOABK3bVMzfbWtXNOPxJjun8mJuLTrKz1SgzS8Zb4gZD6Xli728vcsvI15N6wqwQHIqHYbM85fxGdvOE7B102kvpT41NdZ/i9Ro/Ms8dJbGeW/JvxgDO8QMDNzGmQ85cujmwPCVgCPri8VVmwXlFxGGQne5xHSWprhsyX78OF63X/JE9fxSOUbXi+97qEjVhjuwA0dOjI06mXQlYQkg6VAvxOn4gI6yabLbYvTOPcoLfCVRs8TWWcUBpUZbCdGGI7pKtJXV+c= Authentication-Results: mail2-smtp-roc.national.inria.fr; spf=None smtp.pra=goswin-v-b@web.de; spf=Pass smtp.mailfrom=goswin-v-b@web.de; spf=None smtp.helo=postmaster@mout.web.de Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of goswin-v-b@web.de) identity=pra; client-ip=212.227.15.14; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="goswin-v-b@web.de"; x-sender="goswin-v-b@web.de"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of goswin-v-b@web.de designates 212.227.15.14 as permitted sender) identity=mailfrom; client-ip=212.227.15.14; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="goswin-v-b@web.de"; x-sender="goswin-v-b@web.de"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@mout.web.de) identity=helo; client-ip=212.227.15.14; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="goswin-v-b@web.de"; x-sender="postmaster@mout.web.de"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0CoAABGupBXhw4P49RdtVyIGYF7hhoCgS04FAEBAQEBAQEBEQEBAQgNCQkhL0EOAYFiBAESAYITAQU6PxALGAkMGQ8FKCEniAEBGgS4Hx+EQQEBAQEBAQQBAQEBASKKd4QmWYJtgi8BBJkmjmGJTgqFbJAhHoJSgVmCXYVdAQEB X-IPAS-Result: A0CoAABGupBXhw4P49RdtVyIGYF7hhoCgS04FAEBAQEBAQEBEQEBAQgNCQkhL0EOAYFiBAESAYITAQU6PxALGAkMGQ8FKCEniAEBGgS4Hx+EQQEBAQEBAQQBAQEBASKKd4QmWYJtgi8BBJkmjmGJTgqFbJAhHoJSgVmCXYVdAQEB X-IronPort-AV: E=Sophos;i="5.28,399,1464645600"; d="scan'208";a="227457523" Received: from mout.web.de ([212.227.15.14]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Jul 2016 14:09:23 +0200 Received: from frosties.localnet ([134.3.242.84]) by smtp.web.de (mrweb002) with ESMTPSA (Nemesis) id 0LrsGE-1bL980093G-013gJT; Thu, 21 Jul 2016 14:09:22 +0200 Received: from mrvn by frosties.localnet with local (Exim 4.87) (envelope-from ) id 1bQCn3-0005oh-5O; Thu, 21 Jul 2016 14:09:21 +0200 Date: Thu, 21 Jul 2016 14:09:21 +0200 From: Goswin von Brederlow To: Alain Frisch Cc: Yotam Barnoy , Ocaml Mailing List Message-ID: <20160721120920.GB22056@frosties> References: <20f0b337-2935-5a20-4aa6-642758648d55@lexifi.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20f0b337-2935-5a20-4aa6-642758648d55@lexifi.com> User-Agent: Mutt/1.6.0 (2016-04-01) X-Provags-ID: V03:K0:3G6dmB8xrPLFbkJxpL/458kOwqI8PoYVUgLAxB+zlTjG9bbOZN+ Bs2009SA3pQl/dqdnp7meok60xf4u1BwX8guNbujxoO9pHQGzx/i6pkissL8+Y7iNulN4kL v5B4suwZWJzEU8IS0lBeezS/+UPrFSsUz2Dsncy5tSswCBegb+uG1ZAUZ6x3+adLs8Bx//B sxiHzXHB/x0WsxTYCfcGQ== X-UI-Out-Filterresults: notjunk:1;V01:K0:HagVWPyB2oU=:3h1VSziCmd2YB/Ya3sGI1n mkYoD+pbpE7BCvtSIdHYW2pVLnGgC7QrDbuByeo1sugrixtb/jk/VrTuCH5Ca1MHz0DFKOVPB nhIZlIB7+EX6TJjUu/V26LgbNUt2GPGzsHpT428twY27vWrFLZSUUPCVRNcXfKPY9sqQFBZKA 10xCmZVAKODbBWTPLJEwF+JKMr1snIvTOFW9mQ1y0yneaN9fvEH7tLCvAurqyQ2oSkvy61cg1 KFeRB/aRrZDVerutW31h7VqUDdg1M/Yvdbm+y6ymnY+SONzJwk8MiYI9xi7ZSI1Mnb0NAJ5eh 2NbXlHOi4pLJ89gYTjwNWCiTEN9cWh7L1+caadQVdbKdAsoHcP+DCA2bGIXxTTPbB5NSMKqKD h2KZMlglwstX7bJminrUrCPixLlIdTylTJ1pt5f21Q1JPR2VgO3BysDbEamtBiwFDy1EiMn7X xkwBNN8elMsY7Nui4gZ6SxN15ZQE0AvsSCUpHy9FNAfFYZ/smEZAjxznDu+agNah0e0mHanmL JzQuaCGquXOXxZ4yirLIEKi3dsq+7AZjcgFb4Zk7lzBTpqK2OAJq6m4rh3h6cPfdFbPLxHaUX 3MjMyDGtvD6I4CdF0gmniedjOiOkaoDWMiFaNd+P8sbcimg6auGYWeUlc/zy96Emq5PUxP4j2 K0QIXmUEK0Gu3eAN+xAn/+wFPAUk0oaP5be1bMbm7gnERwV6GREdn9GqbQ5LAueCZtvz2jVQe NsB9g++W7BJwV7n8sJn6ok4iL9bHkmxYDMqw9wiv0XThNy98gZ40dw0bBvY= Subject: Re: [Caml-list] Recent hooks design and general github PR issues On Tue, Jul 19, 2016 at 10:21:14PM +0200, Alain Frisch wrote: > On 19/07/2016 17:08, Yotam Barnoy wrote: > > It may also be worthwhile to say that except for rare exceptions > > (mostly bug fixes), PRs should not be merged by the same person who > > authored them, as this makes the process seem biased and questionable. > > Open source projects have leaders (Xavier and Damien, for OCaml), and other > core maintainers with more decision power than the community. And in the > community, the opinions of some people have more weight than those of > others. Of course, the process is biased! > > But compare to the situation before the switch to Git and GitHub: new > developments were almost always pushed/committed by the author if they had > commit rights, sometimes discussed (well, usually evoked) on caml-devel > before, and even less often on Mantis. > > The new situation is much more open and the level of review has increased > significantly. When someone with commit rights submits a PR, this is more > community-friendly than pushing directly to trunk (which is not forbidden, > and still happens), even if the same person finally does the merge after > taking comments (from everyone) into account. Possibly nobody feels like > commenting, reviewing, nor endorsing the proposal; this is not ideal, but I > don't think this should prevent merging after a reasonable amount of time, > preferably also after mentioning the imminent merge. > > > Alain Many other projects use the rule that PR author != merger. Even leaders make mistakes and this simple rulte gives each PR a second set of eyes. +1 to that suggestion. MfG Goswin