From: "Richard W.M. Jones" <rich@annexia.org>
To: "Petter A. Urkedal" <paurkedal@gmail.com>
Cc: caml-list <caml-list@inria.fr>
Subject: Re: [Caml-list] What if exn was not an open type?
Date: Sun, 5 Nov 2017 18:24:56 +0000 [thread overview]
Message-ID: <20171105182456.bcx2ueyxulcqouyp@annexia.org> (raw)
In-Reply-To: <CALa9pHSw=-Mzg=D=fNn5goNJvqiBS0D265ba=P5uxV3261g32Q@mail.gmail.com>
On Sun, Nov 05, 2017 at 07:02:12PM +0100, Petter A. Urkedal wrote:
> I vouch for octachron solution to the lack of polymorphism in the
> return function.
>
> I tried to reformat the inspect_fs_unix_fstab.ml more along my own
> coding style to get a feel for the issue:
>
> https://gist.github.com/paurkedal/80b89c8fabe041e62eccc596d51f382b
>
> What doesn't work with this style is falling though to the next block,
> though I'm not sure that's I good for maintainability anyway. This
> is, however, even further away from the C style.
That appears to mainly play with indentation, which just means that
our tools won't work well.
FWIW here's the updated version I ended up with:
https://gist.github.com/rwmjones/426821925fd1250096d7ddaac4103a12#file-gistfile1-txt-L57
This was formed by going back to the original C code:
https://github.com/libguestfs/libguestfs/blob/5b74dd98a7926191cc085fc36be57f58bd6d80d8/lib/inspect-fs-unix.c#L1273
and rearranging the OCaml code to look more like it, adding return
statements to achieve this.
For those wondering why, the aim here is to translate the code from C
to OCaml as closely as possible (at first) in order to minimize the
inevitable bugs that will be added during the translation. The C code
is very well tested over years. I have plans to rework the code
completely later to make real use of OCaml, but first don't break
things.
Rich.
next prev parent reply other threads:[~2017-11-05 18:24 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-10-20 9:56 Malcolm Matalka
2017-10-20 10:55 ` David Allsopp
2017-10-20 11:21 ` Ivan Gotovchits
2017-10-20 11:38 ` Simon Cruanes
2017-10-20 16:54 ` Malcolm Matalka
2017-10-20 19:47 ` Simon Cruanes
2017-10-21 21:15 ` Malcolm Matalka
2017-10-24 13:30 ` Richard W.M. Jones
2017-10-24 19:02 ` Petter A. Urkedal
2017-11-04 18:44 ` Richard W.M. Jones
2017-11-04 18:48 ` SP
2017-11-04 18:53 ` Richard W.M. Jones
2017-11-04 19:03 ` SP
2017-11-04 19:01 ` Max Mouratov
2017-11-04 19:16 ` octachron
2017-11-05 17:41 ` Richard W.M. Jones
2017-11-05 18:39 ` Yaron Minsky
2017-11-05 20:49 ` Gabriel Scherer
2017-11-05 21:48 ` Yaron Minsky
2017-11-05 21:53 ` Petter A. Urkedal
2017-11-05 18:02 ` Petter A. Urkedal
2017-11-05 18:24 ` Richard W.M. Jones [this message]
2017-11-05 18:55 ` Petter A. Urkedal
[not found] ` <CALa9pHQ-nhWf4T0U5gDiKTduPiEeXSZPQ=DY6N1YNbCXqRohPQ@mail.gmail.com>
2017-10-25 8:35 ` Richard W.M. Jones
2017-10-25 9:12 ` Philippe Veber
2017-10-25 14:52 ` Richard W.M. Jones
2017-10-25 16:37 ` Ivan Gotovchits
2017-10-25 17:47 ` SP
2017-10-26 8:06 ` Malcolm Matalka
2017-10-26 8:11 ` Xavier Leroy
2017-10-25 13:36 ` Ivan Gotovchits
2017-10-26 7:31 ` Petter A. Urkedal
2017-10-27 13:58 ` Oleg
2017-10-27 14:24 ` Philippe Veber
2017-10-27 14:49 ` Leo White
2017-11-01 7:16 ` Oleg
2017-11-04 17:52 ` Philippe Veber
2017-10-20 17:07 ` Malcolm Matalka
2017-10-21 21:28 ` Nathan Moreau
2017-10-22 12:39 ` Malcolm Matalka
2017-10-22 13:08 ` Nathan Moreau
2017-10-24 11:11 ` SP
2017-10-24 11:16 ` Gabriel Scherer
2017-10-25 11:30 ` Malcolm Matalka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20171105182456.bcx2ueyxulcqouyp@annexia.org \
--to=rich@annexia.org \
--cc=caml-list@inria.fr \
--cc=paurkedal@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).