From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 2B00D7EF1E for ; Tue, 19 Jul 2016 22:21:19 +0200 (CEST) IronPort-PHdr: 9a23:ZeuiCheCWcs+BCLqkKsKuDUflGMj4u6mDksu8pMizoh2WeGdxc+7Yx7h7PlgxGXEQZ/co6odzbGH6+a9ACdZvcvJmUtBWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYsExnyfTB4Ov7yUtaLyZ/mj6bvotaKP1gArQH+SIs6FA+xowTVu5teqqpZAYF19CH0pGBVcf9d32JiKAHbtR/94sCt4MwrqHwI6LoJvvRNWqTifqk+UacQTHF/azh0t4XXskzySheG4zM2W38QlQsAVxnC8Bj/VJ7rtCzrnuV40Siee8bxSOZwEROp5qJvADrhiSMGMTFx1GDMloQkh6tepFelpgdj64/SeoCccvRkKPDzZ9QfEENFV8dXHwJbA5i3b8NbBu4IPOAeoZP8vFAOhR+zFQiiBaXkzToe1Sy+5rEzz+l0SVKO5wcnBd9b9S2M9Ng= Authentication-Results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=alain.frisch@lexifi.com; spf=None smtp.mailfrom=alain.frisch@lexifi.com; spf=None smtp.helo=postmaster@mx20.yaziba.net Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of alain.frisch@lexifi.com) identity=pra; client-ip=85.233.204.164; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="alain.frisch@lexifi.com"; x-sender="alain.frisch@lexifi.com"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of alain.frisch@lexifi.com) identity=mailfrom; client-ip=85.233.204.164; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="alain.frisch@lexifi.com"; x-sender="alain.frisch@lexifi.com"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@mx20.yaziba.net) identity=helo; client-ip=85.233.204.164; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="alain.frisch@lexifi.com"; x-sender="postmaster@mx20.yaziba.net"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0DoAwAPi45Xh6TM6VVdhD+7OIYVAwICgTM8EAEBAQEBAQEBEQEBAQoLCQkhL4IyBAESAYITAQUjFVELGAICERUCAlcGAQwIAQEQiCCvA41OAQEIAgEkgQGFKYF4CIJNhCZZgkKCWgEEmSSBXo0EiVCFZ5AcAjWCO4FZiREBAQE X-IPAS-Result: A0DoAwAPi45Xh6TM6VVdhD+7OIYVAwICgTM8EAEBAQEBAQEBEQEBAQoLCQkhL4IyBAESAYITAQUjFVELGAICERUCAlcGAQwIAQEQiCCvA41OAQEIAgEkgQGFKYF4CIJNhCZZgkKCWgEEmSSBXo0EiVCFZ5AcAjWCO4FZiREBAQE X-IronPort-AV: E=Sophos;i="5.28,390,1464645600"; d="scan'208";a="185264355" Received: from mx20.yaziba.net ([85.233.204.164]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 19 Jul 2016 22:21:18 +0200 Received: from mta20.int.yaziba.net (mta20.int.yaziba.net [10.4.20.31]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx20.yaziba.net (mx10.yaziba.net) with ESMTPS id 729A31A7588; Tue, 19 Jul 2016 22:21:17 +0200 (CEST) Received: from mta20.int.yaziba.net (localhost [127.0.0.1]) by mta20.int.yaziba.net (Postfix) with ESMTPS id 8D697CA76A; Tue, 19 Jul 2016 22:21:17 +0200 (CEST) Received: from localhost (localhost [127.0.0.1]) by mta20.int.yaziba.net (Postfix) with ESMTP id 7D37ACA76F; Tue, 19 Jul 2016 22:21:17 +0200 (CEST) X-Virus-Scanned: amavisd-new at mta20.int.yaziba.net Received: from mta20.int.yaziba.net ([127.0.0.1]) by localhost (mta20.int.yaziba.net [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id xby0R6EFaZjY; Tue, 19 Jul 2016 22:21:17 +0200 (CEST) Received: from [192.168.1.11] (LFbn-1-535-219.w86-245.abo.wanadoo.fr [86.245.27.219]) by mta20.int.yaziba.net (Postfix) with ESMTPSA id 38722CA657; Tue, 19 Jul 2016 22:21:17 +0200 (CEST) To: Yotam Barnoy , Ocaml Mailing List References: From: Alain Frisch Message-ID: <20f0b337-2935-5a20-4aa6-642758648d55@lexifi.com> Date: Tue, 19 Jul 2016 22:21:14 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-DRWEB-SCAN: ok X-VRSPAM-SCORE: -100 X-VRSPAM-STATE: legit X-VRSPAM-CAUSE: gggruggvucftvghtrhhoucdtuddrfeeltddrhedugddugeejucetufdoteggodetrfcurfhrohhfihhlvgemucggtfgfnhhsuhgsshgtrhhisggvpdgjtegkkfeuteenuceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmnecujfgurhepuffvfhfhkffffgggjggtgfesthejredttdefjeenucfhrhhomheptehlrghinhcuhfhrihhstghhuceorghlrghinhdrfhhrihhstghhsehlvgigihhfihdrtghomheqnecukfhppeekiedrvdeghedrvdejrddvudelnecurfgrrhgrmhepmhhouggvpehsmhhtphhouhht X-VRSPAM-EXTCAUSE: mhhouggvpehsmhhtphhouhht Subject: Re: [Caml-list] Recent hooks design and general github PR issues On 19/07/2016 17:08, Yotam Barnoy wrote: > It may also be worthwhile to say that except for rare exceptions > (mostly bug fixes), PRs should not be merged by the same person who > authored them, as this makes the process seem biased and questionable. Open source projects have leaders (Xavier and Damien, for OCaml), and other core maintainers with more decision power than the community. And in the community, the opinions of some people have more weight than those of others. Of course, the process is biased! But compare to the situation before the switch to Git and GitHub: new developments were almost always pushed/committed by the author if they had commit rights, sometimes discussed (well, usually evoked) on caml-devel before, and even less often on Mantis. The new situation is much more open and the level of review has increased significantly. When someone with commit rights submits a PR, this is more community-friendly than pushing directly to trunk (which is not forbidden, and still happens), even if the same person finally does the merge after taking comments (from everyone) into account. Possibly nobody feels like commenting, reviewing, nor endorsing the proposal; this is not ideal, but I don't think this should prevent merging after a reasonable amount of time, preferably also after mentioning the imminent merge. Alain