Re: [Caml-list] removal of C compiler variables in in 4.06

["Stéphane Glondu" <steph@glondu.net>]

On 18/07/2017 14:24, Gabriel Scherer wrote:
> Stéphane, in your patches, it looks to me like you apply the
> 4.06-required change in 0001-Fix-for-ocaml-4.06.patch,

That patch is not mine. It is taken from upstream git repository. My 
patches are 0002- to 0004- and (should) apply to the master branch of 
upstream repository.

> and then you
> cancel them in 0003-CC-variable-does-not-exist-in-4.05.0-s-Makefile.conf.patch
> to go back to the unchanged state. Could you apply none of them
> instead? (It does not help that there is an unrelated change in
> 0001-..-4.06.patch, it would be nicer to have two separate patches.)

I agree. I kept 0001- as is because the unrelated change is also needed 
to compile with 4.05.0

> Note that your patch 0002-Fix-calls-to-caml_-functions.patch is very
> nice (use of the caml_ prefix for C runtime functions, the unprefixed
> functions being deprecated and disabled by default), you should
> definitely submit it upstream.

https://github.com/garrigue/labltk/issues/4


Cheers,

-- 
Stéphane