From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <steph@glondu.net>
X-Original-To: caml-list@sympa.inria.fr
Delivered-To: caml-list@sympa.inria.fr
Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104])
	by sympa.inria.fr (Postfix) with ESMTPS id E8308801D9
	for <caml-list@sympa.inria.fr>; Tue, 18 Jul 2017 14:59:36 +0200 (CEST)
X-IronPort-AV: E=Sophos;i="5.40,377,1496095200"; 
   d="scan'208";a="231917322"
Received: from wencory.loria.fr ([152.81.3.42])
  by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 18 Jul 2017 14:59:36 +0200
Received: from localhost ([127.0.0.1])
	by wencory.loria.fr with esmtp (Exim 4.89)
	(envelope-from <steph@glondu.net>)
	id 1dXS6B-0005Du-MR; Tue, 18 Jul 2017 14:59:35 +0200
To: Gabriel Scherer <gabriel.scherer@gmail.com>
Cc: Olaf Hering <olaf@aepfle.de>, caml users <caml-list@inria.fr>
References: <20170718090258.GB2151@aepfle.de>
 <f55864cf-36f0-6e88-25d5-d1e6e13deb57@glondu.net>
 <CAPFanBGM-O9qdyxg1kT5JSA_+sC2A+p3m+OXwZ0WGJbTgcv=hw@mail.gmail.com>
From: =?UTF-8?Q?St=c3=a9phane_Glondu?= <steph@glondu.net>
Message-ID: <39097b87-8489-d5f4-c766-11766ac70bee@glondu.net>
Date: Tue, 18 Jul 2017 14:59:35 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101
 Thunderbird/52.2.1
MIME-Version: 1.0
In-Reply-To: <CAPFanBGM-O9qdyxg1kT5JSA_+sC2A+p3m+OXwZ0WGJbTgcv=hw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: fr
Content-Transfer-Encoding: 8bit
Subject: Re: [Caml-list] removal of C compiler variables in in 4.06

On 18/07/2017 14:24, Gabriel Scherer wrote:
> Stéphane, in your patches, it looks to me like you apply the
> 4.06-required change in 0001-Fix-for-ocaml-4.06.patch,

That patch is not mine. It is taken from upstream git repository. My 
patches are 0002- to 0004- and (should) apply to the master branch of 
upstream repository.

> and then you
> cancel them in 0003-CC-variable-does-not-exist-in-4.05.0-s-Makefile.conf.patch
> to go back to the unchanged state. Could you apply none of them
> instead? (It does not help that there is an unrelated change in
> 0001-..-4.06.patch, it would be nicer to have two separate patches.)

I agree. I kept 0001- as is because the unrelated change is also needed 
to compile with 4.05.0

> Note that your patch 0002-Fix-calls-to-caml_-functions.patch is very
> nice (use of the caml_ prefix for C runtime functions, the unprefixed
> functions being deprecated and disabled by default), you should
> definitely submit it upstream.

https://github.com/garrigue/labltk/issues/4


Cheers,

-- 
Stéphane