commands.getoutput () in ocaml?

commands.getoutput () in ocaml?

[Luca de Alfaro]

[-- Attachment #1: Type: text/plain, Size: 366 bytes --]

Dear All,

I am looking for a quick way to do the equivalent of

s = commands.getoutput ("ls " + name + "*")

in Ocaml.

Unix.system does perform a call, but the output of the call is not
returned... yes, I can redirect it to /tmp/output.ocaml and then read the
file, or even go crazy and build pipes, but is there a more elegant (read:
succint) way to do it?

Luca

[-- Attachment #2: Type: text/html, Size: 429 bytes --]

Re: [Caml-list] commands.getoutput () in ocaml?

[malc]

On Wed, 22 Aug 2007, Luca de Alfaro wrote:

> Dear All,
>
> I am looking for a quick way to do the equivalent of
>
> s = commands.getoutput ("ls " + name + "*")
>
> in Ocaml.
>
> Unix.system does perform a call, but the output of the call is not
> returned... yes, I can redirect it to /tmp/output.ocaml and then read the
> file, or even go crazy and build pipes, but is there a more elegant (read:
> succint) way to do it?

I needed something to that effect yesterday and wrote following:

open Unix;;

let getprocout cmd =
   let ic = open_process_in cmd in
   let b = Buffer.create 10 in
   let rec loop () =
     match try Some (input_line ic) with End_of_file -> None with
       | None -> Buffer.contents b
       | Some line ->
           Buffer.add_string b line;
           loop ()
   in
     loop ()
;;

-- 
vale

Re: [Caml-list] commands.getoutput () in ocaml?

[malc]

On Thu, 23 Aug 2007, malc wrote:

> On Wed, 22 Aug 2007, Luca de Alfaro wrote:
>
>> Dear All,

[..snip..]

>
> open Unix;;
>
> let getprocout cmd =
[..snip..]
> ;;

This does not include closing of input channel and processing of
status. So Unix.close_process_in ought to be utilized somewhere.
Sorry about that.

-- 
vale

Re: [Caml-list] commands.getoutput () in ocaml?

[Dave Benjamin]

On Wed, 22 Aug 2007, Luca de Alfaro wrote:

> I am looking for a quick way to do the equivalent of
> s = commands.getoutput ("ls " + name + "*")
> in Ocaml.

I have translated many of the examples from the Perl Cookbook for the 
Process Management and Communication chapter of the OCaml PLEAC. This is 
one of the topics covered.

http://pleac.sourceforge.net/pleac_ocaml/processmanagementetc.html

Dave

Re: [Caml-list] commands.getoutput () in ocaml?

[Brian Hurt]

Luca de Alfaro wrote:

> Dear All,
>
> I am looking for a quick way to do the equivalent of
>
> s = commands.getoutput ("ls " + name + "*")
>
> in Ocaml.
>
> Unix.system does perform a call, but the output of the call is not 
> returned... yes, I can redirect it to /tmp/output.ocaml and then read 
> the file, or even go crazy and build pipes, but is there a more 
> elegant (read: succint) way to do it?
>
> Luca
>
If what you want is to spawn a process and redirect the I/O, the 
standard library is short on convience functions- in this way Ocaml is 
more similiar to C++/Java than it is Perl/Python/Ruby.  Although the 
convience functions are not that hard to write.  If you want to read a 
directory, you might want to look at Unix.opendir, Unix.readdir, etc.

Brian

Re: [Caml-list] commands.getoutput () in ocaml?

[Luca de Alfaro]

[-- Attachment #1: Type: text/plain, Size: 646 bytes --]

Thanks, this is truly wonderful!

I wish more of the things we are discussing and discovering in this email
list would make it to the official Ocaml site...

Luca

On 8/22/07, Dave Benjamin <dave@ramenlabs.com> wrote:
>
> On Wed, 22 Aug 2007, Luca de Alfaro wrote:
>
> > I am looking for a quick way to do the equivalent of
> > s = commands.getoutput ("ls " + name + "*")
> > in Ocaml.
>
> I have translated many of the examples from the Perl Cookbook for the
> Process Management and Communication chapter of the OCaml PLEAC. This is
> one of the topics covered.
>
> http://pleac.sourceforge.net/pleac_ocaml/processmanagementetc.html
>
> Dave
>

[-- Attachment #2: Type: text/html, Size: 1068 bytes --]

Re: [Caml-list] commands.getoutput () in ocaml?

[Yitzhak Mandelbaum]

[-- Attachment #1: Type: text/plain, Size: 1553 bytes --]

Perhaps its time for a stronger community process. A discussion about  
this was started here a few weeks ago but it fizzled out pretty  
quickly.  It seems we need to find a balance between the best  
interests of the ocaml developer community and the best interests of  
ocaml compiler developers.

Is anybody familiar with the Java community process and how that  
worked out?

Cheers,
Yitzhak

On Aug 22, 2007, at 5:32 PM, Luca de Alfaro wrote:

> Thanks, this is truly wonderful!
>
> I wish more of the things we are discussing and discovering in this  
> email list would make it to the official Ocaml site...
>
> Luca
>
> On 8/22/07, Dave Benjamin <dave@ramenlabs.com> wrote:
> On Wed, 22 Aug 2007, Luca de Alfaro wrote:
>
> > I am looking for a quick way to do the equivalent of
> > s = commands.getoutput ("ls " + name + "*")
> > in Ocaml.
>
> I have translated many of the examples from the Perl Cookbook for the
> Process Management and Communication chapter of the OCaml PLEAC.  
> This is
> one of the topics covered.
>
> http://pleac.sourceforge.net/pleac_ocaml/processmanagementetc.html
>
> Dave
>
> _______________________________________________
> Caml-list mailing list. Subscription management:
> http://yquem.inria.fr/cgi-bin/mailman/listinfo/caml-list
> Archives: http://caml.inria.fr
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs

--------------------------------------------------
Yitzhak Mandelbaum
AT&T Labs - Research

http://www.research.att.com/~yitzhak



[-- Attachment #2: Type: text/html, Size: 5079 bytes --]

Re: [Caml-list] commands.getoutput () in ocaml?

[Daniel Bünzli]

Le 22 août 07 à 23:32, Luca de Alfaro a écrit :

> I wish more of the things we are discussing and discovering in this  
> email list would make it to the official Ocaml site...

Feel free to add what you discover to this page :

http://cocan.org/faqs_and_programming_guidelines

Best,

Daniel

Re: [Caml-list] commands.getoutput () in ocaml?

[Olivier Andrieu]

On 8/22/07, Dave Benjamin <dave@ramenlabs.com> wrote:
> On Wed, 22 Aug 2007, Luca de Alfaro wrote:
>
> > I am looking for a quick way to do the equivalent of
> > s = commands.getoutput ("ls " + name + "*")
> > in Ocaml.
>
> I have translated many of the examples from the Perl Cookbook for the
> Process Management and Communication chapter of the OCaml PLEAC. This is
> one of the topics covered.
>
> http://pleac.sourceforge.net/pleac_ocaml/processmanagementetc.html

about this function:

(* Run a command and return its results as a string. *)
let read_process command =
  let buffer_size = 2048 in
  let buffer = Buffer.create buffer_size in
  let string = String.create buffer_size in
  let in_channel = Unix.open_process_in command in
  let chars_read = ref 1 in
  while !chars_read <> 0 do
    chars_read := input in_channel string 0 buffer_size;
    Buffer.add_string buffer (String.sub string 0 !chars_read)
  done;
  close_in in_channel;
  Buffer.contents buffer

you could use Buffer.add_substring instead of add_string, that will
avoid an intermediate copy of the string

... and you should be using Unix.close_process_in, not close_in
otherwise the subprocess will stay as a zombie.

-- 
  Olivier

Re: [Caml-list] commands.getoutput () in ocaml?

[Dave Benjamin]

On Wed, 22 Aug 2007, Eric Cooper wrote:

> On Thu, Aug 23, 2007 at 12:35:14AM +0200, Olivier Andrieu wrote:
>> you could use Buffer.add_substring instead of add_string, that will
>> avoid an intermediate copy of the string
>
> And you can use Buffer.add_channel to avoid intermediate strings
> altogether (until the final Buffer.to_string).

Thanks, guys! I really appreciate the feedback, and will make these 
suggested improvements (though it may take awhile to show up on the site). 
If you find any other mistakes, please let me know.

Dave

Re: [Caml-list] commands.getoutput () in ocaml?

[Eric Cooper]

On Thu, Aug 23, 2007 at 12:35:14AM +0200, Olivier Andrieu wrote:
> you could use Buffer.add_substring instead of add_string, that will
> avoid an intermediate copy of the string

And you can use Buffer.add_channel to avoid intermediate strings
altogether (until the final Buffer.to_string).

-- 
Eric Cooper             e c c @ c m u . e d u

Re: [Caml-list] commands.getoutput () in ocaml?

[Dave Benjamin]

On Wed, 22 Aug 2007, Eric Cooper wrote:

> On Thu, Aug 23, 2007 at 12:35:14AM +0200, Olivier Andrieu wrote:
>> you could use Buffer.add_substring instead of add_string, that will
>> avoid an intermediate copy of the string
>
> And you can use Buffer.add_channel to avoid intermediate strings
> altogether (until the final Buffer.to_string).

I'm not quite sure how to do this, actually. Here's what I've got so far:

let read_process command =
   let buffer_size = 2048 in
   let buffer = Buffer.create buffer_size in
   let in_channel = Unix.open_process_in command in
   begin
     try
       while true do
         Buffer.add_channel buffer in_channel buffer_size;
       done
     with
       | End_of_file -> ()
       | e ->
           ignore (Unix.close_process_in in_channel);
           raise e;
   end;
   ignore (Unix.close_process_in in_channel);
   Buffer.contents buffer

However, this doesn't work unless I set buffer_size to 1. Otherwise, the 
End_of_file fires before all the data is read in, so I either get nothing 
or an incomplete result.

Any advice?

Thanks,
Dave

Re: [Caml-list] commands.getoutput () in ocaml?

[Dr. Axel Poigné]

>
>
>> I am looking for a quick way to do the equivalent of
>> s = commands.getoutput ("ls " + name + "*")
>> in Ocaml.
>>
>
> I have translated many of the examples from the Perl Cookbook for  
> the Process Management and Communication chapter of the OCaml  
> PLEAC. This is one of the topics covered.
>
> http://pleac.sourceforge.net/pleac_ocaml/processmanagementetc.html
>
> Dave
>

There is a problem with the read_process_lines function though: if  
the output buffer gets too long the process does not return to close  
the input channel. Consequence is that the spawning process is blocked.

That's a problem I do not know how to solve.

Axel

Re: [Caml-list] commands.getoutput () in ocaml?

[Eric Cooper]

On Wed, Aug 22, 2007 at 11:03:42PM -0500, Dave Benjamin wrote:
> However, this doesn't work unless I set buffer_size to 1. Otherwise, the 
> End_of_file fires before all the data is read in, so I either get nothing 
> or an incomplete result.

Since you can't use Pervasives.in_channel_length on a pipe, the only
way I see is to write a special add_channel_tail function, called only
when you catch the first Eof, that tries successively to add_channel
n, n-1, n-2, ... etc. bytes until it succeeds. Sigh.

-- 
Eric Cooper             e c c @ c m u . e d u