From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on yquem.inria.fr X-Spam-Level: * X-Spam-Status: No, score=1.0 required=5.0 tests=AWL,SPF_NEUTRAL autolearn=disabled version=3.1.3 X-Original-To: caml-list@yquem.inria.fr Delivered-To: caml-list@yquem.inria.fr Received: from mail1-relais-roc.national.inria.fr (mail1-relais-roc.national.inria.fr [192.134.164.82]) by yquem.inria.fr (Postfix) with ESMTP id AD5FBBC6B for ; Tue, 30 Oct 2007 06:52:05 +0100 (CET) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAGBjJkfAXQImh2dsb2JhbACOXgIBCAop X-IronPort-AV: E=Sophos;i="4.21,345,1188770400"; d="scan'208";a="3816958" Received: from discorde.inria.fr ([192.93.2.38]) by mail1-smtp-roc.national.inria.fr with ESMTP; 30 Oct 2007 06:52:05 +0100 Received: from mail4-relais-sop.national.inria.fr (mail4-relais-sop.national.inria.fr [192.134.164.105]) by discorde.inria.fr (8.13.6/8.13.6) with ESMTP id l9U5q4f9032094 (version=TLSv1/SSLv3 cipher=RC4-SHA bits=128 verify=OK) for ; Tue, 30 Oct 2007 06:52:05 +0100 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AgAAAG5iJkfRVYT1kGdsb2JhbACOXgIBAQcCCBERBQ X-IronPort-AV: E=Sophos;i="4.21,345,1188770400"; d="scan'208";a="18751683" Received: from an-out-0708.google.com ([209.85.132.245]) by mail4-smtp-sop.national.inria.fr with ESMTP; 30 Oct 2007 06:52:03 +0100 Received: by an-out-0708.google.com with SMTP id c36so250594ana for ; Mon, 29 Oct 2007 22:52:02 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; bh=tUSkWO4nG3gShq/tLxNR6PHJlNqeK0riiVqSEd6uKBQ=; b=TuceJZsgs1CJwd1IcdyUA0In+I/V6m5G5RbryDajC3fEpPog61LWirzvJCDl/q+B0hrhsGDo+dqel0HQVVmPNh7j8kfp1vJYKXHnM5mMkkVfvqUpFSvHHodhTRp/4Z0pgx0rffkYoa2wJQeyGnZwwiOaZpf1WJbvMI9xvVWeD44= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:user-agent:mime-version:to:subject:references:in-reply-to:content-type; b=txqjlWqAGXC1kRakhgahSU3fgkmY0N5MQ4lDCCfcmRmONQEWm0RMgBPLUp1qfl6m9W/UdxDQ2+NmiGJXn+SN5rMNe0ZcFahQUw6dy2ykLBXPj0JEy0dLHLkUn5MbTqmCJFrx5aFNqMwStmvHymvRFD0pzEzIXCH6/4OukaahEFU= Received: by 10.100.31.3 with SMTP id e3mr2283344ane.1193723522352; Mon, 29 Oct 2007 22:52:02 -0700 (PDT) Received: from ?192.168.0.7? ( [69.154.217.112]) by mx.google.com with ESMTPS id 34sm10007793wra.2007.10.29.22.51.55 (version=SSLv3 cipher=RC4-MD5); Mon, 29 Oct 2007 22:51:58 -0700 (PDT) Message-ID: <4726C67A.5050302@gmail.com> Date: Tue, 30 Oct 2007 00:51:54 -0500 From: Edgar Friendly User-Agent: Thunderbird 2.0.0.6 (X11/20070728) MIME-Version: 1.0 To: Caml List Subject: Re: [Caml-list] Patch to 3.10.0 compiler enabling simple spell-checking References: <47264C70.5050100@gmail.com> <20071029233203.GA15270@localhost> In-Reply-To: <20071029233203.GA15270@localhost> Content-Type: multipart/mixed; boundary="------------000809040309080205080408" X-Miltered: at discorde with ID 4726C684.000 by Joe's j-chkmail (http://j-chkmail . ensmp . fr)! X-Spam: no; 0.00; compiler:01 edgar:98 edgar:98 favored:98 wrote:01 wrote:01 caml-list:01 edges:01 incomplete:03 suffice:03 bits:05 multi-part:94 rough:08 draft:08 draft:08 X-Attachments: cset="UTF-8" type="text/x-patch" name="ocaml-spelling-3.10.0.patch" name="ocaml-spelling-3.10.0.patch" This is a multi-part message in MIME format. --------------000809040309080205080408 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Julien Moutinho wrote: > On Mon, Oct 29, 2007 at 04:11:12PM -0500, Edgar Friendly wrote: >> Spending some time with the 3.10.0 sources, I have created >> a "second draft" patch creating this functionality >> in my favored language. > > I'm sorry but could it be that you have posted an incomplete patch? I did. Here's a "third draft" which should include all the necessary bits to patch off 3.10.0. There's still plenty of rough edges to smooth out in the patch, but it should suffice for people to have something working. E. --------------000809040309080205080408 Content-Type: text/x-patch; name="ocaml-spelling-3.10.0.patch" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="ocaml-spelling-3.10.0.patch" diff --git a/typing/env.ml b/typing/env.ml index 780ed8d..a0114be 100644 --- a/typing/env.ml +++ b/typing/env.ml @@ -357,7 +357,7 @@ and lookup_module lid env = let lookup proj1 proj2 lid env = match lid with Lident s -> - Ident.find_name s (proj1 env) + Ident.find_name_with_nearly s (proj1 env) | Ldot(l, s) -> let (p, desc) = lookup_module_descr l env in begin match Lazy.force desc with @@ -373,7 +373,7 @@ let lookup proj1 proj2 lid env = let lookup_simple proj1 proj2 lid env = match lid with Lident s -> - Ident.find_name s (proj1 env) + Ident.find_name_with_nearly s (proj1 env) | Ldot(l, s) -> let (p, desc) = lookup_module_descr l env in begin match Lazy.force desc with diff --git a/typing/ident.ml b/typing/ident.ml index a30aa7a..8bbb395 100644 --- a/typing/ident.ml +++ b/typing/ident.ml @@ -56,6 +56,61 @@ let same i1 i2 = i1 = i2 then i1.stamp = i2.stamp else i2.stamp = 0 && i1.name = i2.name *) +(* does various heuristics to find spelling mistakes - algorithm from GNAT Ada compiler - Lots of code, but hopefully about as efficient as possible *) +let nearly_equal s i = + let is_digit c = c >= '0' && c <= '9' in + let rec tails_equal s1 i1 s2 i2 = i1 >= String.length s1 || (s1.[i1] = s2.[i2] && tails_equal s1 (i1+1) s2 (i2+1)) in + + let n1 = s and n2 = i.name in + let l1 = String.length n1 and l2 = String.length n2 in + if l1 = 0 then l2 = 0 (* both null -> equal *) + else if l2 = 0 then false (* one of n1 or n2 null -> not equal *) + else if n1.[0] != n2.[0] then false (* first characters don't match -> not *) + else if l1 < 3 && l2 < 3 then false (* short strings are all different *) + else if l1 = l2 then + (* look for single errors, transpositions *) + let rec find_diff c = + if c < (l1 - 1) then + if n1.[c] != n2.[c] then + (* mismatched digits -> not equal *) + if is_digit n1.[c] && is_digit n2.[c] then false + (* single error -> equal *) + else if n1.[c+1] = n2.[c+1] && tails_equal n1 (c+2) n2 (c+2) + then true + (* transposition -> equal *) + else if n1.[c] = n2.[c+1] && n1.[c+1] = n2.[c] && + tails_equal n1 (c+2) n2 (c+2) + then true + else false + else find_diff (c+1) + else (* at the end of the strings *) + if is_digit n1.[c] && is_digit n2.[c] + && n1.[c] != n2.[c] + then false + else true + in + find_diff 1 + else if l1 = l2 - 1 then (* short by one *) + let rec find_del c = + if c < l1 then + if n1.[c] != n2.[c] then + tails_equal n1 c n2 (c+1) + else find_del (c+1) + else true (* last character was deleted *) + in + find_del 1 + else if l1 = l2 + 1 then (* too long by one *) + let rec find_add c = + if c < l2 then + if n1.[c] != n2.[c] then + tails_equal n1 (c+1) n2 c + else find_add (c+1) + else true (* last character added *) + in + find_add 1 + else (* lengths totally different *) + false + let binding_time i = i.stamp let current_time() = !currentstamp @@ -97,6 +152,8 @@ and 'a data = let empty = Empty +exception Found_nearly of string list + (* Inline expansion of height for better speed * let height = function * Empty -> 0 @@ -182,3 +239,34 @@ let rec keys_aux stack accu = function keys_aux (l :: stack) (k.ident :: accu) r let keys tbl = keys_aux [] [] tbl + +let find_nearly_equal n tbl = +(* List.filter (nearly_equal name) (keys tbl) -- optimized for your enjoyment*) + let rec find_nearly_equal_aux stack accu = function + Empty -> + begin match stack with + [] -> accu + | a :: l -> find_nearly_equal_aux l accu a + end + | Node(l, k, r, _) -> + let accu' = + if nearly_equal n k.ident + then k.ident.name :: accu + else accu + in + find_nearly_equal_aux (l :: stack) accu' r + in + find_nearly_equal_aux [] [] tbl + +let find_name_with_nearly name tbl = + try find_name name tbl + with Not_found -> +(* prerr_string "FNE: "; prerr_endline name; *) + let nearlies = find_nearly_equal name tbl in +(* let rec pr_list to_str = function [] -> prerr_endline "Empty" | [a] -> prerr_endline (to_str a) | h :: t -> prerr_string (to_str h); prerr_string ", "; pr_list to_str t + in + prerr_string "nearlies: "; + pr_list (fun i -> i) nearlies; + prerr_string "whole table: "; + pr_list (fun i -> i.name) (keys tbl); *) + raise (Found_nearly nearlies) diff --git a/typing/ident.mli b/typing/ident.mli index 9f7372c..7ab9327 100644 --- a/typing/ident.mli +++ b/typing/ident.mli @@ -52,8 +52,12 @@ val print: Format.formatter -> t -> unit type 'a tbl (* Association tables from identifiers to type 'a. *) +exception Found_nearly of string list + val empty: 'a tbl val add: t -> 'a -> 'a tbl -> 'a tbl val find_same: t -> 'a tbl -> 'a val find_name: string -> 'a tbl -> 'a val keys: 'a tbl -> t list + +val find_name_with_nearly: string -> 'a tbl -> 'a diff --git a/typing/typecore.ml b/typing/typecore.ml index 691eb49..adff3ad 100644 --- a/typing/typecore.ml +++ b/typing/typecore.ml @@ -23,9 +23,9 @@ open Btype open Ctype type error = - Unbound_value of Longident.t - | Unbound_constructor of Longident.t - | Unbound_label of Longident.t + Unbound_value of Longident.t * string list + | Unbound_constructor of Longident.t * string list + | Unbound_label of Longident.t * string list | Polymorphic_label of Longident.t | Constructor_arity_mismatch of Longident.t * int * int | Label_mismatch of Longident.t * (type_expr * type_expr) list @@ -42,11 +42,11 @@ type error = | Bad_conversion of string * int * char | Undefined_method of type_expr * string | Undefined_inherited_method of string - | Unbound_class of Longident.t + | Unbound_class of Longident.t * string list | Virtual_class of Longident.t | Private_type of type_expr | Private_label of Longident.t * type_expr - | Unbound_instance_variable of string + | Unbound_instance_variable of string * string list | Instance_variable_not_mutable of string | Not_subtype of (type_expr * type_expr) list * (type_expr * type_expr) list | Outside_class @@ -276,7 +276,7 @@ let rec build_as_type env p = unify_pat env {p2 with pat_type = ty2} ty1; begin match path with None -> () | Some path -> - let td = try Env.find_type path env with Not_found -> assert false in + let td = try Env.find_type path env with Not_found | Ident.Found_nearly _ -> assert false in let params = List.map (fun _ -> newvar()) td.type_params in match expand_head env (newty (Tconstr (path, params, ref Mnil))) with {desc=Tvariant row} when static_row row -> @@ -291,7 +291,9 @@ let build_or_pat env loc lid = let path, decl = try Env.lookup_type lid env with Not_found -> - raise(Typetexp.Error(loc, Typetexp.Unbound_type_constructor lid)) + raise(Typetexp.Error(loc, Typetexp.Unbound_type_constructor (lid,[]))) + | Ident.Found_nearly l -> + raise(Typetexp.Error(loc, Typetexp.Unbound_type_constructor (lid,l))) in let tyl = List.map (fun _ -> newvar()) decl.type_params in let fields = @@ -400,7 +402,10 @@ let rec type_pat env sp = try Env.lookup_constructor lid env with Not_found -> - raise(Error(sp.ppat_loc, Unbound_constructor lid)) in + raise(Error(sp.ppat_loc, Unbound_constructor (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sp.ppat_loc, Unbound_constructor (lid,l))) + in let sargs = match sarg with None -> [] @@ -449,7 +454,10 @@ let rec type_pat env sp = try Env.lookup_label lid env with Not_found -> - raise(Error(sp.ppat_loc, Unbound_label lid)) in + raise(Error(sp.ppat_loc, Unbound_label (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sp.ppat_loc, Unbound_label (lid,l))) + in begin_def (); let (vars, ty_arg, ty_res) = instance_label false label in if vars = [] then end_def (); @@ -806,7 +814,7 @@ let rec approx_type env sty = if List.length ctl <> decl.type_arity then raise Not_found; let tyl = List.map (approx_type env) ctl in newconstr path tyl - with Not_found -> newvar () + with Not_found | Ident.Found_nearly _ -> newvar () end | _ -> newvar () @@ -923,7 +931,9 @@ let rec type_exp env sexp = exp_type = instance desc.val_type; exp_env = env } with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_value lid)) + raise(Error(sexp.pexp_loc, Unbound_value (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_value (lid,l))) end | Pexp_constant cst -> re { @@ -1021,7 +1031,10 @@ let rec type_exp env sexp = try Env.lookup_label lid env with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_label lid)) in + raise(Error(sexp.pexp_loc, Unbound_label (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_label (lid,l))) + in begin_def (); if !Clflags.principal then begin_def (); let (vars, ty_arg, ty_res) = instance_label true label in @@ -1098,7 +1111,10 @@ let rec type_exp env sexp = try Env.lookup_label lid env with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_label lid)) in + raise(Error(sexp.pexp_loc, Unbound_label (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_label (lid,l))) + in let (_, ty_arg, ty_res) = instance_label false label in unify_exp env arg ty_res; re { @@ -1112,7 +1128,10 @@ let rec type_exp env sexp = try Env.lookup_label lid env with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_label lid)) in + raise(Error(sexp.pexp_loc, Unbound_label (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_label (lid,l))) + in if label.lbl_mut = Immutable then raise(Error(sexp.pexp_loc, Label_not_mutable lid)); begin_def (); @@ -1332,7 +1351,9 @@ let rec type_exp env sexp = | Pexp_new cl -> let (cl_path, cl_decl) = try Env.lookup_class cl env with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_class cl)) + raise(Error(sexp.pexp_loc, Unbound_class (cl,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_class (cl,l))) in begin match cl_decl.cty_new with None -> @@ -1361,10 +1382,13 @@ let rec type_exp env sexp = | Val_ivar _ -> raise(Error(sexp.pexp_loc, Instance_variable_not_mutable lab)) | _ -> - raise(Error(sexp.pexp_loc, Unbound_instance_variable lab)) + raise(Error(sexp.pexp_loc, Unbound_instance_variable (lab,[]))) with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_instance_variable lab)) + raise(Error(sexp.pexp_loc, Unbound_instance_variable (lab,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_instance_variable (lab,l))) + end | Pexp_override lst -> let _ = @@ -1380,7 +1404,7 @@ let rec type_exp env sexp = try Env.lookup_value (Longident.Lident "selfpat-*") env, Env.lookup_value (Longident.Lident "self-*") env - with Not_found -> + with Not_found | Ident.Found_nearly _ -> raise(Error(sexp.pexp_loc, Outside_class)) with (_, {val_type = self_ty; val_kind = Val_self (_, vars, _, _)}), @@ -1391,7 +1415,9 @@ let rec type_exp env sexp = (Path.Pident id, type_expect env snewval (instance ty)) with Not_found -> - raise(Error(sexp.pexp_loc, Unbound_instance_variable lab)) + raise(Error(sexp.pexp_loc, Unbound_instance_variable (lab,[]))) + | Ident.Found_nearly l -> + raise(Error(sexp.pexp_loc, Unbound_instance_variable (lab,l))) end in let modifs = List.map type_override lst in @@ -1637,7 +1663,7 @@ and type_application env funct sargs = may_warn sarg0.pexp_loc (Warnings.Not_principal "commuting this argument"); (l', sarg0, sargs1 @ sargs2, more_sargs) - with Not_found -> + with Not_found | Ident.Found_nearly _ -> let (l', sarg0, sargs1, sargs2) = extract_label name more_sargs in if sargs1 <> [] || sargs <> [] then @@ -1707,7 +1733,9 @@ and type_construct env loc lid sarg explicit_arity ty_expected = try Env.lookup_constructor lid env with Not_found -> - raise(Error(loc, Unbound_constructor lid)) in + raise(Error(loc, Unbound_constructor (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(loc, Unbound_constructor (lid,l))) in let sargs = match sarg with None -> [] @@ -2020,12 +2048,18 @@ open Format open Printtyp let report_error ppf = function - | Unbound_value lid -> - fprintf ppf "Unbound value %a" longident lid - | Unbound_constructor lid -> + | Unbound_value (lid,[]) -> + fprintf ppf "Unbound value %a" longident lid + | Unbound_value (lid,corr::_) -> + fprintf ppf "Unbound value %a, possible misspelling of %s" longident lid corr + | Unbound_constructor (lid,[]) -> fprintf ppf "Unbound constructor %a" longident lid - | Unbound_label lid -> + | Unbound_constructor (lid,corr::_) -> + fprintf ppf "Unbound constructor %a, possible misspelling of %s" longident lid corr + | Unbound_label (lid,[]) -> fprintf ppf "Unbound record field label %a" longident lid + | Unbound_label (lid,corr::_) -> + fprintf ppf "Unbound record field label %a, possible misspelling of %s" longident lid corr | Polymorphic_label lid -> fprintf ppf "@[The record field label %a is polymorphic.@ %s@]" longident lid "You cannot instantiate it in a pattern." @@ -2100,13 +2134,17 @@ let report_error ppf = function It has no method %s@]" type_expr ty me | Undefined_inherited_method me -> fprintf ppf "This expression has no method %s" me - | Unbound_class cl -> + | Unbound_class (cl,[]) -> fprintf ppf "Unbound class %a" longident cl + | Unbound_class (cl,corr::_) -> + fprintf ppf "Unbound class %a, possible misspelling of %s" longident cl corr | Virtual_class cl -> fprintf ppf "One cannot create instances of the virtual class %a" longident cl - | Unbound_instance_variable v -> + | Unbound_instance_variable (v,[]) -> fprintf ppf "Unbound instance variable %s" v + | Unbound_instance_variable (v,corr::_) -> + fprintf ppf "Unbound instance variable %s, possible misspelling of %s" v corr | Instance_variable_not_mutable v -> fprintf ppf "The instance variable %s is not mutable" v | Not_subtype(tr1, tr2) -> diff --git a/typing/typecore.mli b/typing/typecore.mli index 24aea7d..171e96e 100644 --- a/typing/typecore.mli +++ b/typing/typecore.mli @@ -61,9 +61,9 @@ val force_delayed_checks: unit -> unit val self_coercion : (Path.t * Location.t list ref) list ref type error = - Unbound_value of Longident.t - | Unbound_constructor of Longident.t - | Unbound_label of Longident.t + Unbound_value of Longident.t * string list + | Unbound_constructor of Longident.t * string list + | Unbound_label of Longident.t * string list | Polymorphic_label of Longident.t | Constructor_arity_mismatch of Longident.t * int * int | Label_mismatch of Longident.t * (type_expr * type_expr) list @@ -80,11 +80,11 @@ type error = | Bad_conversion of string * int * char | Undefined_method of type_expr * string | Undefined_inherited_method of string - | Unbound_class of Longident.t + | Unbound_class of Longident.t * string list | Virtual_class of Longident.t | Private_type of type_expr | Private_label of Longident.t * type_expr - | Unbound_instance_variable of string + | Unbound_instance_variable of string * string list | Instance_variable_not_mutable of string | Not_subtype of (type_expr * type_expr) list * (type_expr * type_expr) list | Outside_class diff --git a/typing/typetexp.ml b/typing/typetexp.ml index 4f615ab..3d4f6cf 100644 --- a/typing/typetexp.ml +++ b/typing/typetexp.ml @@ -22,14 +22,14 @@ open Ctype exception Already_bound type error = - Unbound_type_variable of string - | Unbound_type_constructor of Longident.t + Unbound_type_variable of string * string list + | Unbound_type_constructor of Longident.t * string list | Unbound_type_constructor_2 of Path.t | Type_arity_mismatch of Longident.t * int * int | Bound_type_variable of string | Recursive_type - | Unbound_class of Longident.t - | Unbound_row_variable of Longident.t + | Unbound_class of Longident.t * string list + | Unbound_row_variable of Longident.t * string list | Type_mismatch of (type_expr * type_expr) list | Alias_type_mismatch of (type_expr * type_expr) list | Present_has_conjunction of string @@ -78,7 +78,7 @@ let type_variable loc name = try Tbl.find name !type_variables with Not_found -> - raise(Error(loc, Unbound_type_variable ("'" ^ name))) + raise(Error(loc, Unbound_type_variable (("'" ^ name),[]))) let wrap_method ty = match (Ctype.repr ty).desc with @@ -99,7 +99,7 @@ let rec transl_type env policy styp = Ptyp_any -> if policy = Univars then new_pre_univar () else if policy = Fixed then - raise (Error (styp.ptyp_loc, Unbound_type_variable "_")) + raise (Error (styp.ptyp_loc, Unbound_type_variable ("_",[]))) else newvar () | Ptyp_var name -> if name <> "" && name.[0] = '_' then @@ -125,7 +125,9 @@ let rec transl_type env policy styp = try Env.lookup_type lid env with Not_found -> - raise(Error(styp.ptyp_loc, Unbound_type_constructor lid)) in + raise(Error(styp.ptyp_loc, Unbound_type_constructor (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(styp.ptyp_loc, Unbound_type_constructor (lid,l))) in if List.length stl <> decl.type_arity then raise(Error(styp.ptyp_loc, Type_arity_mismatch(lid, decl.type_arity, List.length stl))); @@ -178,7 +180,9 @@ let rec transl_type env policy styp = let (path, decl) = Env.lookup_type lid2 env in (path, decl, false) with Not_found -> - raise(Error(styp.ptyp_loc, Unbound_class lid)) + raise(Error(styp.ptyp_loc, Unbound_class (lid,[]))) + | Ident.Found_nearly l -> + raise(Error(styp.ptyp_loc, Unbound_class (lid,l))) in if List.length stl <> decl.type_arity then raise(Error(styp.ptyp_loc, Type_arity_mismatch(lid, decl.type_arity, @@ -429,7 +433,7 @@ let globalize_used_variables env fixed = r := (loc, v, Tbl.find name !type_variables) :: !r with Not_found -> if fixed && (repr ty).desc = Tvar then - raise(Error(loc, Unbound_type_variable ("'"^name))); + raise(Error(loc, Unbound_type_variable (("'"^name),[]))); let v2 = new_global_var () in r := (loc, v, v2) :: !r; type_variables := Tbl.add name v2 !type_variables) @@ -494,10 +498,14 @@ open Format open Printtyp let report_error ppf = function - | Unbound_type_variable name -> + | Unbound_type_variable (name,[]) -> fprintf ppf "Unbound type parameter %s" name - | Unbound_type_constructor lid -> + | Unbound_type_variable (name,corr::_) -> + fprintf ppf "Unbound type parameter %s, possible misspelling of %s" name corr + | Unbound_type_constructor (lid,[]) -> fprintf ppf "Unbound type constructor %a" longident lid + | Unbound_type_constructor (lid,corr::_) -> + fprintf ppf "Unbound type constructor %a, possible misspelling of %s" longident lid corr | Unbound_type_constructor_2 p -> fprintf ppf "The type constructor@ %a@ is not yet completely defined" path p @@ -510,10 +518,14 @@ let report_error ppf = function fprintf ppf "Already bound type parameter '%s" name | Recursive_type -> fprintf ppf "This type is recursive" - | Unbound_class lid -> + | Unbound_class (lid,[]) -> fprintf ppf "Unbound class %a" longident lid - | Unbound_row_variable lid -> + | Unbound_class (lid,corr::_) -> + fprintf ppf "Unbound class %a, possible misspelling of %s" longident lid corr + | Unbound_row_variable (lid,[]) -> fprintf ppf "Unbound row variable in #%a" longident lid + | Unbound_row_variable (lid,corr::_) -> + fprintf ppf "Unbound row variable in #%a, possible misspelling of %s" longident lid corr | Type_mismatch trace -> Printtyp.unification_error true trace (function ppf -> diff --git a/typing/typetexp.mli b/typing/typetexp.mli index b7d3a55..ee47077 100644 --- a/typing/typetexp.mli +++ b/typing/typetexp.mli @@ -37,14 +37,14 @@ val widen: variable_context -> unit exception Already_bound type error = - Unbound_type_variable of string - | Unbound_type_constructor of Longident.t + Unbound_type_variable of string * string list + | Unbound_type_constructor of Longident.t * string list | Unbound_type_constructor_2 of Path.t | Type_arity_mismatch of Longident.t * int * int | Bound_type_variable of string | Recursive_type - | Unbound_class of Longident.t - | Unbound_row_variable of Longident.t + | Unbound_class of Longident.t * string list + | Unbound_row_variable of Longident.t * string list | Type_mismatch of (Types.type_expr * Types.type_expr) list | Alias_type_mismatch of (Types.type_expr * Types.type_expr) list | Present_has_conjunction of string --------------000809040309080205080408--