caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: Fabrice Le Fessant <Fabrice.Le_fessant@inria.fr>
To: caml-list@inria.fr
Subject: Re: [Caml-list] GC interface question
Date: Fri, 01 Jul 2011 15:37:00 +0200	[thread overview]
Message-ID: <4E0DCD7C.5010907@inria.fr> (raw)
In-Reply-To: <BANLkTimx1+O4cXEibBgyE86kbGo-gLUCZA@mail.gmail.com>

[-- Attachment #1: Type: text/plain, Size: 1438 bytes --]

Initialization to 0 for _varg is OK, of course.

What does camlidl_acquire_runtime do ? I couldn't find it in camlidl
sources. Is-it possible it could trigger some garbage collection ? Is
the field this->caml_object protected from a GC move during
camlidl_acquire_runtime() ?

Fabrice

On 07/01/2011 02:54 PM, Dmitry Bely wrote:
> On Fri, Jul 1, 2011 at 3:56 PM, Fabrice Le Fessant
> <Fabrice.Le_fessant@inria.fr> wrote:
>> I would not call camlidl_alloc_small() without first initializing
>> correctly _varg[1] to Val_unit.
> 
> Actually, it's initialized to zero. The full generated fragment:
> 
> HRESULT STDMETHODCALLTYPE camlidl_ppm_IConfigLoad_setLogger_callback(
> 	struct IConfigLoad * this,
> 	/* in */ void *log)
> {
>   value _varg[2] = { 0, 0, };
>   value _vres;
>   HRESULT _res;
>   (*camlidl_acquire_runtime)();
>   Begin_roots_block(_varg, 2)
>     _varg[0] = ((struct camlidl_intf *) this)->caml_object;
>     _varg[1] = camlidl_alloc_small(1, Abstract_tag);
>     Field(_varg[1], 0) = (value) log;
>   End_roots()
>   _vres = caml_callbackN_exn(caml_get_public_method(_varg[0],
> Val_int(1007700946)), 2, _varg);
>   if (Is_exception_result(_vres)) {
>     _res = camlidl_result_exception(NULL, Extract_exception(_vres));
>   } else {
>     _res = S_OK;
>   }
>   (*camlidl_release_runtime)();
>   return _res;
> }
> 
> It was Xavier Leroy who initially decided to use zeroes, so I think it's OK?
> 
> - Dmitry Bely
> 

[-- Attachment #2: fabrice_le_fessant.vcf --]
[-- Type: text/x-vcard, Size: 380 bytes --]

begin:vcard
fn:Fabrice LE FESSANT
n:LE FESSANT;Fabrice
org:INRIA Saclay -- Ile-de-France;P2P & OCaml
adr;quoted-printable:;;Parc Orsay Universit=C3=A9 ;Orsay CEDEX;;91893;France
email;internet:fabrice.le_fessant@inria.fr
title;quoted-printable:Charg=C3=A9 de Recherche
tel;work:+33 1 74 85 42 14
tel;fax:+33 1 74 85 42 49 
url:http://fabrice.lefessant.net/
version:2.1
end:vcard


  reply	other threads:[~2011-07-01 13:37 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-07-01  9:09 Dmitry Bely
2011-07-01 11:49 ` Damien Doligez
2011-07-01 12:06   ` Dmitry Bely
2011-07-01 11:56 ` Fabrice Le Fessant
2011-07-01 12:54   ` Dmitry Bely
2011-07-01 13:37     ` Fabrice Le Fessant [this message]
2011-07-01 14:44       ` Dmitry Bely
     [not found]       ` <801099288.1616121.1309531501115.JavaMail.root@zmbs4.inria.fr>
2011-07-01 15:09         ` Fabrice Le Fessant
2011-07-01 15:41           ` Dmitry Bely

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4E0DCD7C.5010907@inria.fr \
    --to=fabrice.le_fessant@inria.fr \
    --cc=caml-list@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).