From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail4-relais-sop.national.inria.fr (mail4-relais-sop.national.inria.fr [192.134.164.105]) by walapai.inria.fr (8.13.6/8.13.6) with ESMTP id pBIHNhY9000876 for ; Sun, 18 Dec 2011 18:23:43 +0100 X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtEDAJYg7k6K54gDgWdsb2JhbABDhQymTSIBARYmJYFyAQEDAiNVARALGgIFFgQHAgIJAwIBAgFFBg0BBwIQh2gGpUKRB4EviT+BFgSUfoVOjGE X-IronPort-AV: E=Sophos;i="4.71,372,1320620400"; d="scan'208";a="123824776" Received: from rouge.crans.org ([138.231.136.3]) by mail4-smtp-sop.national.inria.fr with ESMTP/TLS/ADH-AES256-SHA; 18 Dec 2011 18:23:37 +0100 Received: from localhost (localhost.crans.org [127.0.0.1]) by rouge.crans.org (Postfix) with ESMTP id 39DE980E4; Sun, 18 Dec 2011 18:23:37 +0100 (CET) X-Virus-Scanned: Debian amavisd-new at crans.org Received: from rouge.crans.org ([10.231.136.3]) by localhost (rouge.crans.org [10.231.136.3]) (amavisd-new, port 10024) with LMTP id ZBwwxUkWlLvE; Sun, 18 Dec 2011 18:23:37 +0100 (CET) Received: from [192.168.39.1] (fbx.up7.fr [81.56.96.177]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (No client certificate requested) by rouge.crans.org (Postfix) with ESMTPSA id EA7B98073; Sun, 18 Dec 2011 18:23:36 +0100 (CET) Message-ID: <4EEE2197.6010305@glondu.net> Date: Sun, 18 Dec 2011 18:23:35 +0100 From: =?UTF-8?B?U3TDqXBoYW5lIEdsb25kdQ==?= User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US; rv:1.9.2.24) Gecko/20111114 Icedove/3.1.16 MIME-Version: 1.0 To: Benedikt Meurer CC: caml users , Mehdi Dogguy References: <55531934-37A5-4CC5-AB67-20CE4CCE8269@googlemail.com> <4EE37070.4010702@inria.fr> <4EE63E88.40805@glondu.net> In-Reply-To: X-Enigmail-Version: 1.1.2 OpenPGP: id=49881AD3 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from quoted-printable to 8bit by walapai.inria.fr id pBIHNhY9000876 Subject: Re: [Caml-list] Re: New experimental ARM backend [was: OCaml maintenance status / community fork (again)] Le 18/12/2011 14:08, Benedikt Meurer a écrit : > While we are at it: Can we have this patch applied to the Debian OCaml package? This would (a) get OCaml running native on armhf and (b) get some testing / feedback for the patch. Your patch is way too monolithic. You cannot seriously expect anyone to apply it as it is. The git repository looks more sensible, but the history is kind of messy (e.g. one big initial import removing/duplicating arm.S, then later merge). My advice is to maintain a clean patch series (e.g. one patch for each new feature you advertise, or whatever logical split you see fit), in addition to publishing your working git repository. Please read: http://halobates.de/on-submitting-patches.pdf An acceptable workflow for me would be two git branches, one with your ongoing development, and another one starting from 3.12.1 release with a cleaned up and detailed history. Both would continuously have the same tree, but the cleaned-up one would be rebased if needed to keep the history clean. Then each commit of the cleaned-up branch would be reviewed and discussed separately as a candidate patch for upstream inclusion. All this can be done efficiently with git. What tests did you perform, by the way? Cheers, -- Stéphane