[Caml-list] OASIS and conditional compilation

[Caml-list] OASIS and conditional compilation

[Dario Teixeira]

Hi,

I've come across a perplexing issue with OASIS.  I'm not sure if this is
just a bug or if I'm trying to push the tool beyond its design parameters.

PG'OCaml can be compiled against either Batteries or ExtLib (the latter
mostly for legacy compatibility). To allow the harmonious coexistence of
the two options in the same system, the build system should allow for
the compilation of one or the two versions of the library side by side.
In OASIS-speak (I'm using version 0.3):

  Flag "batteries"
    Description: Link PG'OCaml against Batteries
    Default: true

  Flag "extlib"
    Description: Link PG'OCaml against ExtLib
    Default: true

  Library "pgocaml_batteries"
    Build$:               flag(batteries)
    Install$:             flag(batteries)
    Path:                 src
    Modules:              PGOCaml, PGOCaml_generic
    BuildDepends:         unix, calendar, csv, pcre, batteries, camlp4.macro
    ByteOpt+:             -ppopt -DUSE_BATTERIES
    NativeOpt+:           -ppopt -DUSE_BATTERIES
    FindlibContainers:    pgocaml
    Findlibname:          batteries
    XMETARequires:        unix, calendar, csv, pcre, batteries

  Library "pgocaml_extlib"
    Build$:               flag(extlib)
    Install$:             flag(extlib)
    Path:                 src
    Modules:              PGOCaml, PGOCaml_generic
    BuildDepends:         unix, calendar, csv, pcre, extlib, camlp4.macro
    FindlibContainers:    pgocaml
    Findlibname:          extlib
    XMETARequires:        unix, calendar, csv, pcre, extlib

Note that the major difference is that "-ppopt -DUSE_BATTERIES" must be
passed to Camlp4 only when compiling the Batteries version.  The problem
is that it's *always* passed, even if the "batteries" flag is disabled
by passing "--disable-batteries" to the configure script.

Did I misinterpret something crucial about OASIS, or is this indeed a bug?

Thanks in advance!
Best regards,
Dario Teixeira

P.S. The full OASIS spec file can be viewed at this location:
     https://forge.ocamlcore.org/scm/viewvc.php/branches/oasification/_oasis?revision=157&root=pgocaml

Re: [Caml-list] OASIS and conditional compilation

[Wojciech Meyer]

Hi,

Dario Teixeira <darioteixeira@yahoo.com> writes:

> Note that the major difference is that "-ppopt -DUSE_BATTERIES" must be
> passed to Camlp4 only when compiling the Batteries version.  The problem
> is that it's *always* passed, even if the "batteries" flag is disabled
> by passing "--disable-batteries" to the configure script.

Probably it's a leftover setup.data, that contains these flags.

Just remove setup.data and regenerate files,

-- 
Wojciech Meyer
http://danmey.org

Re: [Caml-list] OASIS and conditional compilation

[Dario Teixeira]

Hi,



> Probably it's a leftover setup.data, that contains these flags.
> 
> Just remove setup.data and regenerate files,

Thanks for the reply.

No, that's not it.  The problem persists even after a complete
cleanup and regeneration.

Best regards,
Dario

Re: [Caml-list] OASIS and conditional compilation

[Török Edwin]

On 12/15/2012 06:02 PM, Dario Teixeira wrote:
> Hi,
> 
> I've come across a perplexing issue with OASIS.  I'm not sure if this is
> just a bug or if I'm trying to push the tool beyond its design parameters.
> 
> PG'OCaml can be compiled against either Batteries or ExtLib (the latter
> mostly for legacy compatibility). To allow the harmonious coexistence of
> the two options in the same system, the build system should allow for
> the compilation of one or the two versions of the library side by side.
> In OASIS-speak (I'm using version 0.3):
> 
>   Flag "batteries"
>     Description: Link PG'OCaml against Batteries
>     Default: true
> 
>   Flag "extlib"
>     Description: Link PG'OCaml against ExtLib
>     Default: true
> 
>   Library "pgocaml_batteries"
>     Build$:               flag(batteries)
>     Install$:             flag(batteries)
>     Path:                 src
>     Modules:              PGOCaml, PGOCaml_generic
>     BuildDepends:         unix, calendar, csv, pcre, batteries, camlp4.macro
>     ByteOpt+:             -ppopt -DUSE_BATTERIES
>     NativeOpt+:           -ppopt -DUSE_BATTERIES

I think it simply adds these to the tags file, and since its the same module name
in both cases it'll get built with those flags even when batteries is disabled.

--Edwin

Re: [Caml-list] OASIS and conditional compilation

[Sylvain Le Gall]

[-- Attachment #1: Type: text/plain, Size: 897 bytes --]

Hi,

Can you send me  the generated _tags.

The problem is probably in the fact that the same file are compiled twice
and are applied exactly the same set of options in ocamlbuild.

Note that in general ocaml doesn't support well conditional compilation....

Regards
Sylvain
Le 15 déc. 2012 17:17, "Wojciech Meyer" <wojciech.meyer@gmail.com> a écrit :

> Hi,
>
> Dario Teixeira <darioteixeira@yahoo.com> writes:
>
> > Note that the major difference is that "-ppopt -DUSE_BATTERIES" must be
> > passed to Camlp4 only when compiling the Batteries version.  The problem
> > is that it's *always* passed, even if the "batteries" flag is disabled
> > by passing "--disable-batteries" to the configure script.
>
> Probably it's a leftover setup.data, that contains these flags.
>
> Just remove setup.data and regenerate files,
>
> --
> Wojciech Meyer
> http://danmey.org
>

[-- Attachment #2: Type: text/html, Size: 1395 bytes --]

Re: [Caml-list] OASIS and conditional compilation

[Dario Teixeira]

Hi,

>Can you send me  the generated _tags.

>The problem is probably in the fact that the same file are compiled twice and are applied exactly the same set of options in ocamlbuild.
>Note that in general ocaml doesn't support well conditional compilation....
>Regards
>Sylvain


Thanks for the reply.

The _tags file is here:
https://forge.ocamlcore.org/scm/viewvc.php/branches/oasification/_tags?revision=155&root=pgocaml

But anyway, it seems my original intention may not be feasible.
Consequently, I'm tempted to simply drop the support for ExtLib
in newer releases of PG'OCaml.  This will simplify the build system
tremendously.  Moreover, since modern packaging tools like OPAM
allow pinning a package to an older version, legacy users won't
be forced to upgrade.

Best regards,
Dario Teixeira

Re: [Caml-list] OASIS and conditional compilation

[Dario Teixeira]

Hi,

> I think it simply adds these to the tags file, and since its the same module name

> in both cases it'll get built with those flags even when batteries is  disabled.
 
Thanks for the reply.  Yes, my build needs would require OASIS to essentially
perform two separate builds, each with its own _tags file.  Alternatively, I would
need to duplicate and rename the source files, or use some file inclusion mechanism.
Either way would further complicate the build process, though...

Cheers,
Dario Teixeira

Re: [Caml-list] OASIS and conditional compilation

[Jacques-Pascal Deplaix]

On 12/15/2012 05:02 PM, Dario Teixeira wrote:
> Hi,
>
> I've come across a perplexing issue with OASIS.  I'm not sure if this is
> just a bug or if I'm trying to push the tool beyond its design parameters.
>
> PG'OCaml can be compiled against either Batteries or ExtLib (the latter
> mostly for legacy compatibility). To allow the harmonious coexistence of
> the two options in the same system, the build system should allow for
> the compilation of one or the two versions of the library side by side.
> In OASIS-speak (I'm using version 0.3):
>
>   Flag "batteries"
>     Description: Link PG'OCaml against Batteries
>     Default: true
>
>   Flag "extlib"
>     Description: Link PG'OCaml against ExtLib
>     Default: true
>
>   Library "pgocaml_batteries"
>     Build$:               flag(batteries)
>     Install$:             flag(batteries)
>     Path:                 src
>     Modules:              PGOCaml, PGOCaml_generic
>     BuildDepends:         unix, calendar, csv, pcre, batteries, camlp4.macro
>     ByteOpt+:             -ppopt -DUSE_BATTERIES
>     NativeOpt+:           -ppopt -DUSE_BATTERIES
>     FindlibContainers:    pgocaml
>     Findlibname:          batteries
>     XMETARequires:        unix, calendar, csv, pcre, batteries
>
>   Library "pgocaml_extlib"
>     Build$:               flag(extlib)
>     Install$:             flag(extlib)
>     Path:                 src
>     Modules:              PGOCaml, PGOCaml_generic
>     BuildDepends:         unix, calendar, csv, pcre, extlib, camlp4.macro
>     FindlibContainers:    pgocaml
>     Findlibname:          extlib
>     XMETARequires:        unix, calendar, csv, pcre, extlib
>
> Note that the major difference is that "-ppopt -DUSE_BATTERIES" must be
> passed to Camlp4 only when compiling the Batteries version.  The problem
> is that it's *always* passed, even if the "batteries" flag is disabled
> by passing "--disable-batteries" to the configure script.
>
> Did I misinterpret something crucial about OASIS, or is this indeed a bug?
>
> Thanks in advance!
> Best regards,
> Dario Teixeira
>
> P.S. The full OASIS spec file can be viewed at this location:
>      https://forge.ocamlcore.org/scm/viewvc.php/branches/oasification/_oasis?revision=157&root=pgocaml
>
Hi,

There is already a bug report for this:
https://forge.ocamlcore.org/tracker/index.php?func=detail&aid=1234&group_id=54&atid=291