caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: William Smith <bills@emu-bark.com>
To: Caml-list <caml-list@inria.fr>
Subject: [Caml-list] modified error messages for ocamlc
Date: Sun, 14 Apr 2013 11:20:08 -0400	[thread overview]
Message-ID: <516AC928.9030400@emu-bark.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 961 bytes --]

Hi,

I've made a change to my copy of ocamlc to modify error messages when 
they cover multiple lines.

For example, for the following code, the modified error message includes 
the line number and character offset of then end of the message instead 
of just the length of the message.

Would there be any interest in me making the change everywhere and 
submitting it as a patch?  I see about a dozen places in the source of 
the various tools where the change would be possible.   One concern I 
have is that it might break automated test scripts.

Bill Smith

let x = 1 in
(match x with
1 -> true
);;
--------
New:
File "multilineError.ml", line 2, character 0-line 4, character 1:
Warning 8: this pattern-matching is not exhaustive.
Here is an example of a value that is not matched:
0
--------
Old:
File "multilineError.ml", line 2, characters 0-28:
Warning 8: this pattern-matching is not exhaustive.
Here is an example of a value that is not matched:
0


[-- Attachment #2: Type: text/html, Size: 1707 bytes --]

             reply	other threads:[~2013-04-14 15:20 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-04-14 15:20 William Smith [this message]
2013-04-14 16:25 ` Daniel Bünzli
2013-04-14 17:06   ` Gabriel Scherer
2013-04-14 17:57     ` Daniel Bünzli
2013-04-14 18:19       ` Jonathan Protzenko
2013-04-14 19:18         ` Daniel Bünzli
2013-04-14 20:01           ` [Caml-list] " Christopher Zimmermann
2013-04-15 15:37   ` [Caml-list] " Jacques Le Normand
2013-04-15  6:26 ` Raphaël Proust
2013-04-16  0:32 ` [Caml-list] " Stefan Monnier
2013-04-18 16:40 [Caml-list] " William Smith
2013-04-21  7:37 ` Gabriel Scherer
2013-04-21 10:53   ` Daniel Bünzli
2013-04-21 11:28     ` Gabriel Scherer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=516AC928.9030400@emu-bark.com \
    --to=bills@emu-bark.com \
    --cc=caml-list@inria.fr \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).