From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 10B537F890 for ; Thu, 27 Mar 2014 13:23:43 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of francois.bobot@cea.fr) identity=pra; client-ip=132.168.224.8; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="francois.bobot@cea.fr"; x-sender="francois.bobot@cea.fr"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of francois.bobot@cea.fr designates 132.168.224.8 as permitted sender) identity=mailfrom; client-ip=132.168.224.8; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="francois.bobot@cea.fr"; x-sender="francois.bobot@cea.fr"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@oxalide-out.extra.cea.fr) identity=helo; client-ip=132.168.224.8; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="francois.bobot@cea.fr"; x-sender="postmaster@oxalide-out.extra.cea.fr"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AvQBAOUXNFOEqOAInGdsb2JhbABZg0HDNoEaFg4BAQEBAQYNCQkUKIIlAQEBBDIBOwoRCxgJFg8JAwIBAgFFEwgCh3UN0GITBI56FoQiBJ8ajxY X-IPAS-Result: AvQBAOUXNFOEqOAInGdsb2JhbABZg0HDNoEaFg4BAQEBAQYNCQkUKIIlAQEBBDIBOwoRCxgJFg8JAwIBAgFFEwgCh3UN0GITBI56FoQiBJ8ajxY X-IronPort-AV: E=Sophos;i="4.97,742,1389740400"; d="scan'208";a="64998927" Received: from oxalide-out.extra.cea.fr ([132.168.224.8]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 27 Mar 2014 13:23:42 +0100 Received: from pisaure.intra.cea.fr (pisaure.intra.cea.fr [132.166.88.21]) by oxalide.extra.cea.fr (8.14.2/8.14.2/CEAnet-Internet-out-2.3) with ESMTP id s2RCNg3V001604 for ; Thu, 27 Mar 2014 13:23:42 +0100 Received: from pisaure.intra.cea.fr (localhost [127.0.0.1]) by localhost (Postfix) with SMTP id 854632048D6 for ; Thu, 27 Mar 2014 13:25:19 +0100 (CET) Received: from muguet2.intra.cea.fr (muguet2.intra.cea.fr [132.166.192.7]) by pisaure.intra.cea.fr (Postfix) with ESMTP id 73DE0204721 for ; Thu, 27 Mar 2014 13:25:19 +0100 (CET) Received: from [10.8.32.80] (is222783.intra.cea.fr [10.8.32.80]) by muguet2.intra.cea.fr (8.13.8/8.13.8/CEAnet-Intranet-out-1.2) with ESMTP id s2RCNfwe016632 for ; Thu, 27 Mar 2014 13:23:41 +0100 Message-ID: <5334184D.1070901@cea.fr> Date: Thu, 27 Mar 2014 13:23:41 +0100 From: =?ISO-8859-1?Q?Fran=E7ois_Bobot?= User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20131103 Icedove/17.0.10 MIME-Version: 1.0 To: caml-list@inria.fr References: <20140321222842.GA10374@annexia.org> <4C341FFE-FDF2-4EA3-B056-D4F658641E4C@math.nagoya-u.ac.jp> <20140322071508.GB10374@annexia.org> <20140325154958.GA20202@frosties> <20140325161648.GG10374@annexia.org> <20140327093420.GA19960@frosties> In-Reply-To: <20140327093420.GA19960@frosties> Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 8bit Subject: Re: [Caml-list] Trivial compiler patches On 27/03/2014 10:34, Goswin von Brederlow wrote: > On Tue, Mar 25, 2014 at 04:16:48PM +0000, Richard W.M. Jones wrote: >> I have to say that a number of projects I've been involved with have >> rejected github pulls as a method of working on patches. I think the >> main reasons are: >> >> - A mailing list allows you to use your regular editor when >> commenting. >> >> - A mailing list provides a text-based, open archive of historical >> discussions of patches. > > And makes it hard to follow or later trace the developement due to the > amount of intermixed mails. > > Rebasing a patch set for every change also makes it hard to follow > since rebase destroys history. So far revision control systems lack > that extra dimension needed to track the developement of a patch set > over time. One way is to not rebase during the review process, add the modification on top and rebase at the end of the review process. The autosquashing feature of git makes that quite simple, "git commit [--fixup|--squash]", since that allows to record which commit is fixed. You can look at https://github.com/ocaml/ocaml/pull/22 for an idea (the commit are prefixed with "fixup!"). -- François