From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Francois Berenger <francois.berenger@inria.fr>
Cc: caml-list@inria.fr
Subject: Re: [Caml-list] Clarification for the configuration of comparison functions
Date: Thu, 11 Sep 2014 10:10:53 +0200 [thread overview]
Message-ID: <5411590D.2050508@users.sourceforge.net> (raw)
In-Reply-To: <5411533C.6060802@inria.fr>
>> Would you like to suggest any changes for the affected member functions?
>> https://github.com/elfring/OTCL/blob/51c5a0ff8b487cddc9318cac63c59bd5c23ae547/omap.ml#L121
>
> Are you sure about the compare on line 66?
No! - I do not feel familiar enough with the programming language "OCaml" so far
to decide changes here on my own.
...
let rec add ~cmp x data = function
...
let c = compare x v in
...
That is one of the places where I have found a code smell. It is an
implementation detail for which I published the bug report "Comparison function
application" and started a corresponding clarification try on IRC and the
mailing list.
https://github.com/elfring/OTCL/issues/4
Should the shown function name be replaced by a call for "~cmp"?
Regards,
Markus
next prev parent reply other threads:[~2014-09-11 8:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 8:56 SF Markus Elfring
2014-09-10 11:27 ` Gerd Stolpmann
2014-09-10 12:07 ` Yotam Barnoy
2014-09-10 12:26 ` Gerd Stolpmann
2014-09-10 12:37 ` Adrien Nader
2014-09-10 12:38 ` Yotam Barnoy
2014-09-10 12:41 ` Pippijn van Steenhoven
2014-09-10 12:51 ` Gerd Stolpmann
2014-09-10 12:56 ` Ben Millwood
[not found] ` <CAADdkeKquMWyHjQhgd2SOZYr9DaS2E+i3Ug5=xb25BK-+n16eQ@mail.gmail.com>
2014-09-10 12:44 ` Gerd Stolpmann
2014-09-10 20:56 ` SF Markus Elfring
2014-09-11 7:46 ` Francois Berenger
2014-09-11 8:10 ` SF Markus Elfring [this message]
2014-09-11 8:24 ` Francois Berenger
2014-09-11 8:33 ` SF Markus Elfring
2014-09-11 8:39 ` Frédéric Bour
2014-10-06 20:50 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5411590D.2050508@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=caml-list@inria.fr \
--cc=francois.berenger@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).