From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 09D377F75C for ; Thu, 11 Sep 2014 10:10:57 +0200 (CEST) Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of elfring@users.sourceforge.net) identity=pra; client-ip=212.227.17.11; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="elfring@users.sourceforge.net"; x-sender="elfring@users.sourceforge.net"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of elfring@users.sourceforge.net) identity=mailfrom; client-ip=212.227.17.11; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="elfring@users.sourceforge.net"; x-sender="elfring@users.sourceforge.net"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@mout.web.de) identity=helo; client-ip=212.227.17.11; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="elfring@users.sourceforge.net"; x-sender="postmaster@mout.web.de"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AlEBALRXEVTU4xELnGdsb2JhbABgg2BXyDSHDT4BgQoWEAEBAQEBBg0JCRQqhAQBAQMBHVEKARALIRYPCQMCAQIBRQYNAQcBAYg2DAmsApNkARMEj00HhEwBBJV5hwOHKxMFkVlqBYJKAQEB X-IPAS-Result: AlEBALRXEVTU4xELnGdsb2JhbABgg2BXyDSHDT4BgQoWEAEBAQEBBg0JCRQqhAQBAQMBHVEKARALIRYPCQMCAQIBRQYNAQcBAYg2DAmsApNkARMEj00HhEwBBJV5hwOHKxMFkVlqBYJKAQEB X-IronPort-AV: E=Sophos;i="5.04,504,1406584800"; d="scan'208";a="78530076" Received: from mout.web.de ([212.227.17.11]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/DHE-RSA-AES256-SHA; 11 Sep 2014 10:10:56 +0200 Received: from [192.168.1.215] ([78.49.18.115]) by smtp.web.de (mrweb101) with ESMTPSA (Nemesis) id 0MEEa4-1XYbBO0hZI-00FWgo; Thu, 11 Sep 2014 10:10:54 +0200 Message-ID: <5411590D.2050508@users.sourceforge.net> Date: Thu, 11 Sep 2014 10:10:53 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0 MIME-Version: 1.0 To: Francois Berenger CC: caml-list@inria.fr References: <54101221.3010304@users.sourceforge.net> <1410348425.3003.11.camel@thinkpad> <5410BB11.2070406@users.sourceforge.net> <5411533C.6060802@inria.fr> In-Reply-To: <5411533C.6060802@inria.fr> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:UaUIRLCq8Evzf6BtahFPFM9RHVCsxm/nYz9LFp+vdZQWgS4q0eE bdx1L3mMgE1JzTA5gVZMtHa7YaR3KJcHJdLW5GpBC4jlI0ufewRHOFVGDYiLH9Fk4SfLV3R DtuOUYE4/C8EUlFtFOhW+81SWP/TrQtSUYPOrkZC9hEJbjyHyNtoe51UjHnNMY2DBe8gbJZ lkP+3OC0VX83SSKKe4YKg== X-UI-Out-Filterresults: notjunk:1; Subject: Re: [Caml-list] Clarification for the configuration of comparison functions >> Would you like to suggest any changes for the affected member functions? >> https://github.com/elfring/OTCL/blob/51c5a0ff8b487cddc9318cac63c59bd5c23ae547/omap.ml#L121 > > Are you sure about the compare on line 66? No! - I do not feel familiar enough with the programming language "OCaml" so far to decide changes here on my own. ... let rec add ~cmp x data = function ... let c = compare x v in ... That is one of the places where I have found a code smell. It is an implementation detail for which I published the bug report "Comparison function application" and started a corresponding clarification try on IRC and the mailing list. https://github.com/elfring/OTCL/issues/4 Should the shown function name be replaced by a call for "~cmp"? Regards, Markus