From: "Frédéric Bour" <frederic.bour@lakaban.net>
To: caml-list@inria.fr
Subject: Re: [Caml-list] Clarification for the configuration of comparison functions
Date: Thu, 11 Sep 2014 10:39:00 +0200 [thread overview]
Message-ID: <54115FA4.3050904@lakaban.net> (raw)
In-Reply-To: <54115E56.5080208@users.sourceforge.net>
The cmp value is threaded but never used. It is a mistake.
The cmp value should either be used instead of compare or completely
removed (but that's not what was intended).
"Luckily", the mistake is made at all comparison places in this file, so
the resulting map still behaves like a map, just not with the expected
ordering.
On 11/09/2014 10:33, SF Markus Elfring wrote:
>>> Should the shown function name be replaced by a call for "~cmp"?
>> Probably, but I am also not familiar with this code base.
> Can any other OCaml software designer give a definitive advice here besides the
> original developers?
>
> Regards,
> Markus
>
next prev parent reply other threads:[~2014-09-11 8:40 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-10 8:56 SF Markus Elfring
2014-09-10 11:27 ` Gerd Stolpmann
2014-09-10 12:07 ` Yotam Barnoy
2014-09-10 12:26 ` Gerd Stolpmann
2014-09-10 12:37 ` Adrien Nader
2014-09-10 12:38 ` Yotam Barnoy
2014-09-10 12:41 ` Pippijn van Steenhoven
2014-09-10 12:51 ` Gerd Stolpmann
2014-09-10 12:56 ` Ben Millwood
[not found] ` <CAADdkeKquMWyHjQhgd2SOZYr9DaS2E+i3Ug5=xb25BK-+n16eQ@mail.gmail.com>
2014-09-10 12:44 ` Gerd Stolpmann
2014-09-10 20:56 ` SF Markus Elfring
2014-09-11 7:46 ` Francois Berenger
2014-09-11 8:10 ` SF Markus Elfring
2014-09-11 8:24 ` Francois Berenger
2014-09-11 8:33 ` SF Markus Elfring
2014-09-11 8:39 ` Frédéric Bour [this message]
2014-10-06 20:50 ` SF Markus Elfring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=54115FA4.3050904@lakaban.net \
--to=frederic.bour@lakaban.net \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).