From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <frederic.bour@lakaban.net>
X-Original-To: caml-list@sympa.inria.fr
Delivered-To: caml-list@sympa.inria.fr
Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83])
	by sympa.inria.fr (Postfix) with ESMTPS id 3DF677FACC
	for <caml-list@sympa.inria.fr>; Thu, 11 Sep 2014 10:40:07 +0200 (CEST)
Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender
  authenticity information available from domain of
  frederic.bour@lakaban.net) identity=pra;
  client-ip=213.251.185.180;
  receiver=mail2-smtp-roc.national.inria.fr;
  envelope-from="frederic.bour@lakaban.net";
  x-sender="frederic.bour@lakaban.net";
  x-conformance=sidf_compatible
Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of
  frederic.bour@lakaban.net designates 213.251.185.180 as
  permitted sender) identity=mailfrom;
  client-ip=213.251.185.180;
  receiver=mail2-smtp-roc.national.inria.fr;
  envelope-from="frederic.bour@lakaban.net";
  x-sender="frederic.bour@lakaban.net";
  x-conformance=sidf_compatible; x-record-type="v=spf1"
Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender
  authenticity information available from domain of
  postmaster@mail.lakaban.net) identity=helo;
  client-ip=213.251.185.180;
  receiver=mail2-smtp-roc.national.inria.fr;
  envelope-from="frederic.bour@lakaban.net";
  x-sender="postmaster@mail.lakaban.net";
  x-conformance=sidf_compatible
X-IronPort-Anti-Spam-Filtered: true
X-IronPort-Anti-Spam-Result: AjcIANheEVTV+7m0/2dsb2JhbABghDe4OJMthBAKAYEgeIQEAQEEHRsIAQE2Ag8LGAkWDwkDAgECAUUTCAEBiEKpJ4JlgxUBBZBMAREGj1QWhDYBkk6RdY12g2Nqgk8BAQE
X-IPAS-Result: AjcIANheEVTV+7m0/2dsb2JhbABghDe4OJMthBAKAYEgeIQEAQEEHRsIAQE2Ag8LGAkWDwkDAgECAUUTCAEBiEKpJ4JlgxUBBZBMAREGj1QWhDYBkk6RdY12g2Nqgk8BAQE
X-IronPort-AV: E=Sophos;i="5.04,504,1406584800"; 
   d="scan'208";a="94095986"
Received: from pepper.lakaban.net (HELO mail.lakaban.net) ([213.251.185.180])
  by mail2-smtp-roc.national.inria.fr with ESMTP; 11 Sep 2014 10:40:06 +0200
Received: from [192.168.1.17] (mtg91-4-78-206-197-34.fbx.proxad.net [78.206.197.34])
	(Authenticated sender: defre@ygg-drasil.fr)
	by mail.lakaban.net (Postfix) with ESMTPSA id 2FAAC27ED64
	for <caml-list@inria.fr>; Thu, 11 Sep 2014 08:26:34 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=lakaban.net;
	s=default; t=1410423994;
	bh=hKTm5MGgWxn9OAAhSgPsBAKb4SInjC0x+DsvPRjLuCg=;
	h=Date:From:To:Subject:References:In-Reply-To:From;
	b=pu/LPgChmhx3E6n54GiNmtX+AuW9cfgb0H6hkdkuXTGv0g7i+YXvDeDuWYKkYXS4+
	 7Lrq5OIK2YNPVuVwPhClac7kutzT/xP5oFuDs9zd4+JMliSULs55xc2dd+YPdWG+mA
	 xCI4YYGpZPwZAJyFwfqFjd/nyQzNTGRgCpATKfFU=
Message-ID: <54115FA4.3050904@lakaban.net>
Date: Thu, 11 Sep 2014 10:39:00 +0200
From: =?ISO-8859-15?Q?Fr=E9d=E9ric_Bour?= <frederic.bour@lakaban.net>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.1.0
MIME-Version: 1.0
To: caml-list@inria.fr
References: <54101221.3010304@users.sourceforge.net> <1410348425.3003.11.camel@thinkpad> <5410BB11.2070406@users.sourceforge.net> <5411533C.6060802@inria.fr> <5411590D.2050508@users.sourceforge.net> <54115C33.4050408@inria.fr> <54115E56.5080208@users.sourceforge.net>
In-Reply-To: <54115E56.5080208@users.sourceforge.net>
Content-Type: text/plain; charset=iso-8859-15; format=flowed
Content-Transfer-Encoding: 7bit
Subject: Re: [Caml-list] Clarification for the configuration of comparison
 functions

The cmp value is threaded but never used. It is a mistake.
The cmp value should either be used instead of compare or completely 
removed (but that's not what was intended).

"Luckily", the mistake is made at all comparison places in this file, so 
the resulting map still behaves like a map, just not with the expected 
ordering.

On 11/09/2014 10:33, SF Markus Elfring wrote:
>>> Should the shown function name be replaced by a call for "~cmp"?
>> Probably, but I am also not familiar with this code base.
> Can any other OCaml software designer give a definitive advice here besides the
> original developers?
>
> Regards,
> Markus
>