From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id 5C5A37F86A for ; Thu, 6 Mar 2014 10:48:55 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of daniel.buenzli@erratique.ch) identity=pra; client-ip=74.55.86.74; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="daniel.buenzli@erratique.ch"; x-sender="daniel.buenzli@erratique.ch"; x-conformance=sidf_compatible Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of daniel.buenzli@erratique.ch) identity=mailfrom; client-ip=74.55.86.74; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="daniel.buenzli@erratique.ch"; x-sender="daniel.buenzli@erratique.ch"; x-conformance=sidf_compatible Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@smtp.webfaction.com) identity=helo; client-ip=74.55.86.74; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="daniel.buenzli@erratique.ch"; x-sender="postmaster@smtp.webfaction.com"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AjcWAC9DGFNKN1ZKlWdsb2JhbABaDoMzgj2BIL4XgTEOAQEBAQcNCQkSKoIlAQEBBCNWEAsYAgImAgJHEAYbh3EECa4goG0TBIEpjFcBARwzB4JvNYEUBJ5wF4QPBIo8QIFw X-IPAS-Result: AjcWAC9DGFNKN1ZKlWdsb2JhbABaDoMzgj2BIL4XgTEOAQEBAQcNCQkSKoIlAQEBBCNWEAsYAgImAgJHEAYbh3EECa4goG0TBIEpjFcBARwzB4JvNYEUBJ5wF4QPBIo8QIFw X-IronPort-AV: E=Sophos;i="4.97,598,1389740400"; d="scan'208";a="61529147" Received: from mail6.webfaction.com (HELO smtp.webfaction.com) ([74.55.86.74]) by mail2-smtp-roc.national.inria.fr with ESMTP; 06 Mar 2014 10:48:54 +0100 Received: from [172.20.10.2] (56-227.197-178.cust.bluewin.ch [178.197.227.56]) by smtp.webfaction.com (Postfix) with ESMTP id 6D12559A2860; Thu, 6 Mar 2014 09:48:52 +0000 (UTC) Date: Thu, 6 Mar 2014 10:48:48 +0100 From: =?utf-8?Q?Daniel_B=C3=BCnzli?= To: Christophe Troestler Cc: caml-list@inria.fr Message-ID: <554B600BA124496EA06BE4CD03D89A9A@erratique.ch> In-Reply-To: <20140305.211003.1668243541649395876.Christophe.Troestler@umons.ac.be> References: <000b01cf3885$6f1ef7a0$4d5ce6e0$@metastack.com> <3A42ACD2FA7345B29C464538724DECD5@erratique.ch> <20140305.211003.1668243541649395876.Christophe.Troestler@umons.ac.be> X-Mailer: sparrow 1.6.4 (build 1178) MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline Subject: Re: [Caml-list] Project hosting for new OCaml projects Le mercredi, 5 mars 2014 =C3=A0 21:10, Christophe Troestler a =C3=A9crit : > On Wed, 5 Mar 2014 21:00:40 +0100, Daniel B=C3=BCnzli wrote: > >=20=20 > > [...] the pull request mechanism is broken (e.g. it completely > > muddies history with useless commits) [...] >=20=20 > P.S. You can always merge using the command line=C2=B9 which does not have > that problem. >=20=20 > =C2=B9 The URL is provided in the mail Github send you so you do not even > have to go to the Github site. Yes, that's what I do. But that's not the only thing that is broken about p= ull requests.=20=20 I think the mechanism (each pull request is a branch on which you push comm= its) makes it too easy to get non-logical, incoherent commits. There's a pu= ll request, you ask for corrections. The contributor instead of correcting,= amending its commit and force pushing to the branch just adds commits to t= he branch, which results in a sequence of commits that may not make much se= nse on your main branch (even worse it may put your project in an intermedi= ate bad state on certain checkouts which is bad for git bisecting). Of cour= se you can always ask people to do the right thing, but I think the actual = contribution process should make you do the right thing.=20=20 An example here (not to be mean to this fine individual trying to contribut= e to the opam repository): https://github.com/ocaml/opam-repository/pull/1756 The second commit will make no sense in the history of the opam-repository.= =20=20 Best, Daniel