From: David MENTRE <dmentre@linux-france.org>
To: caml-list@inria.fr
Subject: Re: [Caml-list] [ANN] Bisect_ppx 1.0.0 – Modernized code coverage for OCaml
Date: Wed, 10 Feb 2016 17:46:05 +0100 [thread overview]
Message-ID: <56BB694D.1030306@linux-france.org> (raw)
In-Reply-To: <1FE0ECD4-BBD6-48DA-95BD-BB240E07484C@yahoo.com>
Hello,
Interesting tool.
Le 10/02/2016 16:33, Anton Bachin a écrit :
> You can see a live coverage report here:
>
> http://rleonid.github.io/bisect_ppx/coverage/
I quickly looked at the report output (so I might have not understood
the working of your tool), but in
https://rleonid.github.io/bisect_ppx/coverage/file0004.html , why:
* l. 107, 'let try_finally x f h =' is not green. The function seems
to be called as l. 108 is green. (Same remark for all defined functions)
https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L107
* l. 110, 'f x' is not green? 'f' seems to be called if the previous
"try" is green.
https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L110
* l. 139, '^ ".cmp"' is not green? Once again, this expression seems
to executed by your tests.
https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L139
* l. 168 and l. 169, 'else' is never coloured? For me, it should be
green l. 168 and red l. 170.
https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L168
Overall, I would expect all code lines to be either green, red or
yellow, not without colour (except for comments and type and exception
definitions).
Sincerely yours,
david
next prev parent reply other threads:[~2016-02-10 16:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-02-10 15:33 Anton Bachin
2016-02-10 16:46 ` David MENTRE [this message]
2016-02-10 19:27 ` Anton Bachin
2016-02-12 6:44 ` David MENTRÉ
2016-02-12 9:18 ` Anton Bachin
2016-02-10 19:00 ` Gerd Stolpmann
2016-02-10 19:23 ` Gabriel Scherer
2016-02-10 19:33 ` Anton Bachin
2016-02-10 21:48 ` Gerd Stolpmann
2016-02-10 21:49 ` Alain Frisch
2016-02-11 1:16 ` Anton Bachin
2016-02-11 10:42 ` Gerd Stolpmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=56BB694D.1030306@linux-france.org \
--to=dmentre@linux-france.org \
--cc=caml-list@inria.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).