From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail3-relais-sop.national.inria.fr (mail3-relais-sop.national.inria.fr [192.134.164.104]) by sympa.inria.fr (Postfix) with ESMTPS id 158717FED0 for ; Wed, 10 Feb 2016 17:46:35 +0100 (CET) IronPort-PHdr: 9a23:R4OaVRES7caJI7qONRBQip1GYnF86YWxBRYc798ds5kLTJ75o82wAkXT6L1XgUPTWs2DsrQf27WQ6PqrCTJIyK3CmU5BWaQEbwUCh8QSkl5oK+++Imq/EsTXaTcnFt9JTl5v8iLzG0FUHMHjew+a+SXqvnYsExnyfTB4Ov7yUtaLyZ/niKbpodaDPU1hv3mUX/BbFF2OtwLft80b08NJC50a7V/3mEZOYPlc3mhyJFiezF7W78a0+4N/oWwL46pyv50IbaKvdK09SflcDS86G2Ez/szi8xfZHiWV4X5JfmwIkxYAJiXj0CvXFsP9tyb8qvBw8C2bO9DmCL4uUDKp4uFsUhC+23RPDCIw7GyC0p84t6lcuh/0/xE= Authentication-Results: mail3-smtp-sop.national.inria.fr; spf=None smtp.pra=dmentre@linux-france.org; spf=None smtp.mailfrom=dmentre@linux-france.org; spf=None smtp.helo=postmaster@tempura.bentobako.org Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of dmentre@linux-france.org) identity=pra; client-ip=94.23.39.64; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="dmentre@linux-france.org"; x-sender="dmentre@linux-france.org"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of dmentre@linux-france.org) identity=mailfrom; client-ip=94.23.39.64; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="dmentre@linux-france.org"; x-sender="dmentre@linux-france.org"; x-conformance=sidf_compatible Received-SPF: None (mail3-smtp-sop.national.inria.fr: no sender authenticity information available from domain of postmaster@tempura.bentobako.org) identity=helo; client-ip=94.23.39.64; receiver=mail3-smtp-sop.national.inria.fr; envelope-from="dmentre@linux-france.org"; x-sender="postmaster@tempura.bentobako.org"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: A0AhBQAZabtW/0AnF15egzpSbYhcsxUhhWwCgTw8EAEBAQEBAQEBgQmCLYIVAQEEMgEFOwURCyEWDwkDAgECAQ04EwgBAYgbAQnAJwEBCAEBAQEchhKEN4R+g24Fkm6EChOFOYlhSoZ8hVJEiimDUjcrg2VpAYhSAQEB X-IPAS-Result: A0AhBQAZabtW/0AnF15egzpSbYhcsxUhhWwCgTw8EAEBAQEBAQEBgQmCLYIVAQEEMgEFOwURCyEWDwkDAgECAQ04EwgBAYgbAQnAJwEBCAEBAQEchhKEN4R+g24Fkm6EChOFOYlhSoZ8hVJEiimDUjcrg2VpAYhSAQEB X-IronPort-AV: E=Sophos;i="5.22,426,1449529200"; d="scan'208";a="164227233" Received: from tempura.bentobako.org ([94.23.39.64]) by mail3-smtp-sop.national.inria.fr with ESMTP/TLS/ADH-AES256-GCM-SHA384; 10 Feb 2016 17:46:07 +0100 Received: from [10.226.206.83] (unknown [95.128.149.202]) by tempura.bentobako.org (Postfix) with ESMTPSA id 2F7E830AC for ; Wed, 10 Feb 2016 17:46:06 +0100 (CET) To: caml-list@inria.fr References: <1FE0ECD4-BBD6-48DA-95BD-BB240E07484C@yahoo.com> From: David MENTRE Message-ID: <56BB694D.1030306@linux-france.org> Date: Wed, 10 Feb 2016 17:46:05 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:38.0) Gecko/20100101 Thunderbird/38.5.1 MIME-Version: 1.0 In-Reply-To: <1FE0ECD4-BBD6-48DA-95BD-BB240E07484C@yahoo.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 8bit Subject: Re: [Caml-list] =?UTF-8?Q?=5BANN=5D_Bisect=5Fppx_1=2E0=2E0_?= =?UTF-8?Q?=E2=80=93_Modernized_code_coverage_for_OCaml?= Hello, Interesting tool. Le 10/02/2016 16:33, Anton Bachin a écrit : > You can see a live coverage report here: > > http://rleonid.github.io/bisect_ppx/coverage/ I quickly looked at the report output (so I might have not understood the working of your tool), but in https://rleonid.github.io/bisect_ppx/coverage/file0004.html , why: * l. 107, 'let try_finally x f h =' is not green. The function seems to be called as l. 108 is green. (Same remark for all defined functions) https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L107 * l. 110, 'f x' is not green? 'f' seems to be called if the previous "try" is green. https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L110 * l. 139, '^ ".cmp"' is not green? Once again, this expression seems to executed by your tests. https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L139 * l. 168 and l. 169, 'else' is never coloured? For me, it should be green l. 168 and red l. 170. https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L168 Overall, I would expect all code lines to be either green, red or yellow, not without colour (except for comments and type and exception definitions). Sincerely yours, david