Re: [Caml-list] [ANN] Bisect_ppx 1.0.0 – Modernized code coverage for OCaml

["David MENTRÉ" <dmentre@linux-france.org>]

Hello Anton,

Thank you for your detailed explanations.

Le 2016-02-10 20:27, Anton Bachin a écrit :
>> * l. 110, 'f x' is not green? 'f' seems to be called if the previous "try" is green.
>> >   https://rleonid.github.io/bisect_ppx/coverage/file0004.html#L110
> The “f x” in try is evaluated if and only if the whole try-expression is
> evaluated – unless, perhaps, the *implementation* of exception handling can
> cause a memory or stack overflow exception to occur between these two points –
> can someone knowledgeable comment? However, assuming my previous statement is
> correct, it’s not necessary to have a mark in both places. We chose to put the
> mark on “try” because it is technically very slightly easier to do so. However,
> we could be convinced to move it to the expression instead.

Well I would have marked the "f x". My reasoning is simple, if f is
executed, it should be green. And f is more important than try regarding
coverage.


>> > Overall, I would expect all code lines to be either green, red or yellow, not without colour (except for comments and type and exception definitions).
> Bisect_ppx colors expressions and not lines – the line colors just indicate
> whether there is a colored expression on each line. So, yes, while many lines in
> expressions should be colored, some won’t be – for example, from above, lines
> containing only delimiters such as “then”, “else”, and “end”.

Two remarks:

 * If expressions are marked (which I suspected), then the HTML output
should color at expression granularity level and not line granularity
level. Therefore you would have only green or red and never orange[1]
(which would be simpler and clearer);

 * You could do some post-processing to look for such keywords as
“then”, “else”, and “end” and color them accordingly. It might be more a
hack than a clean approach, but I think it would make the output more
readable.

All that said, I'm not using your tool (for now), so I would understand
that you not take my remarks into account. ;-)

Best regards,
david

[1] Or maybe only in the summary on the left side of file display.