caml-list - the Caml user's mailing list
 help / color / mirror / Atom feed
From: Malcolm Matalka <mmatalka@gmail.com>
To: Marek Kubica <marek@xivilization.net>
Cc: Caml List <caml-list@inria.fr>
Subject: Re: [Caml-list] [ANN] slacko-0.9.0
Date: Sat, 04 Oct 2014 13:36:43 +0000	[thread overview]
Message-ID: <87a95cklck.fsf@gmail.com> (raw)
In-Reply-To: <20141004150511.7e8de126@xivilization.net> (Marek Kubica's message of "Sat, 4 Oct 2014 15:05:11 +0200")

I would either change the 'apierror' type to normal variants, or spread
out the apierror to multiple types.  Can every API function really
return every one of those errors?  The value of polymorphic variants is
they are module, and you can share the constructors across types.

I would also structure the API calls in terms of the Result.t type in
Core.  Right now success is part of the error type.

My 2 cents.

Marek Kubica <marek@xivilization.net> writes:

> Hello,
>
> I'd like to announce the first public release of Slacko, a REST API
> binding to Slack <https://slack.com/>. I'm looking for input on it, so
> I can publish a 1.0 soon.
>
> The source code can be found on GitHub,
> <https://github.com/Leonidas-from-XIV/slacko> and it is already
> uploaded in OPAM <http://opam.ocaml.org/packages/slacko/slacko.0.9.0/>.
>
> More information can be found on my blog,
> <http://xivilization.net/~marek/blog/2014/10/01/introducing-slacko/>.
>
> Hope it will prove useful to someone.
>
> regards,
> Marek

  reply	other threads:[~2014-10-04 13:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-10-04 13:05 Marek Kubica
2014-10-04 13:36 ` Malcolm Matalka [this message]
2014-10-04 14:54   ` Marek Kubica
2014-10-04 15:23     ` Gabriel Scherer
2014-10-04 22:43       ` Marek Kubica
2014-10-05  2:23         ` Jacques Garrigue

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87a95cklck.fsf@gmail.com \
    --to=mmatalka@gmail.com \
    --cc=caml-list@inria.fr \
    --cc=marek@xivilization.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).