[Caml-list] Segfault with open GADTs

[Caml-list] Segfault with open GADTs

[Andre Nathan]

[-- Attachment #1.1: Type: text/plain, Size: 884 bytes --]

Hi

I'm trying to use extensible variants to allow users to extend a type
from my library, which is a GADT, but it's resulting in a segfault when
the program is executed. I've managed to reproduce the issue with this code:

  module M0 = struct
    type 'a t = ..
    type 'a t +=
      | I : int -> int t
      | S : string -> string t
      | P : 'a t * 'b t -> ('a * 'b) t

    let rec to_string : type a. a t -> string = function
      | I i -> "I:" ^ string_of_int i
      | S s -> "S:" ^ s
      | P (x, y) -> to_string x ^ to_string y
  end

  module M1 = struct
    include M0
    type 'a t += T : 'a t -> 'a t

    let to_string = function
      | T t -> to_string t
      | x -> to_string x
  end

  let () =
    print_endline @@ M1.to_string (M1.P (M1.T (M1.I 42), M1.S "foo"))


Is this sort of thing supposed to work?

Thanks,
Andre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Caml-list] Segfault with open GADTs

[Pierrick Couderc]

[-- Attachment #1: Type: text/plain, Size: 1358 bytes --]

Hi,

It is supposed to work, but it seems thepattern-matching compiler does not
detect that M0.to_string is non exhaustive, thus it does not add a
Match_Failure in case the variant is unknown. With extensible variants, a
pattern matching is only exhaustive if you provide a wildcard or a variable
for variants added afterwards.

You maybe should report it on the bug tracker!

2016-10-18 14:47 GMT+02:00 Andre Nathan <andre@digirati.com.br>:

> Hi
>
> I'm trying to use extensible variants to allow users to extend a type
> from my library, which is a GADT, but it's resulting in a segfault when
> the program is executed. I've managed to reproduce the issue with this
> code:
>
>   module M0 = struct
>     type 'a t = ..
>     type 'a t +=
>       | I : int -> int t
>       | S : string -> string t
>       | P : 'a t * 'b t -> ('a * 'b) t
>
>     let rec to_string : type a. a t -> string = function
>       | I i -> "I:" ^ string_of_int i
>       | S s -> "S:" ^ s
>       | P (x, y) -> to_string x ^ to_string y
>   end
>
>   module M1 = struct
>     include M0
>     type 'a t += T : 'a t -> 'a t
>
>     let to_string = function
>       | T t -> to_string t
>       | x -> to_string x
>   end
>
>   let () =
>     print_endline @@ M1.to_string (M1.P (M1.T (M1.I 42), M1.S "foo"))
>
>
> Is this sort of thing supposed to work?
>
> Thanks,
> Andre
>
>

[-- Attachment #2: Type: text/html, Size: 1974 bytes --]

Re: [Caml-list] Segfault with open GADTs

[Andre Nathan]

[-- Attachment #1.1: Type: text/plain, Size: 780 bytes --]

On 10/18/2016 11:10 AM, Pierrick Couderc wrote:
> Hi,
> 
> It is supposed to work, but it seems thepattern-matching compiler does
> not detect that M0.to_string is non exhaustive, thus it does not add a
> Match_Failure in case the variant is unknown. With extensible variants,
> a pattern matching is only exhaustive if you provide a wildcard or a
> variable for variants added afterwards. 


Indeed, if I add a catch-all branch in M0.to_string then the code in
that branch is run, with no segfault.

But I guess my original idea of extending the type doesn't really work
as I hoped, since with nested expressions like that, I'd need to find a
way for M0.to_string to call back M1.to_string when a `T` is found.

Back to the drawing board...

Thanks,
Andre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Caml-list] Segfault with open GADTs

[Goswin von Brederlow]

On Tue, Oct 18, 2016 at 11:52:40AM -0200, Andre Nathan wrote:
> On 10/18/2016 11:10 AM, Pierrick Couderc wrote:
> > Hi,
> > 
> > It is supposed to work, but it seems thepattern-matching compiler does
> > not detect that M0.to_string is non exhaustive, thus it does not add a
> > Match_Failure in case the variant is unknown. With extensible variants,
> > a pattern matching is only exhaustive if you provide a wildcard or a
> > variable for variants added afterwards. 
> 
> 
> Indeed, if I add a catch-all branch in M0.to_string then the code in
> that branch is run, with no segfault.
> 
> But I guess my original idea of extending the type doesn't really work
> as I hoped, since with nested expressions like that, I'd need to find a
> way for M0.to_string to call back M1.to_string when a `T` is found.
> 
> Back to the drawing board...
> 
> Thanks,
> Andre

You can pass along the outermost to_string to all to_string
functions so they can restart from the outside when they recurse.

MfG
	Goswin

Re: [Caml-list] Segfault with open GADTs

[Andre Nathan]

[-- Attachment #1.1: Type: text/plain, Size: 810 bytes --]

On 10/18/2016 12:21 PM, Goswin von Brederlow wrote:
> You can pass along the outermost to_string to all to_string
> functions so they can restart from the outside when they recurse.

Yep :) For the record, I got it working like this:

In M0:

  let assert_false _ = assert false
  type f = { f : 'a. 'a t -> string }

  let rec to_string
      : type a b. ?f:f -> a t -> string
      = fun ?(f = { f = assert_false }) e -> match e with
      | I i -> "I:" ^ string_of_int i
      | S s -> "S:" ^ s
      | P (x, y) -> to_string ~f x ^ to_string ~f y
      | e -> f.f e

In M1:

    let rec to_string' : type a. a t -> string = function
      | T t -> to_string ~f:{ f = to_string' } t
      | x -> to_string ~f:{ f = to_string' } x

    let to_string = to_string'

Cheers,
Andre


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 473 bytes --]

Re: [Caml-list] Segfault with open GADTs

[Jeremy Yallop]

On 18 October 2016 at 13:47, Andre Nathan <andre@digirati.com.br> wrote:
> I'm trying to use extensible variants to allow users to extend a type
> from my library, which is a GADT, but it's resulting in a segfault when
> the program is executed. I've managed to reproduce the issue with this code:

It looks like an instance of this bug:

   http://caml.inria.fr/mantis/view.php?id=7330