* [Caml-list] With String.sub I need to catch "Bytes.sub" exception
@ 2014-09-13 22:47 Oliver Bandel
2014-09-13 22:53 ` Benjamin Greenman
0 siblings, 1 reply; 5+ messages in thread
From: Oliver Bandel @ 2014-09-13 22:47 UTC (permalink / raw)
To: caml-list
Hello,
is this a known bug?
Needed to change code from
with Invalid_argument("Strings.sub")
to
with Invalid_argument("Bytes.sub")
The code now looks like this and then works again:
try
if parser_url_len > 0 && parser_url = String.sub
url 0 parser_url_len then parser_name else aux tl
with Invalid_argument("Bytes.sub") -> aux tl (*
this happens if url is shorter than parser_url *)
Ciao,
Oliver
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Caml-list] With String.sub I need to catch "Bytes.sub" exception
2014-09-13 22:47 [Caml-list] With String.sub I need to catch "Bytes.sub" exception Oliver Bandel
@ 2014-09-13 22:53 ` Benjamin Greenman
2014-09-14 9:14 ` Gabriel Scherer
0 siblings, 1 reply; 5+ messages in thread
From: Benjamin Greenman @ 2014-09-13 22:53 UTC (permalink / raw)
To: Oliver Bandel; +Cc: OCaml mailing-list
[-- Attachment #1: Type: text/plain, Size: 986 bytes --]
Why do you match on the error string? String.sub is only documented to
raise "Invalid_argument _".
http://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
On Sat, Sep 13, 2014 at 6:47 PM, Oliver Bandel <oliver@first.in-berlin.de>
wrote:
> Hello,
>
> is this a known bug?
>
> Needed to change code from
>
> with Invalid_argument("Strings.sub")
> to
> with Invalid_argument("Bytes.sub")
>
> The code now looks like this and then works again:
>
>
> try
> if parser_url_len > 0 && parser_url = String.sub url 0
> parser_url_len then parser_name else aux tl
> with Invalid_argument("Bytes.sub") -> aux tl (* this
> happens if url is shorter than parser_url *)
>
>
> Ciao,
> Oliver
>
>
> --
> Caml-list mailing list. Subscription management and archives:
> https://sympa.inria.fr/sympa/arc/caml-list
> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
> Bug reports: http://caml.inria.fr/bin/caml-bugs
>
[-- Attachment #2: Type: text/html, Size: 1868 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Caml-list] With String.sub I need to catch "Bytes.sub" exception
2014-09-13 22:53 ` Benjamin Greenman
@ 2014-09-14 9:14 ` Gabriel Scherer
2014-09-14 15:18 ` Oliver Bandel
2014-09-14 15:19 ` Oliver Bandel
0 siblings, 2 replies; 5+ messages in thread
From: Gabriel Scherer @ 2014-09-14 9:14 UTC (permalink / raw)
To: Benjamin Greenman; +Cc: Oliver Bandel, OCaml mailing-list
[-- Attachment #1: Type: text/plain, Size: 1347 bytes --]
Even if it's not technically a regression against the specification as per
Benjamin's message above, breaking working code is still not very good.
Could you please report this on the OCaml bugtracker?
http://caml.inria.fr/mantis/
On Sun, Sep 14, 2014 at 12:53 AM, Benjamin Greenman <blg59@cornell.edu>
wrote:
> Why do you match on the error string? String.sub is only documented to
> raise "Invalid_argument _".
>
> http://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
>
> On Sat, Sep 13, 2014 at 6:47 PM, Oliver Bandel <oliver@first.in-berlin.de>
> wrote:
>
>> Hello,
>>
>> is this a known bug?
>>
>> Needed to change code from
>>
>> with Invalid_argument("Strings.sub")
>> to
>> with Invalid_argument("Bytes.sub")
>>
>> The code now looks like this and then works again:
>>
>>
>> try
>> if parser_url_len > 0 && parser_url = String.sub url
>> 0 parser_url_len then parser_name else aux tl
>> with Invalid_argument("Bytes.sub") -> aux tl (* this
>> happens if url is shorter than parser_url *)
>>
>>
>> Ciao,
>> Oliver
>>
>>
>> --
>> Caml-list mailing list. Subscription management and archives:
>> https://sympa.inria.fr/sympa/arc/caml-list
>> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
>> Bug reports: http://caml.inria.fr/bin/caml-bugs
>>
>
>
[-- Attachment #2: Type: text/html, Size: 2600 bytes --]
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Caml-list] With String.sub I need to catch "Bytes.sub" exception
2014-09-14 9:14 ` Gabriel Scherer
@ 2014-09-14 15:18 ` Oliver Bandel
2014-09-14 15:19 ` Oliver Bandel
1 sibling, 0 replies; 5+ messages in thread
From: Oliver Bandel @ 2014-09-14 15:18 UTC (permalink / raw)
To: Gabriel Scherer; +Cc: Benjamin Greenman, OCaml mailing-list
Issue-Id: #0006557
Zitat von Gabriel Scherer <gabriel.scherer@gmail.com> (Sun, 14 Sep
2014 11:14:22 +0200)
> Even if it's not technically a regression against the specification as per
> Benjamin's message above, breaking working code is still not very good.
> Could you please report this on the OCaml bugtracker?
>
> http://caml.inria.fr/mantis/
>
> On Sun, Sep 14, 2014 at 12:53 AM, Benjamin Greenman <blg59@cornell.edu>
> wrote:
>
>> Why do you match on the error string? String.sub is only documented to
>> raise "Invalid_argument _".
>>
>> http://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
>>
>> On Sat, Sep 13, 2014 at 6:47 PM, Oliver Bandel <oliver@first.in-berlin.de>
>> wrote:
>>
>>> Hello,
>>>
>>> is this a known bug?
>>>
>>> Needed to change code from
>>>
>>> with Invalid_argument("Strings.sub")
>>> to
>>> with Invalid_argument("Bytes.sub")
>>>
>>> The code now looks like this and then works again:
>>>
>>>
>>> try
>>> if parser_url_len > 0 && parser_url = String.sub url
>>> 0 parser_url_len then parser_name else aux tl
>>> with Invalid_argument("Bytes.sub") -> aux tl (* this
>>> happens if url is shorter than parser_url *)
>>>
>>>
>>> Ciao,
>>> Oliver
>>>
>>>
>>> --
>>> Caml-list mailing list. Subscription management and archives:
>>> https://sympa.inria.fr/sympa/arc/caml-list
>>> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
>>> Bug reports: http://caml.inria.fr/bin/caml-bugs
>>>
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [Caml-list] With String.sub I need to catch "Bytes.sub" exception
2014-09-14 9:14 ` Gabriel Scherer
2014-09-14 15:18 ` Oliver Bandel
@ 2014-09-14 15:19 ` Oliver Bandel
1 sibling, 0 replies; 5+ messages in thread
From: Oliver Bandel @ 2014-09-14 15:19 UTC (permalink / raw)
To: Gabriel Scherer; +Cc: Benjamin Greenman, OCaml mailing-list
Also it's strange to get Messages that indicate error-reason in the
wrong place.
Ciao,
Oliver
Zitat von Gabriel Scherer <gabriel.scherer@gmail.com> (Sun, 14 Sep
2014 11:14:22 +0200)
> Even if it's not technically a regression against the specification as per
> Benjamin's message above, breaking working code is still not very good.
> Could you please report this on the OCaml bugtracker?
>
> http://caml.inria.fr/mantis/
>
> On Sun, Sep 14, 2014 at 12:53 AM, Benjamin Greenman <blg59@cornell.edu>
> wrote:
>
>> Why do you match on the error string? String.sub is only documented to
>> raise "Invalid_argument _".
>>
>> http://caml.inria.fr/pub/docs/manual-ocaml/libref/String.html
>>
>> On Sat, Sep 13, 2014 at 6:47 PM, Oliver Bandel <oliver@first.in-berlin.de>
>> wrote:
>>
>>> Hello,
>>>
>>> is this a known bug?
>>>
>>> Needed to change code from
>>>
>>> with Invalid_argument("Strings.sub")
>>> to
>>> with Invalid_argument("Bytes.sub")
>>>
>>> The code now looks like this and then works again:
>>>
>>>
>>> try
>>> if parser_url_len > 0 && parser_url = String.sub url
>>> 0 parser_url_len then parser_name else aux tl
>>> with Invalid_argument("Bytes.sub") -> aux tl (* this
>>> happens if url is shorter than parser_url *)
>>>
>>>
>>> Ciao,
>>> Oliver
>>>
>>>
>>> --
>>> Caml-list mailing list. Subscription management and archives:
>>> https://sympa.inria.fr/sympa/arc/caml-list
>>> Beginner's list: http://groups.yahoo.com/group/ocaml_beginners
>>> Bug reports: http://caml.inria.fr/bin/caml-bugs
>>>
>>
>>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-09-14 15:19 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-09-13 22:47 [Caml-list] With String.sub I need to catch "Bytes.sub" exception Oliver Bandel
2014-09-13 22:53 ` Benjamin Greenman
2014-09-14 9:14 ` Gabriel Scherer
2014-09-14 15:18 ` Oliver Bandel
2014-09-14 15:19 ` Oliver Bandel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).