From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Original-To: caml-list@sympa.inria.fr Delivered-To: caml-list@sympa.inria.fr Received: from mail2-relais-roc.national.inria.fr (mail2-relais-roc.national.inria.fr [192.134.164.83]) by sympa.inria.fr (Postfix) with ESMTPS id D80DA7F890 for ; Tue, 25 Mar 2014 22:34:33 +0100 (CET) Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of yotambarnoy@gmail.com) identity=pra; client-ip=209.85.216.182; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="yotambarnoy@gmail.com"; x-conformance=sidf_compatible Received-SPF: Pass (mail2-smtp-roc.national.inria.fr: domain of yotambarnoy@gmail.com designates 209.85.216.182 as permitted sender) identity=mailfrom; client-ip=209.85.216.182; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="yotambarnoy@gmail.com"; x-conformance=sidf_compatible; x-record-type="v=spf1" Received-SPF: None (mail2-smtp-roc.national.inria.fr: no sender authenticity information available from domain of postmaster@mail-qc0-f182.google.com) identity=helo; client-ip=209.85.216.182; receiver=mail2-smtp-roc.national.inria.fr; envelope-from="yotambarnoy@gmail.com"; x-sender="postmaster@mail-qc0-f182.google.com"; x-conformance=sidf_compatible X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: AtMBAAn2MVPRVdi2lGdsb2JhbABZg0FXuXiBP4c1gRUIFg4BAQEBBwsLCRIqgiUBAQEDAQEBAT0BBxQSCwEDAQsGBQsNFRkhAQEEAQwBBQEcBhMIDIYJgUcBAwkIDaExjF+DDluVfAoZJw1khjcRAQUMjEYcgR4RAUwEBwqELgSUYYEVaoFtgTKLNoNbGCmDHoFaIYEsCReBGQ X-IPAS-Result: AtMBAAn2MVPRVdi2lGdsb2JhbABZg0FXuXiBP4c1gRUIFg4BAQEBBwsLCRIqgiUBAQEDAQEBAT0BBxQSCwEDAQsGBQsNFRkhAQEEAQwBBQEcBhMIDIYJgUcBAwkIDaExjF+DDluVfAoZJw1khjcRAQUMjEYcgR4RAUwEBwqELgSUYYEVaoFtgTKLNoNbGCmDHoFaIYEsCReBGQ X-IronPort-AV: E=Sophos;i="4.97,730,1389740400"; d="scan'208";a="64726865" Received: from mail-qc0-f182.google.com ([209.85.216.182]) by mail2-smtp-roc.national.inria.fr with ESMTP/TLS/RC4-SHA; 25 Mar 2014 22:34:32 +0100 Received: by mail-qc0-f182.google.com with SMTP id e16so1508814qcx.41 for ; Tue, 25 Mar 2014 14:34:31 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc:content-type; bh=g4gDa3r/vBQql0qaUJ6VkoIjUIAvsZ0YEXclODzCM1Y=; b=a9QUm2JQhzGzgAL2wxWHfaI/u41jY3OAgG3ukFXB4g13TOv5N7y4c6jRkOZ8vEJrHG ZP6iUMrfuws0KpiuBuigcgd+C2kADUnVOaoy8pIATClu/Nx0t84XDuMuxXmTGPb9ldAN KHp7sunr8YzdR0KK2k6lyhOtKwk3NkFbVn+Z173KRbTxIWvttartTXHoIfcXvY5LUXyP erz/EZZNtfjsGgJsZG4ZHqhYIn493i4wqJ6G48jVoTHOOkUj5RsqonDe/5az9qw62wCy xCWwmnLJHY57led6f9ejbUzV8avyL1fqjIKTaWptESTN4vpAmL9L0yTwgbs9WUdLJYlw yWIw== X-Received: by 10.224.112.6 with SMTP id u6mr12766119qap.78.1395783271430; Tue, 25 Mar 2014 14:34:31 -0700 (PDT) MIME-Version: 1.0 Received: by 10.224.168.72 with HTTP; Tue, 25 Mar 2014 14:34:11 -0700 (PDT) In-Reply-To: References: From: Yotam Barnoy Date: Tue, 25 Mar 2014 17:34:11 -0400 Message-ID: To: Anil Madhavapeddy Cc: Gabriel Scherer , "platform@lists.ocaml.org" , caml users Content-Type: multipart/alternative; boundary=001a11c2e84813be8004f5751e23 Subject: Re: [Caml-list] [ocaml-platform] [ANN] Experiment: OCaml patch review on github.com/ocaml/ocaml --001a11c2e84813be8004f5751e23 Content-Type: text/plain; charset=ISO-8859-1 This is incredible! Now let's get them all compiling and running unit tests on Travis! Yotam On Tue, Mar 25, 2014 at 12:40 PM, Anil Madhavapeddy wrote: > As a followup to this, I've written a script that syncs all the > open pull requests against the compiler as OPAM compiler switches. > This is now running live on the central OPAM respository. > > For instance, if you now `opam update` and look at your switches: > > $ opam switch --all > -- -- 4.02.0dev+pr10 Add String.{split,rsplit} > -- -- 4.02.0dev+pr13 Add String.{cut,rcut}. > -- -- 4.02.0dev+pr14 Add absolute directory names to > bytecode format for ocamldebug to use > -- -- 4.02.0dev+pr15 replace String.blit by > String.unsafe_blit > -- -- 4.02.0dev+pr17 Cmm arithmetic optimisations > -- -- 4.02.0dev+pr18 Patch for issue 5584 > -- -- 4.02.0dev+pr2 Parse -.x**2. (unary -.) as > -.(x**2.). Fix PR#3414 > -- -- 4.02.0dev+pr20 OCamlbuild: Fix the check of > ocamlfind > -- -- 4.02.0dev+pr3 Extend record punning to allow > destructuring. > -- -- 4.02.0dev+pr4 Fix for PR#4832 (Filling bigarrays > may block out runtime) > -- -- 4.02.0dev+pr6 Warn user when a type variable in a > type constraint has been instantiated. > -- -- 4.02.0dev+pr7 Extend ocamllex with actions before > refilling > -- -- 4.02.0dev+pr8 Adds a .gitignore to ignore all > generated files during `make world.opt' > -- -- 4.02.0dev+pr9 FreeBSD 10 uses clang by default, > with gcc not available by default > -- -- 4.02.0dev+trunk latest trunk snapshot > > Each switch corresponds to the current development trunk, with the > diff in the PR applied. If the patch is sane, you can proceed to > install OPAM packages in the experimental tree as usual without > affecting your day-to-day compiler switch. > > Hope this is useful! More details at: > http://anil.recoil.org/2014/03/25/ocaml-github-and-opam.html > > It's set to run daily at the moment, and switches will be deleted once > the corresponding pull request is closed. > > cheers, > Anil > > On 30 Jan 2014, at 11:34, Gabriel Scherer > wrote: > > > TL;DR: During the six next months, we will follow pull requests (PR) > > posted on the github mirror of the OCaml distribution, as an > > alternative to the mantis bugtracker. This experiment hopes to attract > > more people to participate in the extremely helpful and surprisingly > > rewarding activity of patch reviews. > > > > > > Dear OCaml community, > > > > I think we need more people ready to review patches proposed for > > inclusion in the OCaml compiler/distribution; lack of reviews is > > currently one of the bottleneck in the development process -- among > > others, such as the sheer difficulty to reach consensus on any change > > to the language itself. Doing patch reviews is helpful, extremely > > interesting, and an excellent way to get to know more about small > > parts of the compiler. > > > > There was a resurgence of discussions on caml-list (Yotam Barnoy's > > [moving to github] and Adrien Nader's thoughtful proposal of > > a [mailing-list for patch review]). Amir Chaudhry launched a poll to > > record decreasing order of preference, and the [results] are > > clear-cut: people hate Mantis' guts, and would rather use anything > > else. > > > > [moving to github]: http://alan.petitepomme.net/cwn/2013.12.24.html#5 > > [mailing-list for patch review]: > > https://sympa.inria.fr/sympa/arc/caml-list/2014-01/msg00055.html > > [results]: > https://docs.google.com/forms/d/1QWhqJRv1yPvdi6E3AiqbvUwlqGorV_Wbk7h_JYuDUiQ/viewanalytics > > > > I declare open the following experiment: for six months, starting > > today upto late July, patches proposed for the OCaml distribution may > > be submitted as a pull request (PR) on the [main github mirror], and > > we warmly encourage anyone to review the proposed patches, and make > > any comments they feel can help. Anything that can help improve the > > contribution, or discuss potential issues (backward compatibility, > > future-proofiness of the change, alternative designs...) will speed up > > the time between a patch proposal and a clear decision to integrate it > > or not. > > > > [main github mirror]: https://github.com/ocaml/ocaml/ > > > > In six months, we will reconsider, the default choice being to stop > > using github and revert to a mantis-only workflow. In the meantime, > > I will mirror the github PRs on the mantis side, so that contributors > > that do not wish to use the github interface can continue working as > > before. Patches and reviews are of course still welcome on mantis. > > > > Note that github will *not* be used for issue tracking, only for patch > > reviews. If you want to submit a patch against a bug discussed in > > Mantis, or want to re-submit a patch already in Mantis (in the wild > > hope of more eyeballs), feel free to send a github PR and link to it > > from the bugtracker. Finally, the github mirror remains *read-only*: > > if patches are accepted, the PR will be closed but will be committed > > to the SVN first, and synced in git as usual. > > > > We're just trying things to see if it works better. I hope it does. In > > any case, thanks in advance for your participation -- whichever tool > > you use. Happy hacking! > > > > . > > > > PS: If you want to get notified for all Pull Requests sent, you > > (need a github account and) can click on the "Watch" button in the top > > right of http://github.com/ocaml/ocaml to register for > > notifications. In the [notification settings] page of your account, > > you can set up notifications to get send by email and/or to the > > (mostly useless) github notification web interface. > > > > [notification settings](https://github.com/settings/notifications) > > _______________________________________________ > > Platform mailing list > > Platform@lists.ocaml.org > > http://lists.ocaml.org/listinfo/platform > > > > _______________________________________________ > Platform mailing list > Platform@lists.ocaml.org > http://lists.ocaml.org/listinfo/platform > --001a11c2e84813be8004f5751e23 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
This is incredible! Now let's get them all compil= ing and running unit tests on Travis!

Yotam

=


On Tue,= Mar 25, 2014 at 12:40 PM, Anil Madhavapeddy <anil@recoil.org> wrote:
As a followup to this, I've written a sc= ript that syncs all the
open pull requests against the compiler as OPAM compiler switches.
This is now running live on the central OPAM respository.

For instance, if you now `opam update` and look at your switches:

$ opam switch --all
-- =A0 =A0 -- 4.02.0dev+pr10 =A0 =A0 =A0 =A0 =A0 =A0 =A0Add String.{split,r= split}
-- =A0 =A0 -- 4.02.0dev+pr13 =A0 =A0 =A0 =A0 =A0 =A0 =A0Add String.{cut,rcu= t}.
-- =A0 =A0 -- 4.02.0dev+pr14 =A0 =A0 =A0 =A0 =A0 =A0 =A0Add absolute direct= ory names to bytecode format for ocamldebug to use
-- =A0 =A0 -- 4.02.0dev+pr15 =A0 =A0 =A0 =A0 =A0 =A0 =A0replace String.blit= by String.unsafe_blit
-- =A0 =A0 -- 4.02.0dev+pr17 =A0 =A0 =A0 =A0 =A0 =A0 =A0Cmm arithmetic opti= misations
-- =A0 =A0 -- 4.02.0dev+pr18 =A0 =A0 =A0 =A0 =A0 =A0 =A0Patch for issue 558= 4
-- =A0 =A0 -- 4.02.0dev+pr2 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Parse -.x**2. (unar= y -.) as -.(x**2.). =A0Fix PR#3414
-- =A0 =A0 -- 4.02.0dev+pr20 =A0 =A0 =A0 =A0 =A0 =A0 =A0OCamlbuild: Fix the= check of ocamlfind
-- =A0 =A0 -- 4.02.0dev+pr3 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Extend record punni= ng to allow destructuring.
-- =A0 =A0 -- 4.02.0dev+pr4 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Fix for PR#4832 (Fi= lling bigarrays may block out runtime)
-- =A0 =A0 -- 4.02.0dev+pr6 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Warn user when a ty= pe variable in a type constraint has been instantiated.
-- =A0 =A0 -- 4.02.0dev+pr7 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Extend ocamllex wit= h actions before refilling
-- =A0 =A0 -- 4.02.0dev+pr8 =A0 =A0 =A0 =A0 =A0 =A0 =A0 Adds a .gitignore t= o ignore all generated files during `make world.opt'
-- =A0 =A0 -- 4.02.0dev+pr9 =A0 =A0 =A0 =A0 =A0 =A0 =A0 FreeBSD 10 uses cla= ng by default, with gcc not available by default
-- =A0 =A0 -- 4.02.0dev+trunk =A0 =A0 =A0 =A0 =A0 =A0 latest trunk snapshot=

Each switch corresponds to the current development trunk, with the
diff in the PR applied. =A0If the patch is sane, you can proceed to
install OPAM packages in the experimental tree as usual without
affecting your day-to-day compiler switch.

Hope this is useful! =A0More details at:
http://anil.recoil.org/2014/03/25/ocaml-github-and-opam.htm= l

It's set to run daily at the moment, and switches will be deleted once<= br> the corresponding pull request is closed.

cheers,
Anil

On 30 Jan 2014, at 11:34, Gabriel Scherer <gabriel.scherer@gmail.com> wrote:

> TL;DR: During the six next months, we will follow pull requests (PR) > posted on the github mirror of the OCaml distribution, as an
> alternative to the mantis bugtracker. This experiment hopes to attract=
> more people to participate in the extremely helpful and surprisingly > rewarding activity of patch reviews.
>
>
> Dear OCaml community,
>
> I think we need more people ready to review patches proposed for
> inclusion in the OCaml compiler/distribution; lack of reviews is
> currently one of the bottleneck in the development process -- among
> others, such as the sheer difficulty to reach consensus on any change<= br> > to the language itself. Doing patch reviews is helpful, extremely
> interesting, and an excellent way to get to know more about small
> parts of the compiler.
>
> There was a resurgence of discussions on caml-list (Yotam Barnoy's=
> [moving to github] and Adrien Nader's thoughtful proposal of
> a [mailing-list for patch review]). Amir Chaudhry launched a poll to > record decreasing order of preference, and the [results] are
> clear-cut: people hate Mantis' guts, and would rather use anything=
> else.
>
> [moving to github]: http://alan.petitepomme.net/cwn/2013.12.24.ht= ml#5
> [mailing-list for patch review]:
> https://sympa.inria.fr/sympa/arc/caml-list/2014-01= /msg00055.html
> [results]: https://docs.= google.com/forms/d/1QWhqJRv1yPvdi6E3AiqbvUwlqGorV_Wbk7h_JYuDUiQ/viewanalyti= cs
>
> I declare open the following experiment: for six months, starting
> today upto late July, patches proposed for the OCaml distribution may<= br> > be submitted as a pull request (PR) on the [main github mirror], and > we warmly encourage anyone to review the proposed patches, and make
> any comments they feel can help. Anything that can help improve the
> contribution, or discuss potential issues (backward compatibility,
> future-proofiness of the change, alternative designs...) will speed up=
> the time between a patch proposal and a clear decision to integrate it=
> or not.
>
> [main github mirror]: https://github.com/ocaml/ocaml/
>
> In six months, we will reconsider, the default choice being to stop
> using github and revert to a mantis-only workflow. In the meantime,
> I will mirror the github PRs on the mantis side, so that contributors<= br> > that do not wish to use the github interface can continue working as > before. Patches and reviews are of course still welcome on mantis.
>
> Note that github will *not* be used for issue tracking, only for patch=
> reviews. If you want to submit a patch against a bug discussed in
> Mantis, or want to re-submit a patch already in Mantis (in the wild
> hope of more eyeballs), feel free to send a github PR and link to it > from the bugtracker. Finally, the github mirror remains *read-only*: > if patches are accepted, the PR will be closed but will be committed > to the SVN first, and synced in git as usual.
>
> We're just trying things to see if it works better. I hope it does= . In
> any case, thanks in advance for your participation -- whichever tool > you use. Happy hacking!
>
> .
>
> PS: If you want to get notified for all Pull Requests sent, you
> (need a github account and) can click on the "Watch" button = in the top
> right of h= ttp://github.com/ocaml/ocaml to register for
> notifications. In the [notification settings] page of your account,
> you can set up notifications to get send by email and/or to the
> (mostly useless) github notification web interface.
>
> [notification settings](https://github.com/settings/notifications)
> _______________________________________________
> Platform mailing list
> Platform@lists.ocaml.org
> http://lists.ocaml.org/listinfo/platform
>

_______________________________________________
Platform mailing list
Platform@lists.ocaml.org
http= ://lists.ocaml.org/listinfo/platform

--001a11c2e84813be8004f5751e23--